From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Alexander Tsoy" <alexander@tsoy.me>,
"Nicola Lunghi" <nick83ola@gmail.com>,
"Christopher Swenson" <swenson@swenson.io>,
"Nick Kossifidis" <mickflemm@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Ainge Hsu (徐巧宜)" <ainge.hsu@mediatek.com>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Macpaul Lin" <macpaul@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Wed, 18 Nov 2020 13:26:06 +0800 [thread overview]
Message-ID: <1605677166.23663.4.camel@mtkswgap22> (raw)
In-Reply-To: <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com>
On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote:
> The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> 96khz. However there will be some random issue under 96khz.
> Not sure if there is any alternate setting could be applied.
> Hence 48khz is suggested to be applied at this moment.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> Changes for v2:
> - Fix build error.
> - Add Cc: stable@vger.kernel.org
> Changes for v3:
> - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks.
>
> sound/usb/format.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 1b28d01..0aff774 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
> (chip->usb_id == USB_ID(0x041e, 0x4064) ||
> chip->usb_id == USB_ID(0x041e, 0x4068)))
> rate = 8000;
> + /* Huawei headset can't support 96kHz fully */
> + if (rate == 96000 &&
> + chip->usb_id == USB_ID(0x12d1, 0x3a07) &&
> + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49)
> + continue;
>
> fp->rate_table[fp->nr_rates] = rate;
> if (!fp->rate_min || rate < fp->rate_min)
Sorry for bothering again, please hold-on this patch.
I'm still trying to clarify if there is another approach for this
interoperability issue.
I'll update this thread once the result has came out.
Thanks
Macpaul Lin
WARNING: multiple messages have this Message-ID (diff)
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Christopher Swenson" <swenson@swenson.io>,
"Macpaul Lin" <macpaul@gmail.com>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"Alexander Tsoy" <alexander@tsoy.me>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Nick Kossifidis" <mickflemm@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Nicola Lunghi" <nick83ola@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Ainge Hsu (徐巧宜)" <ainge.hsu@mediatek.com>
Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Wed, 18 Nov 2020 13:26:06 +0800 [thread overview]
Message-ID: <1605677166.23663.4.camel@mtkswgap22> (raw)
In-Reply-To: <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com>
On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote:
> The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> 96khz. However there will be some random issue under 96khz.
> Not sure if there is any alternate setting could be applied.
> Hence 48khz is suggested to be applied at this moment.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> Changes for v2:
> - Fix build error.
> - Add Cc: stable@vger.kernel.org
> Changes for v3:
> - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks.
>
> sound/usb/format.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 1b28d01..0aff774 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
> (chip->usb_id == USB_ID(0x041e, 0x4064) ||
> chip->usb_id == USB_ID(0x041e, 0x4068)))
> rate = 8000;
> + /* Huawei headset can't support 96kHz fully */
> + if (rate == 96000 &&
> + chip->usb_id == USB_ID(0x12d1, 0x3a07) &&
> + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49)
> + continue;
>
> fp->rate_table[fp->nr_rates] = rate;
> if (!fp->rate_min || rate < fp->rate_min)
Sorry for bothering again, please hold-on this patch.
I'm still trying to clarify if there is another approach for this
interoperability issue.
I'll update this thread once the result has came out.
Thanks
Macpaul Lin
WARNING: multiple messages have this Message-ID (diff)
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Christopher Swenson" <swenson@swenson.io>,
"Macpaul Lin" <macpaul@gmail.com>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"Alexander Tsoy" <alexander@tsoy.me>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Nick Kossifidis" <mickflemm@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Nicola Lunghi" <nick83ola@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Ainge Hsu (徐巧宜)" <ainge.hsu@mediatek.com>
Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Wed, 18 Nov 2020 13:26:06 +0800 [thread overview]
Message-ID: <1605677166.23663.4.camel@mtkswgap22> (raw)
In-Reply-To: <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com>
On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote:
> The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> 96khz. However there will be some random issue under 96khz.
> Not sure if there is any alternate setting could be applied.
> Hence 48khz is suggested to be applied at this moment.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> Changes for v2:
> - Fix build error.
> - Add Cc: stable@vger.kernel.org
> Changes for v3:
> - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks.
>
> sound/usb/format.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 1b28d01..0aff774 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
> (chip->usb_id == USB_ID(0x041e, 0x4064) ||
> chip->usb_id == USB_ID(0x041e, 0x4068)))
> rate = 8000;
> + /* Huawei headset can't support 96kHz fully */
> + if (rate == 96000 &&
> + chip->usb_id == USB_ID(0x12d1, 0x3a07) &&
> + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49)
> + continue;
>
> fp->rate_table[fp->nr_rates] = rate;
> if (!fp->rate_min || rate < fp->rate_min)
Sorry for bothering again, please hold-on this patch.
I'm still trying to clarify if there is another approach for this
interoperability issue.
I'll update this thread once the result has came out.
Thanks
Macpaul Lin
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Christopher Swenson" <swenson@swenson.io>,
"Macpaul Lin" <macpaul@gmail.com>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"Alexander Tsoy" <alexander@tsoy.me>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Nick Kossifidis" <mickflemm@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Nicola Lunghi" <nick83ola@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Ainge Hsu (徐巧宜)" <ainge.hsu@mediatek.com>
Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Wed, 18 Nov 2020 13:26:06 +0800 [thread overview]
Message-ID: <1605677166.23663.4.camel@mtkswgap22> (raw)
In-Reply-To: <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com>
On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote:
> The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> 96khz. However there will be some random issue under 96khz.
> Not sure if there is any alternate setting could be applied.
> Hence 48khz is suggested to be applied at this moment.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> Changes for v2:
> - Fix build error.
> - Add Cc: stable@vger.kernel.org
> Changes for v3:
> - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks.
>
> sound/usb/format.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 1b28d01..0aff774 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
> (chip->usb_id == USB_ID(0x041e, 0x4064) ||
> chip->usb_id == USB_ID(0x041e, 0x4068)))
> rate = 8000;
> + /* Huawei headset can't support 96kHz fully */
> + if (rate == 96000 &&
> + chip->usb_id == USB_ID(0x12d1, 0x3a07) &&
> + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49)
> + continue;
>
> fp->rate_table[fp->nr_rates] = rate;
> if (!fp->rate_min || rate < fp->rate_min)
Sorry for bothering again, please hold-on this patch.
I'm still trying to clarify if there is another approach for this
interoperability issue.
I'll update this thread once the result has came out.
Thanks
Macpaul Lin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-18 5:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 8:04 [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET Macpaul Lin
2020-11-10 8:04 ` Macpaul Lin
2020-11-10 8:04 ` Macpaul Lin
2020-11-10 8:04 ` Macpaul Lin
2020-11-10 8:12 ` Takashi Iwai
2020-11-10 8:12 ` Takashi Iwai
2020-11-10 8:12 ` Takashi Iwai
2020-11-10 8:12 ` Takashi Iwai
2020-11-10 8:17 ` Macpaul Lin
2020-11-10 8:17 ` Macpaul Lin
2020-11-10 8:17 ` Macpaul Lin
2020-11-10 8:17 ` Macpaul Lin
2020-11-10 8:24 ` Takashi Iwai
2020-11-10 8:24 ` Takashi Iwai
2020-11-10 8:24 ` Takashi Iwai
2020-11-10 8:24 ` Takashi Iwai
2020-11-10 9:04 ` [PATCH v3] " Macpaul Lin
2020-11-10 9:04 ` Macpaul Lin
2020-11-10 9:04 ` Macpaul Lin
2020-11-10 9:04 ` Macpaul Lin
2020-11-18 5:26 ` Macpaul Lin [this message]
2020-11-18 5:26 ` Macpaul Lin
2020-11-18 5:26 ` Macpaul Lin
2020-11-18 5:26 ` Macpaul Lin
2020-11-18 7:34 ` Takashi Iwai
2020-11-18 7:34 ` Takashi Iwai
2020-11-18 7:34 ` Takashi Iwai
2020-11-18 7:34 ` Takashi Iwai
2020-11-10 8:42 ` [PATCH v2] " Macpaul Lin
2020-11-10 8:42 ` Macpaul Lin
2020-11-10 8:42 ` Macpaul Lin
2020-11-10 8:42 ` Macpaul Lin
2020-11-10 8:50 ` Greg KH
2020-11-10 8:50 ` Greg KH
2020-11-10 8:50 ` Greg KH
2020-11-10 8:50 ` Greg KH
2020-11-10 8:54 ` Macpaul Lin
2020-11-10 8:54 ` Macpaul Lin
2020-11-10 8:54 ` Macpaul Lin
2020-11-10 8:54 ` Macpaul Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605677166.23663.4.camel@mtkswgap22 \
--to=macpaul.lin@mediatek.com \
--cc=Chunfeng.Yun@mediatek.com \
--cc=Eddie.Hung@mediatek.com \
--cc=ainge.hsu@mediatek.com \
--cc=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mickflemm@gmail.com \
--cc=nick83ola@gmail.com \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=swenson@swenson.io \
--cc=tiwai@suse.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.