From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] arm64: dts: rockchip: rk3328: Fix UART pull-ups
Date: Fri, 4 Dec 2020 12:01:55 +0100 [thread overview]
Message-ID: <160707971061.1322141.15049981560864741595.b4-ty@sntech.de> (raw)
In-Reply-To: <20201204064805.6480-1-wens@kernel.org>
On Fri, 4 Dec 2020 14:48:05 +0800, Chen-Yu Tsai wrote:
> For UARTs, the local pull-ups should be on the RX pin, not the TX pin.
> UARTs transmit active-low, so a disconnected RX pin should be pulled
> high instead of left floating to prevent noise being interpreted as
> transmissions.
>
> This gets rid of bogus sysrq events when the UART console is not
> connected.
Applied, thanks!
[1/1] arm64: dts: rockchip: rk3328: Fix UART pull-ups
commit: 94dad6bed3c86c00050bf7c2b2ad6b630facae31
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@kernel.org>
Cc: devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: rk3328: Fix UART pull-ups
Date: Fri, 4 Dec 2020 12:01:55 +0100 [thread overview]
Message-ID: <160707971061.1322141.15049981560864741595.b4-ty@sntech.de> (raw)
In-Reply-To: <20201204064805.6480-1-wens@kernel.org>
On Fri, 4 Dec 2020 14:48:05 +0800, Chen-Yu Tsai wrote:
> For UARTs, the local pull-ups should be on the RX pin, not the TX pin.
> UARTs transmit active-low, so a disconnected RX pin should be pulled
> high instead of left floating to prevent noise being interpreted as
> transmissions.
>
> This gets rid of bogus sysrq events when the UART console is not
> connected.
Applied, thanks!
[1/1] arm64: dts: rockchip: rk3328: Fix UART pull-ups
commit: 94dad6bed3c86c00050bf7c2b2ad6b630facae31
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@kernel.org>
Cc: devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: rk3328: Fix UART pull-ups
Date: Fri, 4 Dec 2020 12:01:55 +0100 [thread overview]
Message-ID: <160707971061.1322141.15049981560864741595.b4-ty@sntech.de> (raw)
In-Reply-To: <20201204064805.6480-1-wens@kernel.org>
On Fri, 4 Dec 2020 14:48:05 +0800, Chen-Yu Tsai wrote:
> For UARTs, the local pull-ups should be on the RX pin, not the TX pin.
> UARTs transmit active-low, so a disconnected RX pin should be pulled
> high instead of left floating to prevent noise being interpreted as
> transmissions.
>
> This gets rid of bogus sysrq events when the UART console is not
> connected.
Applied, thanks!
[1/1] arm64: dts: rockchip: rk3328: Fix UART pull-ups
commit: 94dad6bed3c86c00050bf7c2b2ad6b630facae31
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-04 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 6:48 [PATCH] arm64: dts: rockchip: rk3328: Fix UART pull-ups Chen-Yu Tsai
2020-12-04 6:48 ` Chen-Yu Tsai
2020-12-04 6:48 ` Chen-Yu Tsai
2020-12-04 11:01 ` Heiko Stuebner [this message]
2020-12-04 11:01 ` Heiko Stuebner
2020-12-04 11:01 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160707971061.1322141.15049981560864741595.b4-ty@sntech.de \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.