From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/xmon: Change printk() to pr_cont()
Date: Thu, 10 Dec 2020 22:29:50 +1100 (AEDT) [thread overview]
Message-ID: <160756607247.1313423.10499331913215542406.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <c8a6ec704416ecd5ff2bd26213c9bc026bdd19de.1607077340.git.christophe.leroy@csgroup.eu>
On Fri, 4 Dec 2020 10:35:38 +0000 (UTC), Christophe Leroy wrote:
> Since some time now, printk() adds carriage return, leading to
> unusable xmon output:
>
> [ 54.288722] sysrq: Entering xmon
> [ 54.292209] Vector: 0 at [cace3d2c]
> [ 54.292274] pc:
> [ 54.292331] c0023650
> [ 54.292468] : xmon+0x28/0x58
> [ 54.292519]
> [ 54.292574] lr:
> [ 54.292630] c0023724
> [ 54.292749] : sysrq_handle_xmon+0xa4/0xfc
> [ 54.292801]
> [ 54.292867] sp: cace3de8
> [ 54.292931] msr: 9032
> [ 54.292999] current = 0xc28d0000
> [ 54.293072] pid = 377, comm = sh
> [ 54.293157] Linux version 5.10.0-rc6-s3k-dev-01364-gedf13f0ccd76-dirty (root@po17688vm.idsi0.si.c-s.fr) (powerpc64-linux-gcc (GCC) 10.1.0, GNU ld (GNU Binutils) 2.34) #4211 PREEMPT Fri Dec 4 09:32:11 UTC 2020
> [ 54.293287] enter ? for help
> [ 54.293470] [cace3de8]
> [ 54.293532] c0023724
> [ 54.293654] sysrq_handle_xmon+0xa4/0xfc
> [ 54.293711] (unreliable)
> [ 54.293859] [cace3e18]
> [ 54.293918] c03885a8
> [ 54.294056] __handle_sysrq+0xe4/0x1d4
> [ 54.294108]
> [ 54.294255] [cace3e48]
> [ 54.294314] c0388704
> [ 54.294441] write_sysrq_trigger+0x34/0x74
> [ 54.294493]
> [ 54.294641] [cace3e68]
> [ 54.294700] c01f65d0
> [ 54.294822] proc_reg_write+0xac/0x11c
> [ 54.294875]
> [ 54.295023] [cace3e88]
> [ 54.295082] c0179910
> [ 54.295198] vfs_write+0x134/0x46c
> [ 54.295250]
> [ 54.295396] [cace3f08]
> [ 54.295455] c0179de8
> [ 54.295567] ksys_write+0x78/0x11c
> [ 54.295619]
> [ 54.295766] [cace3f38]
> [ 54.295825] c00110d0
> [ 54.295951] ret_from_syscall+0x0/0x34
> [ 54.296002]
> [ 54.296159] --- Exception: c01 (System Call) at
> [ 54.296217] 0fd4e784
> [ 54.296303]
> [ 54.296375] SP (7fca6ff0) is in userspace
> [ 54.296431] mon>
> [ 54.296484] <no input ...>
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/xmon: Change printk() to pr_cont()
https://git.kernel.org/powerpc/c/7c6c86b36a36dd4a13d30bba07718e767aa2e7a1
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/xmon: Change printk() to pr_cont()
Date: Thu, 10 Dec 2020 22:29:50 +1100 (AEDT) [thread overview]
Message-ID: <160756607247.1313423.10499331913215542406.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <c8a6ec704416ecd5ff2bd26213c9bc026bdd19de.1607077340.git.christophe.leroy@csgroup.eu>
On Fri, 4 Dec 2020 10:35:38 +0000 (UTC), Christophe Leroy wrote:
> Since some time now, printk() adds carriage return, leading to
> unusable xmon output:
>
> [ 54.288722] sysrq: Entering xmon
> [ 54.292209] Vector: 0 at [cace3d2c]
> [ 54.292274] pc:
> [ 54.292331] c0023650
> [ 54.292468] : xmon+0x28/0x58
> [ 54.292519]
> [ 54.292574] lr:
> [ 54.292630] c0023724
> [ 54.292749] : sysrq_handle_xmon+0xa4/0xfc
> [ 54.292801]
> [ 54.292867] sp: cace3de8
> [ 54.292931] msr: 9032
> [ 54.292999] current = 0xc28d0000
> [ 54.293072] pid = 377, comm = sh
> [ 54.293157] Linux version 5.10.0-rc6-s3k-dev-01364-gedf13f0ccd76-dirty (root@po17688vm.idsi0.si.c-s.fr) (powerpc64-linux-gcc (GCC) 10.1.0, GNU ld (GNU Binutils) 2.34) #4211 PREEMPT Fri Dec 4 09:32:11 UTC 2020
> [ 54.293287] enter ? for help
> [ 54.293470] [cace3de8]
> [ 54.293532] c0023724
> [ 54.293654] sysrq_handle_xmon+0xa4/0xfc
> [ 54.293711] (unreliable)
> [ 54.293859] [cace3e18]
> [ 54.293918] c03885a8
> [ 54.294056] __handle_sysrq+0xe4/0x1d4
> [ 54.294108]
> [ 54.294255] [cace3e48]
> [ 54.294314] c0388704
> [ 54.294441] write_sysrq_trigger+0x34/0x74
> [ 54.294493]
> [ 54.294641] [cace3e68]
> [ 54.294700] c01f65d0
> [ 54.294822] proc_reg_write+0xac/0x11c
> [ 54.294875]
> [ 54.295023] [cace3e88]
> [ 54.295082] c0179910
> [ 54.295198] vfs_write+0x134/0x46c
> [ 54.295250]
> [ 54.295396] [cace3f08]
> [ 54.295455] c0179de8
> [ 54.295567] ksys_write+0x78/0x11c
> [ 54.295619]
> [ 54.295766] [cace3f38]
> [ 54.295825] c00110d0
> [ 54.295951] ret_from_syscall+0x0/0x34
> [ 54.296002]
> [ 54.296159] --- Exception: c01 (System Call) at
> [ 54.296217] 0fd4e784
> [ 54.296303]
> [ 54.296375] SP (7fca6ff0) is in userspace
> [ 54.296431] mon>
> [ 54.296484] <no input ...>
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/xmon: Change printk() to pr_cont()
https://git.kernel.org/powerpc/c/7c6c86b36a36dd4a13d30bba07718e767aa2e7a1
cheers
next prev parent reply other threads:[~2020-12-10 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 10:35 [PATCH] powerpc/xmon: Change printk() to pr_cont() Christophe Leroy
2020-12-04 10:35 ` Christophe Leroy
2020-12-04 10:56 ` Michael Ellerman
2020-12-04 10:56 ` Michael Ellerman
2020-12-04 15:55 ` Joe Perches
2020-12-04 15:55 ` Joe Perches
2020-12-10 11:29 ` Michael Ellerman [this message]
2020-12-10 11:29 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160756607247.1313423.10499331913215542406.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.