All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: Aggregate engine busyness per class
Date: Wed, 16 Dec 2020 15:52:58 +0000	[thread overview]
Message-ID: <160813397817.9127.12175358127476553962@build.alporthouse.com> (raw)
In-Reply-To: <160813391912.9127.16376546917210365956@build.alporthouse.com>

Quoting Chris Wilson (2020-12-16 15:51:59)
> Quoting Tvrtko Ursulin (2020-12-16 15:28:09)
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Similarly to how top(1) handles SMP, we can default to showing engines of
> > a same class as a single bar graph entry.
> > 
> > To achieve this a little bit of hackery is employed. PMU sampling is left
> > as is and only at the presentation layer we create a fake set of engines,
> > one for each class, summing and normalizing the load respectively.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Where were my manners?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] intel_gpu_top: Aggregate engine busyness per class
Date: Wed, 16 Dec 2020 15:52:58 +0000	[thread overview]
Message-ID: <160813397817.9127.12175358127476553962@build.alporthouse.com> (raw)
In-Reply-To: <160813391912.9127.16376546917210365956@build.alporthouse.com>

Quoting Chris Wilson (2020-12-16 15:51:59)
> Quoting Tvrtko Ursulin (2020-12-16 15:28:09)
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Similarly to how top(1) handles SMP, we can default to showing engines of
> > a same class as a single bar graph entry.
> > 
> > To achieve this a little bit of hackery is employed. PMU sampling is left
> > as is and only at the presentation layer we create a fake set of engines,
> > one for each class, summing and normalizing the load respectively.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Where were my manners?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-12-16 15:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 15:28 [Intel-gfx] [PATCH i-g-t 1/2] intel_gpu_top: Support exiting the tool by pressing 'q' Tvrtko Ursulin
2020-12-16 15:28 ` [igt-dev] " Tvrtko Ursulin
2020-12-16 15:28 ` [Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: Aggregate engine busyness per class Tvrtko Ursulin
2020-12-16 15:28   ` [igt-dev] " Tvrtko Ursulin
2020-12-16 15:51   ` [Intel-gfx] " Chris Wilson
2020-12-16 15:52     ` Chris Wilson [this message]
2020-12-16 15:52       ` Chris Wilson
2020-12-16 16:01     ` [Intel-gfx] " Tvrtko Ursulin
2020-12-16 16:01       ` Tvrtko Ursulin
2020-12-16 16:05       ` [Intel-gfx] " Chris Wilson
2020-12-16 16:05         ` Chris Wilson
2020-12-16 16:42         ` [Intel-gfx] [PATCH v2 " Tvrtko Ursulin
2020-12-16 16:42           ` [igt-dev] " Tvrtko Ursulin
2020-12-16 15:44 ` [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] intel_gpu_top: Support exiting the tool by pressing 'q' Chris Wilson
2020-12-16 15:44   ` Chris Wilson
2020-12-16 15:54   ` [Intel-gfx] [PATCH v2 " Tvrtko Ursulin
2020-12-16 15:54     ` [igt-dev] " Tvrtko Ursulin
2020-12-16 15:57     ` [Intel-gfx] " Chris Wilson
2020-12-17  8:31       ` Chris Wilson
2020-12-16 18:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,i-g-t,1/2] intel_gpu_top: Support exiting the tool by pressing 'q' (rev3) Patchwork
2020-12-16 21:08 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160813397817.9127.12175358127476553962@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.