All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaogang.Chen <xiaogang.chen@amd.com>
To: <amd-gfx@lists.freedesktop.org>, <harry.wentland@amd.com>,
	<dri-devel@lists.freedesktop.org>, <airlied@linux.ie>
Cc: xiaogang.chen@amd.com
Subject: [PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address.
Date: Mon, 4 Jan 2021 00:01:37 -0600	[thread overview]
Message-ID: <1609740098-32603-1-git-send-email-xiaogang.chen@amd.com> (raw)

From: Xiaogang Chen <xiaogang.chen@amd.com>

drm_dp_check_and_send_link_address discovers MST device topology.
It can return both positive and negative values. When it returns positive
values there is no error found. If it returns negative values there is error
found, such as get NAK , timeout, etc. Following drm_kms_helper_hotplug_event
should be called when drm_dp_check_and_send_link_address returns positive value.

Signed-off-by: Xiaogang Chen <xiaogang.chen@amd.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 17dbed0..3ef5206 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -2650,7 +2650,7 @@ static void drm_dp_mst_link_probe_work(struct work_struct *work)
 	drm_dp_mst_topology_put_mstb(mstb);
 
 	mutex_unlock(&mgr->probe_lock);
-	if (ret)
+	if (ret > 0)
 		drm_kms_helper_hotplug_event(dev);
 }
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Xiaogang.Chen <xiaogang.chen@amd.com>
To: <amd-gfx@lists.freedesktop.org>, <harry.wentland@amd.com>,
	<dri-devel@lists.freedesktop.org>, <airlied@linux.ie>
Cc: xiaogang.chen@amd.com
Subject: [PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address.
Date: Mon, 4 Jan 2021 00:01:37 -0600	[thread overview]
Message-ID: <1609740098-32603-1-git-send-email-xiaogang.chen@amd.com> (raw)

From: Xiaogang Chen <xiaogang.chen@amd.com>

drm_dp_check_and_send_link_address discovers MST device topology.
It can return both positive and negative values. When it returns positive
values there is no error found. If it returns negative values there is error
found, such as get NAK , timeout, etc. Following drm_kms_helper_hotplug_event
should be called when drm_dp_check_and_send_link_address returns positive value.

Signed-off-by: Xiaogang Chen <xiaogang.chen@amd.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 17dbed0..3ef5206 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -2650,7 +2650,7 @@ static void drm_dp_mst_link_probe_work(struct work_struct *work)
 	drm_dp_mst_topology_put_mstb(mstb);
 
 	mutex_unlock(&mgr->probe_lock);
-	if (ret)
+	if (ret > 0)
 		drm_kms_helper_hotplug_event(dev);
 }
 
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

             reply	other threads:[~2021-01-04  6:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04  6:01 Xiaogang.Chen [this message]
2021-01-04  6:01 ` [PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address Xiaogang.Chen
2021-01-04  6:01 ` [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work Xiaogang.Chen
2021-01-04  6:01   ` Xiaogang.Chen
2021-01-12  6:37   ` Chen, Xiaogang
2021-01-12  6:37     ` Chen, Xiaogang
2021-01-13  0:54     ` Chen, Xiaogang
2021-01-13  4:54   ` Andrey Grodzovsky
2021-01-13  4:54     ` Andrey Grodzovsky
2021-01-14  5:11     ` Chen, Xiaogang
2021-01-14  5:11       ` Chen, Xiaogang
2021-01-14  7:24       ` Andrey Grodzovsky
2021-01-14  7:24         ` Andrey Grodzovsky
2021-01-15  7:21         ` Chen, Xiaogang
2021-01-15  7:21           ` Chen, Xiaogang
2021-01-19 22:29           ` Andrey Grodzovsky
2021-01-19 22:29             ` Andrey Grodzovsky
2021-01-22 20:55             ` Chen, Xiaogang
2021-01-22 20:55               ` Chen, Xiaogang
2021-02-26 22:52               ` Aurabindo Pillai
2021-02-26 22:52                 ` Aurabindo Pillai
2021-01-12  6:36 ` [PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address Chen, Xiaogang
2021-01-12  6:36   ` Chen, Xiaogang
2021-01-12  9:21   ` Simon Ser
2021-01-12  9:21     ` Simon Ser
2021-01-12 14:45     ` Simon Ser
2021-01-12 14:45       ` Simon Ser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609740098-32603-1-git-send-email-xiaogang.chen@amd.com \
    --to=xiaogang.chen@amd.com \
    --cc=airlied@linux.ie \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.