All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 01/19] serial: sh-sci: Enable the driver on all ARM platforms
Date: Wed, 19 Feb 2014 22:24:38 +0000	[thread overview]
Message-ID: <1609898.QTd44x6TTB@avalon> (raw)
In-Reply-To: <20140219205446.GD6988@pengutronix.de>

Hi Uwe,

On Wednesday 19 February 2014 21:54:46 Uwe Kleine-König wrote:
> On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> > COMPILE_TEST.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-serial@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/tty/serial/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index febd45c..9a5a8ef 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
> > 
> >  config SERIAL_SH_SCI
> >  
> >  	tristate "SuperH SCI(F) serial port support"
> > 
> > -	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE)
> > +	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> > 
> >  	select SERIAL_CORE
> 
> This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc
> since v3.13-rc1. I wonder if
> 
> 	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST)
> 
> isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187
> ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile
> configs.) Or do you plan to deprecate ARCH_SHMOBILE?

We don't plan to deprecate ARCH_SHMOBILE. I've posted a patch to fix this, 
please see http://www.spinics.net/lists/linux-sh/msg28296.html ("[PATCH 1/2] 
serial: sh-sci: Restrict non-COMPILE_TEST compilation").

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-sh@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 01/19] serial: sh-sci: Enable the driver on all ARM platforms
Date: Wed, 19 Feb 2014 23:24:38 +0100	[thread overview]
Message-ID: <1609898.QTd44x6TTB@avalon> (raw)
In-Reply-To: <20140219205446.GD6988@pengutronix.de>

Hi Uwe,

On Wednesday 19 February 2014 21:54:46 Uwe Kleine-König wrote:
> On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> > COMPILE_TEST.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-serial@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/tty/serial/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index febd45c..9a5a8ef 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
> > 
> >  config SERIAL_SH_SCI
> >  
> >  	tristate "SuperH SCI(F) serial port support"
> > 
> > -	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE)
> > +	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> > 
> >  	select SERIAL_CORE
> 
> This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc
> since v3.13-rc1. I wonder if
> 
> 	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST)
> 
> isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187
> ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile
> configs.) Or do you plan to deprecate ARCH_SHMOBILE?

We don't plan to deprecate ARCH_SHMOBILE. I've posted a patch to fix this, 
please see http://www.spinics.net/lists/linux-sh/msg28296.html ("[PATCH 1/2] 
serial: sh-sci: Restrict non-COMPILE_TEST compilation").

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/19] serial: sh-sci: Enable the driver on all ARM platforms
Date: Wed, 19 Feb 2014 23:24:38 +0100	[thread overview]
Message-ID: <1609898.QTd44x6TTB@avalon> (raw)
In-Reply-To: <20140219205446.GD6988@pengutronix.de>

Hi Uwe,

On Wednesday 19 February 2014 21:54:46 Uwe Kleine-K?nig wrote:
> On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> > COMPILE_TEST.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-serial at vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/tty/serial/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index febd45c..9a5a8ef 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
> > 
> >  config SERIAL_SH_SCI
> >  
> >  	tristate "SuperH SCI(F) serial port support"
> > 
> > -	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE)
> > +	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> > 
> >  	select SERIAL_CORE
> 
> This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc
> since v3.13-rc1. I wonder if
> 
> 	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST)
> 
> isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187
> ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile
> configs.) Or do you plan to deprecate ARCH_SHMOBILE?

We don't plan to deprecate ARCH_SHMOBILE. I've posted a patch to fix this, 
please see http://www.spinics.net/lists/linux-sh/msg28296.html ("[PATCH 1/2] 
serial: sh-sci: Restrict non-COMPILE_TEST compilation").

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2014-02-19 22:24 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 22:37 [PATCH v2 00/19] Enable various Renesas drivers on all ARM platforms Laurent Pinchart
2013-10-29 22:37 ` Laurent Pinchart
2013-10-29 22:37 ` Laurent Pinchart
2013-10-29 22:37 ` Laurent Pinchart
2013-10-29 22:37 ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 01/19] serial: sh-sci: Enable the driver " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2014-02-19 20:54   ` Uwe Kleine-König
2014-02-19 20:54     ` Uwe Kleine-König
2014-02-19 20:54     ` Uwe Kleine-König
2014-02-19 22:24     ` Laurent Pinchart [this message]
2014-02-19 22:24       ` Laurent Pinchart
2014-02-19 22:24       ` Laurent Pinchart
2014-02-20  0:00       ` Uwe Kleine-König
2014-02-20  0:00         ` Uwe Kleine-König
2014-02-20  0:00         ` Uwe Kleine-König
2013-10-29 22:37 ` [PATCH v2 02/19] DMA: shdma: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 03/19] i2c: sh_mobile: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-31 11:50   ` Wolfram Sang
2013-10-31 11:50     ` Wolfram Sang
2013-10-31 11:50     ` Wolfram Sang
2013-10-29 22:37 ` [PATCH v2 04/19] input: sh_keysc: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-31  7:54   ` Dmitry Torokhov
2013-10-31  7:54     ` Dmitry Torokhov
2013-10-31  7:54     ` Dmitry Torokhov
2013-10-29 22:37 ` [PATCH v2 05/19] iommu: shmobile: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-11-01 13:43   ` Joerg Roedel
2013-11-01 13:43     ` Joerg Roedel
2013-11-01 13:43     ` Joerg Roedel
2013-10-29 22:37 ` [PATCH v2 06/19] i2c: rcar: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 07/19] v4l: sh_vou: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 08/19] mmc: sdhi: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-30 11:23   ` [PATCH] " Laurent Pinchart
2013-10-30 11:23     ` Laurent Pinchart
2013-10-30 11:23     ` Laurent Pinchart
2013-10-30 11:23     ` Laurent Pinchart
2013-10-30 11:23       ` Laurent Pinchart
2013-10-30 11:23       ` Laurent Pinchart
2013-10-31  8:26     ` Magnus Damm
2013-10-31  8:26       ` Magnus Damm
2013-10-31  8:26       ` Magnus Damm
2013-10-31 11:59       ` Laurent Pinchart
2013-10-31 12:00         ` Laurent Pinchart
2013-10-31 12:00         ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 09/19] mmc: sh_mmcif: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-30 11:34   ` [PATCH v3 1/3] mmc: sh_mmcif: Factorize DMA channel request and configuration code Laurent Pinchart
2013-10-30 11:34     ` Laurent Pinchart
2013-10-30 11:34     ` Laurent Pinchart
2013-10-30 11:34     ` [PATCH v3 2/3] mmc: sh_mmcif: Fix compilation warning on 64-bit platforms Laurent Pinchart
2013-10-30 11:34       ` Laurent Pinchart
2013-10-30 11:34       ` Laurent Pinchart
2013-10-30 11:34     ` [PATCH v3 3/3] mmc: sh_mmcif: Enable the driver on all ARM platforms Laurent Pinchart
2013-10-30 11:34       ` Laurent Pinchart
2013-10-30 11:34       ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 10/19] mtd: sh_flctl: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-11-12 23:10   ` Brian Norris
2013-11-12 23:10     ` Brian Norris
2013-11-12 23:10     ` Brian Norris
2013-11-12 23:14     ` Laurent Pinchart
2013-11-12 23:14       ` Laurent Pinchart
2013-11-12 23:14       ` Laurent Pinchart
2013-11-12 23:17       ` Brian Norris
2013-11-12 23:17         ` Brian Norris
2013-11-12 23:17         ` Brian Norris
2013-11-12 23:20         ` Laurent Pinchart
2013-11-12 23:20           ` Laurent Pinchart
2013-11-12 23:20           ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 11/19] net: sh_eth: Set receive alignment correctly " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 12/19] irda: sh_irda: Enable the driver " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 13/19] pinctrl: sh-pfc: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 14/19] pwm: pwm-renesas-tpu: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 15/19] sh: intc: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 16/19] spi: sh_msiof: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 17/19] spi: sh_hspi: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 18/19] thermal: rcar-thermal: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 19/19] fbdev: sh-mobile-lcdcfb: " Laurent Pinchart
2013-10-29 22:37   ` Laurent Pinchart
2013-10-31 19:42   ` Geert Uytterhoeven
2013-10-31 19:42     ` Geert Uytterhoeven
2013-11-06  0:27     ` Laurent Pinchart
2013-11-06  0:27       ` Laurent Pinchart
2013-11-06  8:46       ` Geert Uytterhoeven
2013-11-06  8:46         ` Geert Uytterhoeven
2013-10-31  5:52 ` [PATCH v2 00/19] Enable various Renesas drivers " Simon Horman
2013-10-31  5:52   ` Simon Horman
2013-10-31  5:52   ` Simon Horman
2013-10-31  5:52   ` Simon Horman
     [not found] ` <1383086274-11049-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2013-11-12 23:32   ` Laurent Pinchart
2013-11-12 23:32     ` Laurent Pinchart
2013-11-12 23:32     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609898.QTd44x6TTB@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.