From: SkyLake Huang <skylake.huang@mediatek.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: <linux-mediatek@lists.infradead.org>,
Frank Wunderlich <frank-w@public-files.de>,
Rob Herring <robh+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
"Jimin Wang" <jimin.wang@mediatek.com>,
Ryder Lee <ryder.lee@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
sin_wenjiehu <sin_wenjiehu@mediatek.com>,
<Wenbin.Mei@mediatek.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] dts64: mt7622: fix slow sd card access
Date: Thu, 21 Jan 2021 14:24:38 +0800 [thread overview]
Message-ID: <1611210278.32249.12.camel@mtksdccf07> (raw)
In-Reply-To: <20210113180919.49523-1-linux@fw-web.de>
On Wed, 2021-01-13 at 19:09 +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Fix extreme slow speed (200MB takes ~20 min) on writing sdcard on
> bananapi-r64 by adding reset-control for mmc1 like it's done for mmc0/emmc.
>
> Cc: stable@vger.kernel.org
> Fixes: 2c002a3049f7 ("arm64: dts: mt7622: add mmc related device nodes")
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> changes since v1:
> - drop change to uhs-mode because mt7622 does not support it
> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 5b9ec032ce8d..7c6d871538a6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -698,6 +698,8 @@ mmc1: mmc@11240000 {
> clocks = <&pericfg CLK_PERI_MSDC30_1_PD>,
> <&topckgen CLK_TOP_AXI_SEL>;
> clock-names = "source", "hclk";
> + resets = <&pericfg MT7622_PERI_MSDC1_SW_RST>;
> + reset-names = "hrst";
This looks ok to me. I think it's also necessary to trigger software
reset for SD(mmc1) because loader(uboot) might mess up MSDC's registers.
"Software reset" here will reset registers of AHB/AXI bus domain, such
as MSDC_CFG[8:15]. msdc_reset_hw() in mtk-sd.c will only reset registers
of MSDC CK domain.
WARNING: multiple messages have this Message-ID (diff)
From: SkyLake Huang <skylake.huang@mediatek.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: devicetree@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>,
Wenbin.Mei@mediatek.com, sin_wenjiehu <sin_wenjiehu@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Sean Wang <sean.wang@mediatek.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Jimin Wang <jimin.wang@mediatek.com>
Subject: Re: [PATCH v2] dts64: mt7622: fix slow sd card access
Date: Thu, 21 Jan 2021 14:24:38 +0800 [thread overview]
Message-ID: <1611210278.32249.12.camel@mtksdccf07> (raw)
In-Reply-To: <20210113180919.49523-1-linux@fw-web.de>
On Wed, 2021-01-13 at 19:09 +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Fix extreme slow speed (200MB takes ~20 min) on writing sdcard on
> bananapi-r64 by adding reset-control for mmc1 like it's done for mmc0/emmc.
>
> Cc: stable@vger.kernel.org
> Fixes: 2c002a3049f7 ("arm64: dts: mt7622: add mmc related device nodes")
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> changes since v1:
> - drop change to uhs-mode because mt7622 does not support it
> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 5b9ec032ce8d..7c6d871538a6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -698,6 +698,8 @@ mmc1: mmc@11240000 {
> clocks = <&pericfg CLK_PERI_MSDC30_1_PD>,
> <&topckgen CLK_TOP_AXI_SEL>;
> clock-names = "source", "hclk";
> + resets = <&pericfg MT7622_PERI_MSDC1_SW_RST>;
> + reset-names = "hrst";
This looks ok to me. I think it's also necessary to trigger software
reset for SD(mmc1) because loader(uboot) might mess up MSDC's registers.
"Software reset" here will reset registers of AHB/AXI bus domain, such
as MSDC_CFG[8:15]. msdc_reset_hw() in mtk-sd.c will only reset registers
of MSDC CK domain.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: SkyLake Huang <skylake.huang@mediatek.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: devicetree@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>,
Wenbin.Mei@mediatek.com, sin_wenjiehu <sin_wenjiehu@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Sean Wang <sean.wang@mediatek.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Jimin Wang <jimin.wang@mediatek.com>
Subject: Re: [PATCH v2] dts64: mt7622: fix slow sd card access
Date: Thu, 21 Jan 2021 14:24:38 +0800 [thread overview]
Message-ID: <1611210278.32249.12.camel@mtksdccf07> (raw)
In-Reply-To: <20210113180919.49523-1-linux@fw-web.de>
On Wed, 2021-01-13 at 19:09 +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Fix extreme slow speed (200MB takes ~20 min) on writing sdcard on
> bananapi-r64 by adding reset-control for mmc1 like it's done for mmc0/emmc.
>
> Cc: stable@vger.kernel.org
> Fixes: 2c002a3049f7 ("arm64: dts: mt7622: add mmc related device nodes")
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> changes since v1:
> - drop change to uhs-mode because mt7622 does not support it
> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 5b9ec032ce8d..7c6d871538a6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -698,6 +698,8 @@ mmc1: mmc@11240000 {
> clocks = <&pericfg CLK_PERI_MSDC30_1_PD>,
> <&topckgen CLK_TOP_AXI_SEL>;
> clock-names = "source", "hclk";
> + resets = <&pericfg MT7622_PERI_MSDC1_SW_RST>;
> + reset-names = "hrst";
This looks ok to me. I think it's also necessary to trigger software
reset for SD(mmc1) because loader(uboot) might mess up MSDC's registers.
"Software reset" here will reset registers of AHB/AXI bus domain, such
as MSDC_CFG[8:15]. msdc_reset_hw() in mtk-sd.c will only reset registers
of MSDC CK domain.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-21 6:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 18:09 [PATCH v2] dts64: mt7622: fix slow sd card access Frank Wunderlich
2021-01-13 18:09 ` Frank Wunderlich
2021-01-13 18:09 ` Frank Wunderlich
2021-01-21 6:24 ` SkyLake Huang [this message]
2021-01-21 6:24 ` SkyLake Huang
2021-01-21 6:24 ` SkyLake Huang
2021-01-31 15:02 ` Matthias Brugger
2021-01-31 15:02 ` Matthias Brugger
2021-01-31 15:02 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611210278.32249.12.camel@mtksdccf07 \
--to=skylake.huang@mediatek.com \
--cc=Wenbin.Mei@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=jimin.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=sin_wenjiehu@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.