From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi.shyti@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
Pan Bian <bianpan2016@163.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Pan Bian <bianpan2016@163.com>
Subject: Re: [PATCH] drm/i915/selftest: Fix potential memory leak
Date: Fri, 22 Jan 2021 09:29:32 +0000 [thread overview]
Message-ID: <161130777297.28599.8771475730453120887@build.alporthouse.com> (raw)
In-Reply-To: <20210122015640.16002-1-bianpan2016@163.com>
Quoting Pan Bian (2021-01-22 01:56:40)
> Object out is not released on path that no VMA instance found. The root
> cause is jumping to an unexpected label on the error path.
Wouldn't the root cause be whatever caused the allocation to fail?
Language notwithstanding,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi.shyti@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
Pan Bian <bianpan2016@163.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Pan Bian <bianpan2016@163.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftest: Fix potential memory leak
Date: Fri, 22 Jan 2021 09:29:32 +0000 [thread overview]
Message-ID: <161130777297.28599.8771475730453120887@build.alporthouse.com> (raw)
In-Reply-To: <20210122015640.16002-1-bianpan2016@163.com>
Quoting Pan Bian (2021-01-22 01:56:40)
> Object out is not released on path that no VMA instance found. The root
> cause is jumping to an unexpected label on the error path.
Wouldn't the root cause be whatever caused the allocation to fail?
Language notwithstanding,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi.shyti@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
Pan Bian <bianpan2016@163.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Pan Bian <bianpan2016@163.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftest: Fix potential memory leak
Date: Fri, 22 Jan 2021 09:29:32 +0000 [thread overview]
Message-ID: <161130777297.28599.8771475730453120887@build.alporthouse.com> (raw)
In-Reply-To: <20210122015640.16002-1-bianpan2016@163.com>
Quoting Pan Bian (2021-01-22 01:56:40)
> Object out is not released on path that no VMA instance found. The root
> cause is jumping to an unexpected label on the error path.
Wouldn't the root cause be whatever caused the allocation to fail?
Language notwithstanding,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-22 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 1:56 [PATCH] drm/i915/selftest: Fix potential memory leak Pan Bian
2021-01-22 1:56 ` [Intel-gfx] " Pan Bian
2021-01-22 1:56 ` Pan Bian
2021-01-22 9:29 ` Chris Wilson [this message]
2021-01-22 9:29 ` [Intel-gfx] " Chris Wilson
2021-01-22 9:29 ` Chris Wilson
2021-01-22 18:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161130777297.28599.8771475730453120887@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=andi.shyti@intel.com \
--cc=bianpan2016@163.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=mika.kuoppala@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.