From: Chris Wilson <chris@chris-wilson.co.uk>
To: Thomas Zimmermann <tzimmermann@suse.de>,
airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
joonas.lahtinen@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [PATCH v5 4/5] drm/i915: Don't assign to struct drm_device.pdev
Date: Wed, 27 Jan 2021 12:54:58 +0000 [thread overview]
Message-ID: <161175209876.2943.13596593111578124710@build.alporthouse.com> (raw)
In-Reply-To: <20210127124135.11750-5-tzimmermann@suse.de>
Quoting Thomas Zimmermann (2021-01-27 12:41:34)
> Using struct drm_device.pdev is deprecated. Don't assign it. Users
> should upcast from struct drm_device.dev.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 700aeb923fcd..954ad590089c 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -787,7 +787,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (IS_ERR(i915))
> return i915;
>
> - i915->drm.pdev = pdev;
> pci_set_drvdata(pdev, i915);
>
> /* Device parameters start as a copy of module parameters. */
Stick the mock
- i915->drm.pdev = pdev;
in this patch, and I'm happy.
With that, the series is
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Thomas Zimmermann <tzimmermann@suse.de>,
airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
joonas.lahtinen@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [PATCH v5 4/5] drm/i915: Don't assign to struct drm_device.pdev
Date: Wed, 27 Jan 2021 12:54:58 +0000 [thread overview]
Message-ID: <161175209876.2943.13596593111578124710@build.alporthouse.com> (raw)
In-Reply-To: <20210127124135.11750-5-tzimmermann@suse.de>
Quoting Thomas Zimmermann (2021-01-27 12:41:34)
> Using struct drm_device.pdev is deprecated. Don't assign it. Users
> should upcast from struct drm_device.dev.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 700aeb923fcd..954ad590089c 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -787,7 +787,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (IS_ERR(i915))
> return i915;
>
> - i915->drm.pdev = pdev;
> pci_set_drvdata(pdev, i915);
>
> /* Device parameters start as a copy of module parameters. */
Stick the mock
- i915->drm.pdev = pdev;
in this patch, and I'm happy.
With that, the series is
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-27 12:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 12:41 [PATCH v5 0/5] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 12:41 ` [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev Thomas Zimmermann
2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 12:52 ` Chris Wilson
2021-01-27 12:52 ` [Intel-gfx] " Chris Wilson
2021-01-27 13:27 ` Thomas Zimmermann
2021-01-27 13:27 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 12:41 ` [PATCH v5 2/5] drm/i915/gt: " Thomas Zimmermann
2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 12:41 ` [PATCH v5 3/5] drm/i915/gvt: " Thomas Zimmermann
2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 12:41 ` [PATCH v5 4/5] drm/i915: Don't assign " Thomas Zimmermann
2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 12:54 ` Chris Wilson [this message]
2021-01-27 12:54 ` Chris Wilson
2021-01-27 12:41 ` [PATCH v5 5/5] drm: Move struct drm_device.pdev to legacy section Thomas Zimmermann
2021-01-27 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-01-27 17:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Move struct drm_device.pdev to legacy (rev5) Patchwork
2021-01-27 21:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161175209876.2943.13596593111578124710@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.