[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/3] proc: Show GPU runtimes

From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Chris Wilson" <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/3] proc: Show GPU runtimes
Date: Thu, 04 Feb 2021 17:01:50 -0000	[thread overview]
Message-ID: <161245811099.4501.5682168970990029155@emeril.freedesktop.org> (raw)
In-Reply-To: <20210204121121.2660-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: series starting with [RFC,1/3] proc: Show GPU runtimes
URL   : https://patchwork.freedesktop.org/series/86693/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
852e50fbb083 proc: Show GPU runtimes
-:46: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#46: FILE: fs/proc/base.c:3269:
+	ONE("gpu", S_IRUGO, proc_pid_gpu),

-:54: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#54: FILE: fs/proc/base.c:3602:
+	ONE("gpu", S_IRUGO, proc_pid_gpu),

-:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 3 warnings, 0 checks, 149 lines checked
b8f1256bd5ba drm/i915: Look up clients by pid
49cb9e5c8e5a drm/i915/gt: Export device and per-process runtimes via procfs
-:56: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

-:80: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#80: FILE: drivers/gpu/drm/i915/gt/intel_gt_proc.c:20:
+	BUILD_BUG_ON(MAX_ENGINE_CLASS >= ARRAY_SIZE(rt->channel));

total: 0 errors, 2 warnings, 0 checks, 125 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx