All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs
Date: Fri, 12 Feb 2021 14:57:56 +0000	[thread overview]
Message-ID: <CACvgo51auuU-AR5nPPo-7Q8Ho84cqOYXuTjgjGDzmPjXRtjZ0w@mail.gmail.com> (raw)
In-Reply-To: <20210204121121.2660-3-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, 4 Feb 2021 at 12:11, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Register with /proc/gpu to provide the client runtimes for generic
> top-like overview, e.g. gnome-system-monitor can use this information to
> show the per-process multi-GPU usage.
>
Exposing this information to userspace sounds great IMHO and like the
proposed "channels" for the device engines.
If it were me, I would have the channel names a) exposed to userspace
and b) be a "fixed set".

Whereby with a "fixed set" I mean, we should have these akin to the
KMS UAPI properties, where we have core helpers exposing prop X/Y and
there should be no driver specific ones.
This would allow for consistent and deterministic userspace handling,
even if some hardware/drivers do not have all engines - say no copy
engine.


> --- /dev/null
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_proc.c
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: MIT
Thanks for making these available under MIT.

> +/*
> + * Copyright © 2020 Intel Corporation

Might want to make this 2021 in the next revision.

HTH
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs
Date: Fri, 12 Feb 2021 14:57:56 +0000	[thread overview]
Message-ID: <CACvgo51auuU-AR5nPPo-7Q8Ho84cqOYXuTjgjGDzmPjXRtjZ0w@mail.gmail.com> (raw)
In-Reply-To: <20210204121121.2660-3-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, 4 Feb 2021 at 12:11, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Register with /proc/gpu to provide the client runtimes for generic
> top-like overview, e.g. gnome-system-monitor can use this information to
> show the per-process multi-GPU usage.
>
Exposing this information to userspace sounds great IMHO and like the
proposed "channels" for the device engines.
If it were me, I would have the channel names a) exposed to userspace
and b) be a "fixed set".

Whereby with a "fixed set" I mean, we should have these akin to the
KMS UAPI properties, where we have core helpers exposing prop X/Y and
there should be no driver specific ones.
This would allow for consistent and deterministic userspace handling,
even if some hardware/drivers do not have all engines - say no copy
engine.


> --- /dev/null
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_proc.c
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: MIT
Thanks for making these available under MIT.

> +/*
> + * Copyright © 2020 Intel Corporation

Might want to make this 2021 in the next revision.

HTH
Emil
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-02-12 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 12:11 [RFC 1/3] proc: Show GPU runtimes Chris Wilson
2021-02-04 12:11 ` [Intel-gfx] " Chris Wilson
2021-02-04 12:11 ` [RFC 2/3] drm/i915: Look up clients by pid Chris Wilson
2021-02-04 12:11   ` [Intel-gfx] " Chris Wilson
2021-02-04 12:11 ` [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs Chris Wilson
2021-02-04 12:11   ` [Intel-gfx] " Chris Wilson
2021-02-12 14:57   ` Emil Velikov [this message]
2021-02-12 14:57     ` Emil Velikov
2021-02-12 15:16     ` Chris Wilson
2021-02-12 15:16       ` [Intel-gfx] " Chris Wilson
2021-02-12 15:45       ` Emil Velikov
2021-02-12 15:45         ` [Intel-gfx] " Emil Velikov
2021-02-12 16:07         ` Chris Wilson
2021-02-12 16:07           ` [Intel-gfx] " Chris Wilson
2021-02-04 17:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/3] proc: Show GPU runtimes Patchwork
2021-02-04 17:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-04 22:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACvgo51auuU-AR5nPPo-7Q8Ho84cqOYXuTjgjGDzmPjXRtjZ0w@mail.gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.