All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jaroslav Kysela <perex@perex.cz>,
	Oder Chiou <oder_chiou@realtek.com>,
	Rikard Falkeborn <rikard.falkeborn@gmail.com>,
	Takashi Iwai <tiwai@suse.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/4] ASoC: rt*: Constify static structs
Date: Mon, 01 Mar 2021 23:34:40 +0000	[thread overview]
Message-ID: <161464168097.31144.1513145502519193305.b4-ty@kernel.org> (raw)
In-Reply-To: <20210224211918.39109-1-rikard.falkeborn@gmail.com>

On Wed, 24 Feb 2021 22:19:14 +0100, Rikard Falkeborn wrote:
> Constify a number of static structs that are never modified in RealTek
> codecs. The most important patches are the first two, which constifies
> snd_soc_dai_ops and sdw_slave_ops, both which contain function pointers.
> The other two patches are for good measure, since I was already touching
> the code there.
> 
> When doing this, I discovered sound/soc/codecs/rt1016.c is not in a
> Makefile, so there is not really any way to build it (I added locally to
> the Makefile to compile-test my changes). Is this expected or an oversight?
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: rt*: Constify static struct sdw_slave_ops
      commit: 3ebb1b951880d3152547ac4018bfcce0fd7810bd
[2/4] ASoC: rt*: Constify static struct snd_soc_dai_ops
      commit: 84732dd4ff3ad28cc65eedfa3061fe3808e8469b
[3/4] ASoC: rt*: Constify static struct acpi_device_id
      commit: c85ca92c716bd04981ebcd2c67cd03f96748859e
[4/4] ASoc: rt5631: Constify static struct coeff_clk_div
      commit: 39f9eb61307061eed197eae651ef56cb3544f9b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jaroslav Kysela <perex@perex.cz>,
	Oder Chiou <oder_chiou@realtek.com>,
	Rikard Falkeborn <rikard.falkeborn@gmail.com>,
	Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ASoC: rt*: Constify static structs
Date: Mon, 01 Mar 2021 23:34:40 +0000	[thread overview]
Message-ID: <161464168097.31144.1513145502519193305.b4-ty@kernel.org> (raw)
In-Reply-To: <20210224211918.39109-1-rikard.falkeborn@gmail.com>

On Wed, 24 Feb 2021 22:19:14 +0100, Rikard Falkeborn wrote:
> Constify a number of static structs that are never modified in RealTek
> codecs. The most important patches are the first two, which constifies
> snd_soc_dai_ops and sdw_slave_ops, both which contain function pointers.
> The other two patches are for good measure, since I was already touching
> the code there.
> 
> When doing this, I discovered sound/soc/codecs/rt1016.c is not in a
> Makefile, so there is not really any way to build it (I added locally to
> the Makefile to compile-test my changes). Is this expected or an oversight?
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: rt*: Constify static struct sdw_slave_ops
      commit: 3ebb1b951880d3152547ac4018bfcce0fd7810bd
[2/4] ASoC: rt*: Constify static struct snd_soc_dai_ops
      commit: 84732dd4ff3ad28cc65eedfa3061fe3808e8469b
[3/4] ASoC: rt*: Constify static struct acpi_device_id
      commit: c85ca92c716bd04981ebcd2c67cd03f96748859e
[4/4] ASoc: rt5631: Constify static struct coeff_clk_div
      commit: 39f9eb61307061eed197eae651ef56cb3544f9b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

  parent reply	other threads:[~2021-03-02  7:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 21:19 [PATCH 0/4] ASoC: rt*: Constify static structs Rikard Falkeborn
2021-02-24 21:19 ` Rikard Falkeborn
2021-02-24 21:19 ` [PATCH 1/4] ASoC: rt*: Constify static struct sdw_slave_ops Rikard Falkeborn
2021-02-24 21:19   ` Rikard Falkeborn
2021-02-24 21:19 ` [PATCH 2/4] ASoC: rt*: Constify static struct snd_soc_dai_ops Rikard Falkeborn
2021-02-24 21:19   ` Rikard Falkeborn
2021-02-24 21:19 ` [PATCH 3/4] ASoC: rt*: Constify static struct acpi_device_id Rikard Falkeborn
2021-02-24 21:19   ` Rikard Falkeborn
2021-02-24 21:19 ` [PATCH 4/4] ASoc: rt5631: Constify static struct coeff_clk_div Rikard Falkeborn
2021-02-24 21:19   ` Rikard Falkeborn
2021-03-01 23:34 ` Mark Brown [this message]
2021-03-01 23:34   ` [PATCH 0/4] ASoC: rt*: Constify static structs Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161464168097.31144.1513145502519193305.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=rikard.falkeborn@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.