All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: amelie.delaunay@foss.st.com, Alain Volmat <alain.volmat@foss.st.com>
Cc: Mark Brown <broonie@kernel.org>,
	mcoquelin.stm32@gmail.com, fabrice.gasnier@foss.st.com,
	alexandre.torgue@foss.st.com,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	antonio.borneo@foss.st.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: stm32: Fix use-after-free on unbind
Date: Fri, 19 Mar 2021 16:37:03 +0000	[thread overview]
Message-ID: <161617166734.9851.4969692619964809885.b4-ty@kernel.org> (raw)
In-Reply-To: <1616052290-10887-1-git-send-email-alain.volmat@foss.st.com>

On Thu, 18 Mar 2021 08:24:50 +0100, Alain Volmat wrote:
> stm32_spi_remove() accesses the driver's private data after calling
> spi_unregister_master() even though that function releases the last
> reference on the spi_master and thereby frees the private data.
> 
> Fix by switching over to the new devm_spi_alloc_master() helper which
> keeps the private data accessible until the driver has unbound.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: stm32: Fix use-after-free on unbind
      commit: 79c6246ae8793448c05da86a4c82298eed8549b0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: amelie.delaunay@foss.st.com, Alain Volmat <alain.volmat@foss.st.com>
Cc: Mark Brown <broonie@kernel.org>,
	mcoquelin.stm32@gmail.com, fabrice.gasnier@foss.st.com,
	alexandre.torgue@foss.st.com,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	antonio.borneo@foss.st.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: stm32: Fix use-after-free on unbind
Date: Fri, 19 Mar 2021 16:37:03 +0000	[thread overview]
Message-ID: <161617166734.9851.4969692619964809885.b4-ty@kernel.org> (raw)
In-Reply-To: <1616052290-10887-1-git-send-email-alain.volmat@foss.st.com>

On Thu, 18 Mar 2021 08:24:50 +0100, Alain Volmat wrote:
> stm32_spi_remove() accesses the driver's private data after calling
> spi_unregister_master() even though that function releases the last
> reference on the spi_master and thereby frees the private data.
> 
> Fix by switching over to the new devm_spi_alloc_master() helper which
> keeps the private data accessible until the driver has unbound.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: stm32: Fix use-after-free on unbind
      commit: 79c6246ae8793448c05da86a4c82298eed8549b0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-19 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  7:24 [PATCH] spi: stm32: Fix use-after-free on unbind Alain Volmat
2021-03-18  7:24 ` Alain Volmat
2021-03-19 16:37 ` Mark Brown [this message]
2021-03-19 16:37   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161617166734.9851.4969692619964809885.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=amelie.delaunay@foss.st.com \
    --cc=antonio.borneo@foss.st.com \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.