From: Stephen Boyd <swboyd@chromium.org>
To: Abhinav Kumar <abhinavk@codeaurora.org>, dri-devel@lists.freedesktop.org
Cc: Abhinav Kumar <abhinavk@codeaurora.org>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
robdclark@gmail.com, seanpaul@chromium.org,
nganji@codeaurora.org, aravindh@codeaurora.org,
tanmay@codeaurora.org, khsieh@codeaurora.org,
dan.carpenter@oracle.com
Subject: Re: [PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling
Date: Thu, 25 Mar 2021 18:18:10 -0700 [thread overview]
Message-ID: <161672149027.3012082.2392067140198433025@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1614971839-2686-3-git-send-email-abhinavk@codeaurora.org>
Quoting Abhinav Kumar (2021-03-05 11:17:19)
> Currently the error checking logic in the dp_debug module could
> pass zero to PTR_ERR and it causes the below kbot warnings:
>
> drivers/gpu/drm/msm/dp/dp_debug.c:378 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:387 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:396 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:405 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
>
> Debugfs functions are not supposed to be checked in the normal
> case so delete this code. Also it silences the above Smatch
> warnings that we're checking for NULL when these functions only
> return error pointers.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Nice cleanup!
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Abhinav Kumar <abhinavk@codeaurora.org>, dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org,
Abhinav Kumar <abhinavk@codeaurora.org>,
khsieh@codeaurora.org, seanpaul@chromium.org,
tanmay@codeaurora.org, aravindh@codeaurora.org,
freedreno@lists.freedesktop.org, dan.carpenter@oracle.com
Subject: Re: [PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling
Date: Thu, 25 Mar 2021 18:18:10 -0700 [thread overview]
Message-ID: <161672149027.3012082.2392067140198433025@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1614971839-2686-3-git-send-email-abhinavk@codeaurora.org>
Quoting Abhinav Kumar (2021-03-05 11:17:19)
> Currently the error checking logic in the dp_debug module could
> pass zero to PTR_ERR and it causes the below kbot warnings:
>
> drivers/gpu/drm/msm/dp/dp_debug.c:378 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:387 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:396 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:405 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
>
> Debugfs functions are not supposed to be checked in the normal
> case so delete this code. Also it silences the above Smatch
> warnings that we're checking for NULL when these functions only
> return error pointers.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Nice cleanup!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-26 1:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 19:17 [PATCH 1/3] drm/msm/dp: Fix indentation kbot warnings in DP driver Abhinav Kumar
2021-03-05 19:17 ` Abhinav Kumar
2021-03-05 19:17 ` [PATCH 2/3] drm/msm/dp: Fix incorrect NULL check " Abhinav Kumar
2021-03-05 19:17 ` Abhinav Kumar
2021-03-26 1:17 ` Stephen Boyd
2021-03-26 1:17 ` Stephen Boyd
2021-03-05 19:17 ` [PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling Abhinav Kumar
2021-03-05 19:17 ` Abhinav Kumar
2021-03-26 1:18 ` Stephen Boyd [this message]
2021-03-26 1:18 ` Stephen Boyd
2021-03-26 1:17 ` [PATCH 1/3] drm/msm/dp: Fix indentation kbot warnings in DP driver Stephen Boyd
2021-03-26 1:17 ` Stephen Boyd
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161672149027.3012082.2392067140198433025@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=abhinavk@codeaurora.org \
--cc=aravindh@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=nganji@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=tanmay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.