From: Stephen Boyd <sboyd@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michael Turquette <mturquette@baylibre.com>,
Michal Simek <michal.simek@xilinx.com>,
quanyang.wang@windriver.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jolly Shah <jolly.shah@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>,
Quanyang Wang <quanyang.wang@windriver.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback
Date: Wed, 07 Apr 2021 18:09:28 -0700 [thread overview]
Message-ID: <161784416839.3790633.9475983970404006080@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210406154015.602779-1-quanyang.wang@windriver.com>
Quoting quanyang.wang@windriver.com (2021-04-06 08:40:15)
> From: Quanyang Wang <quanyang.wang@windriver.com>
>
> The round_rate callback should only perform rate calculation and not
> involve calling zynqmp_pll_set_mode to change the pll mode. So let's
> move zynqmp_pll_set_mode out of round_rate and to set_rate callback.
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
Applied to clk-next
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michael Turquette <mturquette@baylibre.com>,
Michal Simek <michal.simek@xilinx.com>,
quanyang.wang@windriver.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jolly Shah <jolly.shah@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>,
Quanyang Wang <quanyang.wang@windriver.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback
Date: Wed, 07 Apr 2021 18:09:28 -0700 [thread overview]
Message-ID: <161784416839.3790633.9475983970404006080@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210406154015.602779-1-quanyang.wang@windriver.com>
Quoting quanyang.wang@windriver.com (2021-04-06 08:40:15)
> From: Quanyang Wang <quanyang.wang@windriver.com>
>
> The round_rate callback should only perform rate calculation and not
> involve calling zynqmp_pll_set_mode to change the pll mode. So let's
> move zynqmp_pll_set_mode out of round_rate and to set_rate callback.
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-08 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 15:40 [V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback quanyang.wang
2021-04-06 15:40 ` quanyang.wang
2021-04-08 1:09 ` Stephen Boyd [this message]
2021-04-08 1:09 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161784416839.3790633.9475983970404006080@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jolly.shah@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=quanyang.wang@windriver.com \
--cc=rajan.vaja@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.