From: Yongqiang Niu <yongqiang.niu@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"David Airlie" <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Jassi Brar <jassisinghbrar@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
"Dennis YC Hsieh" <dennis-yc.hsieh@mediatek.com>,
DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
Date: Wed, 14 Apr 2021 09:49:17 +0800 [thread overview]
Message-ID: <1618364957.9156.3.camel@mhfsdcap03> (raw)
In-Reply-To: <CAAOTY__zcdjA-tu4kNtWjy=37_HZV1U2fS6=k4OBAbjfNwC9Ow@mail.gmail.com>
On Wed, 2021-04-14 at 07:38 +0800, Chun-Kuang Hu wrote:
> Hi, Yongqiang:
>
> Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2021年4月12日 週一 下午7:19寫道：
> >
> > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f.
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > index 7771eca..cf48cd8 100644
> > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > @@ -47,7 +47,7 @@ Example:
> > interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&infracfg CLK_INFRA_GCE>;
> > clock-names = "gce";
> > - #mbox-cells = <2>;
> > + #mbox-cells = <3>;
>
> I think we should not change the binding just to fix software bug.
> I think there are many temporary solution to fix drm bug. If drm bug
> is caused by cursor plane, you could temporarily let drm not support
> cursor plane to fix it (in [1], do not return DRM_PLANE_TYPE_CURSOR).
> But I would like you to find out the correct solution rather than a
> temporary solution because this bug is not so urgent. (For me, bug of
> build fail, boot fail, black screen is urgent).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_drm_crtc.c?h=v5.12-rc7#n699
>
> Regards,
> Chun-Kuang.
this not drm bug, but caused by cmdq patch
https://patchwork.kernel.org/project/linux-mediatek/patch/20200214043325.16618-3-bibby.hsieh@mediatek.com/
before this patch, drm cursor and ui works well
after this patch, ui will flash when move cursor
this is critical issue,
>
> > };
> >
> > Example for a client device:
> > --
> > 1.8.1.1.dirty
> >
WARNING: multiple messages have this Message-ID (diff)
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"David Airlie" <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Jassi Brar <jassisinghbrar@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
"Dennis YC Hsieh" <dennis-yc.hsieh@mediatek.com>,
DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
Date: Wed, 14 Apr 2021 09:49:17 +0800 [thread overview]
Message-ID: <1618364957.9156.3.camel@mhfsdcap03> (raw)
In-Reply-To: <CAAOTY__zcdjA-tu4kNtWjy=37_HZV1U2fS6=k4OBAbjfNwC9Ow@mail.gmail.com>
On Wed, 2021-04-14 at 07:38 +0800, Chun-Kuang Hu wrote:
> Hi, Yongqiang:
>
> Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2021年4月12日 週一 下午7:19寫道：
> >
> > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f.
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > index 7771eca..cf48cd8 100644
> > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > @@ -47,7 +47,7 @@ Example:
> > interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&infracfg CLK_INFRA_GCE>;
> > clock-names = "gce";
> > - #mbox-cells = <2>;
> > + #mbox-cells = <3>;
>
> I think we should not change the binding just to fix software bug.
> I think there are many temporary solution to fix drm bug. If drm bug
> is caused by cursor plane, you could temporarily let drm not support
> cursor plane to fix it (in [1], do not return DRM_PLANE_TYPE_CURSOR).
> But I would like you to find out the correct solution rather than a
> temporary solution because this bug is not so urgent. (For me, bug of
> build fail, boot fail, black screen is urgent).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_drm_crtc.c?h=v5.12-rc7#n699
>
> Regards,
> Chun-Kuang.
this not drm bug, but caused by cmdq patch
https://patchwork.kernel.org/project/linux-mediatek/patch/20200214043325.16618-3-bibby.hsieh@mediatek.com/
before this patch, drm cursor and ui works well
after this patch, ui will flash when move cursor
this is critical issue,
>
> > };
> >
> > Example for a client device:
> > --
> > 1.8.1.1.dirty
> >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"David Airlie" <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Jassi Brar <jassisinghbrar@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
"Dennis YC Hsieh" <dennis-yc.hsieh@mediatek.com>,
DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
Date: Wed, 14 Apr 2021 09:49:17 +0800 [thread overview]
Message-ID: <1618364957.9156.3.camel@mhfsdcap03> (raw)
In-Reply-To: <CAAOTY__zcdjA-tu4kNtWjy=37_HZV1U2fS6=k4OBAbjfNwC9Ow@mail.gmail.com>
On Wed, 2021-04-14 at 07:38 +0800, Chun-Kuang Hu wrote:
> Hi, Yongqiang:
>
> Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2021年4月12日 週一 下午7:19寫道：
> >
> > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f.
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > index 7771eca..cf48cd8 100644
> > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > @@ -47,7 +47,7 @@ Example:
> > interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&infracfg CLK_INFRA_GCE>;
> > clock-names = "gce";
> > - #mbox-cells = <2>;
> > + #mbox-cells = <3>;
>
> I think we should not change the binding just to fix software bug.
> I think there are many temporary solution to fix drm bug. If drm bug
> is caused by cursor plane, you could temporarily let drm not support
> cursor plane to fix it (in [1], do not return DRM_PLANE_TYPE_CURSOR).
> But I would like you to find out the correct solution rather than a
> temporary solution because this bug is not so urgent. (For me, bug of
> build fail, boot fail, black screen is urgent).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_drm_crtc.c?h=v5.12-rc7#n699
>
> Regards,
> Chun-Kuang.
this not drm bug, but caused by cmdq patch
https://patchwork.kernel.org/project/linux-mediatek/patch/20200214043325.16618-3-bibby.hsieh@mediatek.com/
before this patch, drm cursor and ui works well
after this patch, ui will flash when move cursor
this is critical issue,
>
> > };
> >
> > Example for a client device:
> > --
> > 1.8.1.1.dirty
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Yongqiang Niu <yongqiang.niu@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
David Airlie <airlied@linux.ie>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"
Date: Wed, 14 Apr 2021 09:49:17 +0800 [thread overview]
Message-ID: <1618364957.9156.3.camel@mhfsdcap03> (raw)
In-Reply-To: <CAAOTY__zcdjA-tu4kNtWjy=37_HZV1U2fS6=k4OBAbjfNwC9Ow@mail.gmail.com>
On Wed, 2021-04-14 at 07:38 +0800, Chun-Kuang Hu wrote:
> Hi, Yongqiang:
>
> Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2021年4月12日 週一 下午7:19寫道：
> >
> > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f.
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > index 7771eca..cf48cd8 100644
> > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > @@ -47,7 +47,7 @@ Example:
> > interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&infracfg CLK_INFRA_GCE>;
> > clock-names = "gce";
> > - #mbox-cells = <2>;
> > + #mbox-cells = <3>;
>
> I think we should not change the binding just to fix software bug.
> I think there are many temporary solution to fix drm bug. If drm bug
> is caused by cursor plane, you could temporarily let drm not support
> cursor plane to fix it (in [1], do not return DRM_PLANE_TYPE_CURSOR).
> But I would like you to find out the correct solution rather than a
> temporary solution because this bug is not so urgent. (For me, bug of
> build fail, boot fail, black screen is urgent).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_drm_crtc.c?h=v5.12-rc7#n699
>
> Regards,
> Chun-Kuang.
this not drm bug, but caused by cmdq patch
https://patchwork.kernel.org/project/linux-mediatek/patch/20200214043325.16618-3-bibby.hsieh@mediatek.com/
before this patch, drm cursor and ui works well
after this patch, ui will flash when move cursor
this is critical issue,
>
> > };
> >
> > Example for a client device:
> > --
> > 1.8.1.1.dirty
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-14 1:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 11:18 [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec" Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` [PATCH v2, 1/5] Revert "drm/mediatek: Make sure previous message done or be aborted before send" Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` [PATCH v2, 2/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec" Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value" Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-13 23:38 ` Chun-Kuang Hu
2021-04-13 23:38 ` Chun-Kuang Hu
2021-04-13 23:38 ` Chun-Kuang Hu
2021-04-13 23:38 ` Chun-Kuang Hu
2021-04-14 1:49 ` Yongqiang Niu [this message]
2021-04-14 1:49 ` Yongqiang Niu
2021-04-14 1:49 ` Yongqiang Niu
2021-04-14 1:49 ` Yongqiang Niu
2021-04-12 11:18 ` [PATCH v2, 4/5] Revert "arm64: dts: mediatek: mt8183: fix gce " Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` [PATCH v2, 5/5] arm64: dts: mediatek: mt8183: add gce information for mmsys Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 11:18 ` Yongqiang Niu
2021-04-12 15:29 ` [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec" Jassi Brar
2021-04-12 15:29 ` Jassi Brar
2021-04-12 15:29 ` Jassi Brar
2021-04-12 15:29 ` Jassi Brar
2021-04-14 8:51 ` Matthias Brugger
2021-04-14 8:51 ` Matthias Brugger
2021-04-14 8:51 ` Matthias Brugger
2021-04-14 8:51 ` Matthias Brugger
2021-04-14 14:53 ` Jassi Brar
2021-04-14 14:53 ` Jassi Brar
2021-04-14 14:53 ` Jassi Brar
2021-04-14 14:53 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618364957.9156.3.camel@mhfsdcap03 \
--to=yongqiang.niu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fparent@baylibre.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.