All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Qinglang Miao <miaoqinglang@huawei.com>,
	Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
	Boris Brezillon <boris.brezillon@collabora.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org
Subject: Re: [RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"
Date: Sat, 24 Apr 2021 22:25:41 +0200	[thread overview]
Message-ID: <161929592285.189809.16598700064500451755.b4-ty@bootlin.com> (raw)
In-Reply-To: <20210408172803.24599-1-jae.hyun.yoo@linux.intel.com>

On Thu, 8 Apr 2021 10:28:03 -0700, Jae Hyun Yoo wrote:
> Adding the destroy_workqueue call in i3c_master_register introduced below
> kernel warning because it makes duplicate destroy_workqueue calls when
> i3c_master_register fails after allocating the workqueue. The workqueue will
> be destroyed by i3c_masterdev_release which is called by put_device at the
> end of the i3c_master_register function eventually in failure cases so the
> workqueue doesn't need to be destroyed in i3c_master_register.
> 
> [...]

Applied, thanks!

[1/1] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"
      commit: 0d95f41ebde40d552bb4fea64b1d618607915fd6

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Qinglang Miao <miaoqinglang@huawei.com>,
	Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
	Boris Brezillon <boris.brezillon@collabora.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org
Subject: Re: [RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"
Date: Sat, 24 Apr 2021 22:25:41 +0200	[thread overview]
Message-ID: <161929592285.189809.16598700064500451755.b4-ty@bootlin.com> (raw)
In-Reply-To: <20210408172803.24599-1-jae.hyun.yoo@linux.intel.com>

On Thu, 8 Apr 2021 10:28:03 -0700, Jae Hyun Yoo wrote:
> Adding the destroy_workqueue call in i3c_master_register introduced below
> kernel warning because it makes duplicate destroy_workqueue calls when
> i3c_master_register fails after allocating the workqueue. The workqueue will
> be destroyed by i3c_masterdev_release which is called by put_device at the
> end of the i3c_master_register function eventually in failure cases so the
> workqueue doesn't need to be destroyed in i3c_master_register.
> 
> [...]

Applied, thanks!

[1/1] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"
      commit: 0d95f41ebde40d552bb4fea64b1d618607915fd6

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2021-04-24 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 17:28 [RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register" Jae Hyun Yoo
2021-04-08 17:28 ` Jae Hyun Yoo
2021-04-24 20:25 ` Alexandre Belloni [this message]
2021-04-24 20:25   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161929592285.189809.16598700064500451755.b4-ty@bootlin.com \
    --to=alexandre.belloni@bootlin.com \
    --cc=boris.brezillon@collabora.com \
    --cc=jae.hyun.yoo@linux.intel.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoqinglang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.