Re: [PATCH v3 07/10] dt-bindings: soc: rockchip: Convert grf.txt to YAML

From: Rob Herring <robh@kernel.org>
To: cl@rock-chips.com
Cc: david.wu@rock-chips.com, jagan@amarulasolutions.com,
	linux-kernel@vger.kernel.org, jay.xu@rock-chips.com,
	jamie@jamieiles.com, ulf.hansson@linaro.org,
	jensenhuang@friendlyarm.com, linux-serial@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-watchdog@vger.kernel.org,
	gregkh@linuxfoundation.org, huangtao@rock-chips.com,
	mail@david-bauer.net, linux@roeck-us.net,
	devicetree@vger.kernel.org, heiko@sntech.de, cnsztl@gmail.com,
	wim@linux-watchdog.org, michael@amarulasolutions.com,
	zhangqing@rock-chips.com, maz@kernel.org, robh+dt@kernel.org,
	uwe@kleine-koenig.org, shawn.lin@rock-chips.com,
	linux-mmc@vger.kernel.org, jbx6244@gmail.com,
	linux-arm-kernel@lists.infradead.org, wens@csie.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 07/10] dt-bindings: soc: rockchip: Convert grf.txt to YAML
Date: Wed, 28 Apr 2021 17:15:09 -0500	[thread overview]
Message-ID: <1619648109.786418.4061032.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210428134938.22383-1-cl@rock-chips.com>

On Wed, 28 Apr 2021 21:49:38 +0800, cl@rock-chips.com wrote:
> From: Liang Chen <cl@rock-chips.com>
> 
> Current dts files with 'grf' nodes are manually verified. In order to
> automate this process grf.txt has to be converted to YAML.
> 
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> ---
>  .../devicetree/bindings/soc/rockchip/grf.txt  | 61 -------------------
>  .../devicetree/bindings/soc/rockchip/grf.yaml | 61 +++++++++++++++++++
>  2 files changed, 61 insertions(+), 61 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/rockchip/grf.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/grf.example.dt.yaml: example-0: syscon@ff320000:reg:0: [0, 4281466880, 0, 4096] is too long
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/grf.example.dt.yaml: example-0: syscon@ff770000:reg:0: [0, 4285988864, 0, 65536] is too long
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/grf.example.dt.yaml: syscon@ff320000: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3399-pmugrf', 'syscon'] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/grf.example.dt.yaml: syscon@ff770000: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3399-grf', 'syscon'] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/grf.yaml

See https://patchwork.ozlabs.org/patch/1471171

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.