From: Stephen Boyd <sboyd@kernel.org> To: Michal Simek <michal.simek@xilinx.com>, Punit Agrawal <punit1.agrawal@toshiba.co.jp> Cc: Arnd Bergmann <arnd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Arnd Bergmann <arnd@arndb.de>, Rajan Vaja <rajan.vaja@xilinx.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jolly Shah <jolly.shah@xilinx.com>, Quanyang Wang <quanyang.wang@windriver.com>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: zynqmp: fix compile testing without ZYNQMP_FIRMWARE Date: Thu, 29 Apr 2021 19:17:14 -0700 [thread overview] Message-ID: <161974903429.177949.6659170601321970979@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <87v98dqzfe.fsf@kokedama.swc.toshiba.co.jp> Quoting Punit Agrawal (2021-04-22 23:37:25) > Michal Simek <michal.simek@xilinx.com> writes: > > > > > >>> > >>> rate = parent_rate * fbdiv; > >>> if (zynqmp_pll_get_mode(hw) == PLL_MODE_FRAC) { > >> > >> The changes make sense in that the functions error out sensibly when the > >> zynqmp firmware driver is not enabled. > >> > >> Acked-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp> > > > > I think code should be checked that these error values are handled how > > they should be handled. > > I only looked at it from the point of view of getting rid of the > warnings - based on the commit log, Arnd's patch is only taking care of > the compiler warnings when the driver is built with > CONFIG_COMPILE_TEST=y and likely CONFIG_ZYNQMP_FIRMWARE=n. The subject line basically says this. > > In practice, the code should not be hit at runtime due to the dependency > on the firmware driver. Even then, a better fix would indeed be taking > the returned values at call sites into account. Still needs to be fixed. If a better patch is sent I would apply it, but if that isn't going to happen I'll apply this one.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Michal Simek <michal.simek@xilinx.com>, Punit Agrawal <punit1.agrawal@toshiba.co.jp> Cc: Arnd Bergmann <arnd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Arnd Bergmann <arnd@arndb.de>, Rajan Vaja <rajan.vaja@xilinx.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jolly Shah <jolly.shah@xilinx.com>, Quanyang Wang <quanyang.wang@windriver.com>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: zynqmp: fix compile testing without ZYNQMP_FIRMWARE Date: Thu, 29 Apr 2021 19:17:14 -0700 [thread overview] Message-ID: <161974903429.177949.6659170601321970979@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <87v98dqzfe.fsf@kokedama.swc.toshiba.co.jp> Quoting Punit Agrawal (2021-04-22 23:37:25) > Michal Simek <michal.simek@xilinx.com> writes: > > > > > >>> > >>> rate = parent_rate * fbdiv; > >>> if (zynqmp_pll_get_mode(hw) == PLL_MODE_FRAC) { > >> > >> The changes make sense in that the functions error out sensibly when the > >> zynqmp firmware driver is not enabled. > >> > >> Acked-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp> > > > > I think code should be checked that these error values are handled how > > they should be handled. > > I only looked at it from the point of view of getting rid of the > warnings - based on the commit log, Arnd's patch is only taking care of > the compiler warnings when the driver is built with > CONFIG_COMPILE_TEST=y and likely CONFIG_ZYNQMP_FIRMWARE=n. The subject line basically says this. > > In practice, the code should not be hit at runtime due to the dependency > on the firmware driver. Even then, a better fix would indeed be taking > the returned values at call sites into account. Still needs to be fixed. If a better patch is sent I would apply it, but if that isn't going to happen I'll apply this one. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-30 2:17 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-21 13:48 [PATCH] clk: zynqmp: fix compile testing without ZYNQMP_FIRMWARE Arnd Bergmann 2021-04-21 13:48 ` Arnd Bergmann 2021-04-22 5:48 ` Punit Agrawal 2021-04-22 5:48 ` Punit Agrawal 2021-04-22 10:54 ` Michal Simek 2021-04-22 10:54 ` Michal Simek 2021-04-23 6:37 ` Punit Agrawal 2021-04-23 6:37 ` Punit Agrawal 2021-04-30 2:17 ` Stephen Boyd [this message] 2021-04-30 2:17 ` Stephen Boyd 2021-06-21 13:15 ` Michal Simek 2021-06-21 13:15 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=161974903429.177949.6659170601321970979@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=arnd@arndb.de \ --cc=arnd@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jolly.shah@xilinx.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=mturquette@baylibre.com \ --cc=punit1.agrawal@toshiba.co.jp \ --cc=quanyang.wang@windriver.com \ --cc=rajan.vaja@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.