From: no-reply@patchew.org
To: wangjunqiang@iscas.ac.cn
Cc: liweiwei@iscas.ac.cn, qemu-riscv@nongnu.org,
wangjunqiang@iscas.ac.cn, bin.meng@windriver.com,
qemu-devel@nongnu.org, Alistair.Francis@wdc.com,
alapha23@gmail.com, palmer@dabbelt.com
Subject: Re: [RFC PATCH 0/5] RISC-V:support Nuclei FPGA Evaluation Kit
Date: Fri, 7 May 2021 06:33:53 -0700 (PDT) [thread overview]
Message-ID: <162039443180.3634.9846649937156739328@d887ba82c771> (raw)
In-Reply-To: <20210507081654.11056-1-wangjunqiang@iscas.ac.cn>
Patchew URL: https://patchew.org/QEMU/20210507081654.11056-1-wangjunqiang@iscas.ac.cn/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210507081654.11056-1-wangjunqiang@iscas.ac.cn
Subject: [RFC PATCH 0/5] RISC-V:support Nuclei FPGA Evaluation Kit
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210507081654.11056-1-wangjunqiang@iscas.ac.cn -> patchew/20210507081654.11056-1-wangjunqiang@iscas.ac.cn
Switched to a new branch 'test'
cdf3a5a Nuclei FPGA Evaluation Kit MCU Machine
fc461db hw/char: Add Nuclei Uart
749f98b hw/intc: Add Nuclei Systimer
4f82151 hw/intc: Add Nuclei ECLIC device
f0b7d59 target/riscv: Add Nuclei CSR and Update interrupt handling
=== OUTPUT BEGIN ===
1/5 Checking commit f0b7d59bd81c (target/riscv: Add Nuclei CSR and Update interrupt handling)
WARNING: line over 80 characters
#519: FILE: target/riscv/csr.c:720:
+static int rmw_mscratchcsw(CPURISCVState *env, int csrno, target_ulong *ret_value,
ERROR: space required after that close brace '}'
#527: FILE: target/riscv/csr.c:728:
+ }else {
WARNING: line over 80 characters
#783: FILE: target/riscv/csr.c:1742:
+ [CSR_MINTSTATUS] = {"mintstatus", eclic, read_mintstatus, write_mintstatus },
ERROR: line over 90 characters
#784: FILE: target/riscv/csr.c:1743:
+ [CSR_MSCRATCHCSW] = {"mscratchcsw", any, read_mscratchcsw, write_mscratchcsw, rmw_mscratchcsw},
ERROR: line over 90 characters
#785: FILE: target/riscv/csr.c:1744:
+ [CSR_MSCRATCHCSWL] = { "mscratchcswl", any, read_mscratchcswl, write_mscratchcswl, rmw_mscratchcswl},
WARNING: line over 80 characters
#789: FILE: target/riscv/csr.c:1748:
+ [CSR_MMISC_CTL] = { "mmisc_ctl", any, read_mmisc_ctl, write_mmisc_ctl },
WARNING: line over 80 characters
#790: FILE: target/riscv/csr.c:1749:
+ [CSR_MSAVESTATUS] = { "msavestatus", any, read_msavestatus, write_msavestatus },
WARNING: line over 80 characters
#791: FILE: target/riscv/csr.c:1750:
+ [CSR_MSAVEEPC1] = { "msaveepc1", any, read_msaveepc1, write_msaveepc1 },
WARNING: line over 80 characters
#792: FILE: target/riscv/csr.c:1751:
+ [CSR_MSAVECAUSE1] = { "msavecause1", any, read_msavecause1, write_msavecause1 },
WARNING: line over 80 characters
#793: FILE: target/riscv/csr.c:1752:
+ [CSR_MSAVEEPC2] = { "msaveepc2", any, read_msaveepc2, write_msaveepc2 },
WARNING: line over 80 characters
#794: FILE: target/riscv/csr.c:1753:
+ [CSR_MSAVECAUSE2] = { "msavecause2", any, read_msavecause2, write_msavecause2 },
WARNING: line over 80 characters
#795: FILE: target/riscv/csr.c:1754:
+ [CSR_MSAVEDCAUSE1] = { "msavedcause1", any, read_msavedcause1, write_msavedcause1 },
WARNING: line over 80 characters
#796: FILE: target/riscv/csr.c:1755:
+ [CSR_MSAVEDCAUSE2] = { "msavedcause2", any, read_msavedcause2, write_msavedcause2 },
WARNING: line over 80 characters
#805: FILE: target/riscv/csr.c:1764:
+ [CSR_MUCOUNTEREN] = { "mucounteren", any, read_mucounteren, write_mucounteren },
ERROR: Missing Signed-off-by: line(s)
total: 4 errors, 11 warnings, 784 lines checked
Patch 1/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit 4f82151c82e4 (hw/intc: Add Nuclei ECLIC device)
ERROR: line over 90 characters
#152: FILE: hw/intc/nuclei_eclic.c:103:
+ (active->irq & 0xFFF) | (shv << 12) | (active->level << 13));
ERROR: line over 90 characters
#178: FILE: hw/intc/nuclei_eclic.c:129:
+ (eclic->clicintctl[irq] >> (8 - level_width)) &
WARNING: line over 80 characters
#220: FILE: hw/intc/nuclei_eclic.c:171:
+static void nuclei_eclic_update_intip(NucLeiECLICState *eclic, int irq, int new_intip)
ERROR: Missing Signed-off-by: line(s)
total: 3 errors, 1 warnings, 565 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 749f98b9b790 (hw/intc: Add Nuclei Systimer)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47:
new file mode 100644
total: 0 errors, 1 warnings, 337 lines checked
Patch 3/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit fc461db1fe2c (hw/char: Add Nuclei Uart)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 294 lines checked
Patch 4/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit cdf3a5a645a4 (Nuclei FPGA Evaluation Kit MCU Machine)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74:
new file mode 100644
total: 0 errors, 1 warnings, 438 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210507081654.11056-1-wangjunqiang@iscas.ac.cn/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org
To: wangjunqiang@iscas.ac.cn
Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
liweiwei@iscas.ac.cn, wangjunqiang@iscas.ac.cn,
bin.meng@windriver.com, Alistair.Francis@wdc.com,
alapha23@gmail.com, palmer@dabbelt.com
Subject: Re: [RFC PATCH 0/5] RISC-V:support Nuclei FPGA Evaluation Kit
Date: Fri, 7 May 2021 06:33:53 -0700 (PDT) [thread overview]
Message-ID: <162039443180.3634.9846649937156739328@d887ba82c771> (raw)
In-Reply-To: <20210507081654.11056-1-wangjunqiang@iscas.ac.cn>
Patchew URL: https://patchew.org/QEMU/20210507081654.11056-1-wangjunqiang@iscas.ac.cn/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210507081654.11056-1-wangjunqiang@iscas.ac.cn
Subject: [RFC PATCH 0/5] RISC-V:support Nuclei FPGA Evaluation Kit
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210507081654.11056-1-wangjunqiang@iscas.ac.cn -> patchew/20210507081654.11056-1-wangjunqiang@iscas.ac.cn
Switched to a new branch 'test'
cdf3a5a Nuclei FPGA Evaluation Kit MCU Machine
fc461db hw/char: Add Nuclei Uart
749f98b hw/intc: Add Nuclei Systimer
4f82151 hw/intc: Add Nuclei ECLIC device
f0b7d59 target/riscv: Add Nuclei CSR and Update interrupt handling
=== OUTPUT BEGIN ===
1/5 Checking commit f0b7d59bd81c (target/riscv: Add Nuclei CSR and Update interrupt handling)
WARNING: line over 80 characters
#519: FILE: target/riscv/csr.c:720:
+static int rmw_mscratchcsw(CPURISCVState *env, int csrno, target_ulong *ret_value,
ERROR: space required after that close brace '}'
#527: FILE: target/riscv/csr.c:728:
+ }else {
WARNING: line over 80 characters
#783: FILE: target/riscv/csr.c:1742:
+ [CSR_MINTSTATUS] = {"mintstatus", eclic, read_mintstatus, write_mintstatus },
ERROR: line over 90 characters
#784: FILE: target/riscv/csr.c:1743:
+ [CSR_MSCRATCHCSW] = {"mscratchcsw", any, read_mscratchcsw, write_mscratchcsw, rmw_mscratchcsw},
ERROR: line over 90 characters
#785: FILE: target/riscv/csr.c:1744:
+ [CSR_MSCRATCHCSWL] = { "mscratchcswl", any, read_mscratchcswl, write_mscratchcswl, rmw_mscratchcswl},
WARNING: line over 80 characters
#789: FILE: target/riscv/csr.c:1748:
+ [CSR_MMISC_CTL] = { "mmisc_ctl", any, read_mmisc_ctl, write_mmisc_ctl },
WARNING: line over 80 characters
#790: FILE: target/riscv/csr.c:1749:
+ [CSR_MSAVESTATUS] = { "msavestatus", any, read_msavestatus, write_msavestatus },
WARNING: line over 80 characters
#791: FILE: target/riscv/csr.c:1750:
+ [CSR_MSAVEEPC1] = { "msaveepc1", any, read_msaveepc1, write_msaveepc1 },
WARNING: line over 80 characters
#792: FILE: target/riscv/csr.c:1751:
+ [CSR_MSAVECAUSE1] = { "msavecause1", any, read_msavecause1, write_msavecause1 },
WARNING: line over 80 characters
#793: FILE: target/riscv/csr.c:1752:
+ [CSR_MSAVEEPC2] = { "msaveepc2", any, read_msaveepc2, write_msaveepc2 },
WARNING: line over 80 characters
#794: FILE: target/riscv/csr.c:1753:
+ [CSR_MSAVECAUSE2] = { "msavecause2", any, read_msavecause2, write_msavecause2 },
WARNING: line over 80 characters
#795: FILE: target/riscv/csr.c:1754:
+ [CSR_MSAVEDCAUSE1] = { "msavedcause1", any, read_msavedcause1, write_msavedcause1 },
WARNING: line over 80 characters
#796: FILE: target/riscv/csr.c:1755:
+ [CSR_MSAVEDCAUSE2] = { "msavedcause2", any, read_msavedcause2, write_msavedcause2 },
WARNING: line over 80 characters
#805: FILE: target/riscv/csr.c:1764:
+ [CSR_MUCOUNTEREN] = { "mucounteren", any, read_mucounteren, write_mucounteren },
ERROR: Missing Signed-off-by: line(s)
total: 4 errors, 11 warnings, 784 lines checked
Patch 1/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit 4f82151c82e4 (hw/intc: Add Nuclei ECLIC device)
ERROR: line over 90 characters
#152: FILE: hw/intc/nuclei_eclic.c:103:
+ (active->irq & 0xFFF) | (shv << 12) | (active->level << 13));
ERROR: line over 90 characters
#178: FILE: hw/intc/nuclei_eclic.c:129:
+ (eclic->clicintctl[irq] >> (8 - level_width)) &
WARNING: line over 80 characters
#220: FILE: hw/intc/nuclei_eclic.c:171:
+static void nuclei_eclic_update_intip(NucLeiECLICState *eclic, int irq, int new_intip)
ERROR: Missing Signed-off-by: line(s)
total: 3 errors, 1 warnings, 565 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 749f98b9b790 (hw/intc: Add Nuclei Systimer)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47:
new file mode 100644
total: 0 errors, 1 warnings, 337 lines checked
Patch 3/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit fc461db1fe2c (hw/char: Add Nuclei Uart)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 294 lines checked
Patch 4/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit cdf3a5a645a4 (Nuclei FPGA Evaluation Kit MCU Machine)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74:
new file mode 100644
total: 0 errors, 1 warnings, 438 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210507081654.11056-1-wangjunqiang@iscas.ac.cn/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2021-05-07 13:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 8:16 [RFC PATCH 0/5] RISC-V:support Nuclei FPGA Evaluation Kit wangjunqiang
2021-05-07 8:16 ` wangjunqiang
2021-05-07 8:16 ` [RFC PATCH 1/5] target/riscv: Add Nuclei CSR and Update interrupt handling wangjunqiang
2021-05-07 8:16 ` wangjunqiang
2021-05-10 2:17 ` Alistair Francis
2021-05-10 2:17 ` Alistair Francis
2021-05-11 3:14 ` Wang Junqiang
2021-05-11 3:14 ` Wang Junqiang
2021-05-11 3:43 ` Alistair Francis
2021-05-11 3:43 ` Alistair Francis
2021-05-11 4:00 ` Wang Junqiang
2021-05-11 4:00 ` Wang Junqiang
2021-05-11 4:03 ` Alistair Francis
2021-05-11 4:03 ` Alistair Francis
2021-05-07 8:16 ` [RFC PATCH 2/5] hw/intc: Add Nuclei ECLIC device wangjunqiang
2021-05-07 8:16 ` wangjunqiang
2021-05-10 2:20 ` Alistair Francis
2021-05-10 2:20 ` Alistair Francis
2021-05-10 2:27 ` Bin Meng
2021-05-10 2:27 ` Bin Meng
2021-05-10 5:26 ` Bin Meng
2021-05-10 5:26 ` Bin Meng
2021-05-11 3:18 ` Wang Junqiang
2021-05-07 8:16 ` [RFC PATCH 3/5] hw/intc: Add Nuclei Systimer wangjunqiang
2021-05-07 8:16 ` wangjunqiang
2021-05-07 8:16 ` [RFC PATCH 4/5] hw/char: Add Nuclei Uart wangjunqiang
2021-05-07 8:16 ` wangjunqiang
2021-05-07 8:16 ` [RFC PATCH 5/5] Nuclei FPGA Evaluation Kit MCU Machine wangjunqiang
2021-05-07 8:16 ` wangjunqiang
2021-05-07 13:33 ` no-reply [this message]
2021-05-07 13:33 ` [RFC PATCH 0/5] RISC-V:support Nuclei FPGA Evaluation Kit no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162039443180.3634.9846649937156739328@d887ba82c771 \
--to=no-reply@patchew.org \
--cc=Alistair.Francis@wdc.com \
--cc=alapha23@gmail.com \
--cc=bin.meng@windriver.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.