From: Arnd Bergmann <arnd@arndb.de>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, linux-amlogic@lists.infradead.org,
khilman@baylibre.com, carlo@caione.org, mturquette@baylibre.com,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org,
manabian@gmail.com, davem@davemloft.net
Subject: Re: [PATCH v4 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC
Date: Tue, 06 Sep 2016 11:37:58 +0200 [thread overview]
Message-ID: <16206001.1636ZmhtjK@wuerfel> (raw)
In-Reply-To: <CAFBinCAC3c=o1=8DGfiPhw6w6V42jvYLUfHXHpHLe03pw8P=LQ@mail.gmail.com>
On Monday, September 5, 2016 9:07:03 PM CEST Martin Blumenstingl wrote:
> On Mon, Sep 5, 2016 at 12:53 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday, September 5, 2016 9:37:29 AM CEST kbuild test robot wrote:
> >> All error/warnings (new ones prefixed by >>):
> >>
> >> >> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:63:18: error: field 'm250_mux' has incomplete type
> >> struct clk_mux m250_mux;
> >> ^
> >> >> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:67:21: error: field 'm250_div' has incomplete type
> >> struct clk_divider m250_div;
> >> ^
> >>
> >
> > I think this needs a compile-time dependency on COMMON_CLK
> indeed, since we are also a clock provider we have to depend on
> CONFIG_COMMON_CLK.
>
> That brings up a question though:
> so far the new driver uses the same Kconfig symbol as the "old" driver
> (CONFIG_DWMAC_MESON).
> The "old" driver does not need CONFIG_COMMON_CLK while the new one does.
> I see a few options here:
> 1. simply adding the dependency (as most configurations will have
> CONFIG_COMMON_CLK enabled anyways)
I think that's fine. At least on both ARM multiplatform and ARM64 it is
always defined by definition, and when build testing, it should be possible
to enable it on other architectures as well.
> 2. add some depends on COMMON_CLK || MACH_MESON6 || MACH_MESON8 foo
That doesn't work unless you also put the calls into the clk interface
inside of ugly #ifdef
> 3. use a new Kconfig symbol for new new driver (CONFIG_DWMAC_MESON8B?)
That would be ok as well, probably not necessary.
> And finally regarding your other mail: I have already changed
> WARN_ON(PTR_ERR_OR_ZERO(...)) to WARN_ON(IS_ERR(...)) in v4
Ok, thanks.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC
Date: Tue, 06 Sep 2016 11:37:58 +0200 [thread overview]
Message-ID: <16206001.1636ZmhtjK@wuerfel> (raw)
In-Reply-To: <CAFBinCAC3c=o1=8DGfiPhw6w6V42jvYLUfHXHpHLe03pw8P=LQ@mail.gmail.com>
On Monday, September 5, 2016 9:07:03 PM CEST Martin Blumenstingl wrote:
> On Mon, Sep 5, 2016 at 12:53 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday, September 5, 2016 9:37:29 AM CEST kbuild test robot wrote:
> >> All error/warnings (new ones prefixed by >>):
> >>
> >> >> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:63:18: error: field 'm250_mux' has incomplete type
> >> struct clk_mux m250_mux;
> >> ^
> >> >> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:67:21: error: field 'm250_div' has incomplete type
> >> struct clk_divider m250_div;
> >> ^
> >>
> >
> > I think this needs a compile-time dependency on COMMON_CLK
> indeed, since we are also a clock provider we have to depend on
> CONFIG_COMMON_CLK.
>
> That brings up a question though:
> so far the new driver uses the same Kconfig symbol as the "old" driver
> (CONFIG_DWMAC_MESON).
> The "old" driver does not need CONFIG_COMMON_CLK while the new one does.
> I see a few options here:
> 1. simply adding the dependency (as most configurations will have
> CONFIG_COMMON_CLK enabled anyways)
I think that's fine. At least on both ARM multiplatform and ARM64 it is
always defined by definition, and when build testing, it should be possible
to enable it on other architectures as well.
> 2. add some depends on COMMON_CLK || MACH_MESON6 || MACH_MESON8 foo
That doesn't work unless you also put the calls into the clk interface
inside of ugly #ifdef
> 3. use a new Kconfig symbol for new new driver (CONFIG_DWMAC_MESON8B?)
That would be ok as well, probably not necessary.
> And finally regarding your other mail: I have already changed
> WARN_ON(PTR_ERR_OR_ZERO(...)) to WARN_ON(IS_ERR(...)) in v4
Ok, thanks.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC
Date: Tue, 06 Sep 2016 11:37:58 +0200 [thread overview]
Message-ID: <16206001.1636ZmhtjK@wuerfel> (raw)
In-Reply-To: <CAFBinCAC3c=o1=8DGfiPhw6w6V42jvYLUfHXHpHLe03pw8P=LQ@mail.gmail.com>
On Monday, September 5, 2016 9:07:03 PM CEST Martin Blumenstingl wrote:
> On Mon, Sep 5, 2016 at 12:53 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday, September 5, 2016 9:37:29 AM CEST kbuild test robot wrote:
> >> All error/warnings (new ones prefixed by >>):
> >>
> >> >> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:63:18: error: field 'm250_mux' has incomplete type
> >> struct clk_mux m250_mux;
> >> ^
> >> >> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:67:21: error: field 'm250_div' has incomplete type
> >> struct clk_divider m250_div;
> >> ^
> >>
> >
> > I think this needs a compile-time dependency on COMMON_CLK
> indeed, since we are also a clock provider we have to depend on
> CONFIG_COMMON_CLK.
>
> That brings up a question though:
> so far the new driver uses the same Kconfig symbol as the "old" driver
> (CONFIG_DWMAC_MESON).
> The "old" driver does not need CONFIG_COMMON_CLK while the new one does.
> I see a few options here:
> 1. simply adding the dependency (as most configurations will have
> CONFIG_COMMON_CLK enabled anyways)
I think that's fine. At least on both ARM multiplatform and ARM64 it is
always defined by definition, and when build testing, it should be possible
to enable it on other architectures as well.
> 2. add some depends on COMMON_CLK || MACH_MESON6 || MACH_MESON8 foo
That doesn't work unless you also put the calls into the clk interface
inside of ugly #ifdef
> 3. use a new Kconfig symbol for new new driver (CONFIG_DWMAC_MESON8B?)
That would be ok as well, probably not necessary.
> And finally regarding your other mail: I have already changed
> WARN_ON(PTR_ERR_OR_ZERO(...)) to WARN_ON(IS_ERR(...)) in v4
Ok, thanks.
Arnd
next prev parent reply other threads:[~2016-09-06 9:39 UTC|newest]
Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 16:50 [RFC] meson: add support for configuring the ethernet clocks Martin Blumenstingl
2016-06-25 16:50 ` Martin Blumenstingl
2016-06-25 16:50 ` [PATCH RFC 1/3] net: dt-bindings: add the amlogic,meson8b-dwmac binding Martin Blumenstingl
2016-06-25 16:50 ` [PATCH RFC 1/3] net: dt-bindings: add the amlogic, meson8b-dwmac binding Martin Blumenstingl
2016-06-25 16:50 ` [PATCH RFC 2/3] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC Martin Blumenstingl
2016-06-25 16:50 ` Martin Blumenstingl
2016-06-25 16:50 ` [PATCH RFC 3/3] ARM64: dts: meson-gxbb: use the new meson8b DWMAC glue Martin Blumenstingl
2016-06-25 16:50 ` Martin Blumenstingl
2016-06-27 9:24 ` Carlo Caione
2016-06-27 9:24 ` Carlo Caione
2016-06-27 10:44 ` Martin Blumenstingl
2016-06-27 10:44 ` Martin Blumenstingl
2016-06-27 11:33 ` Martin Blumenstingl
2016-06-27 11:33 ` Martin Blumenstingl
2016-07-13 21:01 ` Michael Turquette
2016-07-13 21:01 ` Michael Turquette
2016-07-13 21:22 ` Kevin Hilman
2016-07-13 21:22 ` Kevin Hilman
2016-08-15 16:40 ` [PATCH 0/3] ARM64: meson: Meson8b and GXBB DWMAC glue driver Martin Blumenstingl
2016-08-15 16:40 ` Martin Blumenstingl
2016-08-15 16:40 ` Martin Blumenstingl
2016-08-15 16:40 ` [PATCH 1/3] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings Martin Blumenstingl
2016-08-15 16:40 ` Martin Blumenstingl
2016-08-15 16:40 ` Martin Blumenstingl
2016-08-16 14:25 ` Rob Herring
2016-08-16 14:25 ` Rob Herring
2016-08-16 14:25 ` Rob Herring
2016-08-15 16:40 ` [PATCH 2/3] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC Martin Blumenstingl
2016-08-15 16:40 ` Martin Blumenstingl
2016-08-15 16:40 ` Martin Blumenstingl
2016-08-19 21:40 ` Kevin Hilman
2016-08-19 21:40 ` Kevin Hilman
2016-08-19 21:40 ` Kevin Hilman
2016-08-15 16:41 ` [PATCH 3/3] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver Martin Blumenstingl
2016-08-15 16:41 ` Martin Blumenstingl
2016-08-15 16:41 ` Martin Blumenstingl
2016-08-20 9:35 ` [PATCH v2 0/4] meson: Meson8b and " Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` [PATCH v2 1/4] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
[not found] ` <20160820093538.9707-2-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-22 11:55 ` Arnd Bergmann
2016-08-22 11:55 ` Arnd Bergmann
2016-08-22 11:55 ` Arnd Bergmann
2016-08-22 12:04 ` Martin Blumenstingl
2016-08-22 12:04 ` Martin Blumenstingl
2016-08-22 12:04 ` Martin Blumenstingl
2016-08-22 15:25 ` Arnd Bergmann
2016-08-22 15:25 ` Arnd Bergmann
2016-08-22 15:25 ` Arnd Bergmann
2016-08-28 16:15 ` Martin Blumenstingl
2016-08-28 16:15 ` Martin Blumenstingl
2016-08-28 16:15 ` Martin Blumenstingl
2016-08-29 13:31 ` Arnd Bergmann
2016-08-29 13:31 ` Arnd Bergmann
2016-08-29 13:31 ` Arnd Bergmann
2016-08-20 9:35 ` [PATCH v2 2/4] clk: gxbb: expose MPLL2 clock for use by DT Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` [PATCH v2 3/4] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 21:29 ` Joachim Eastwood
2016-08-20 21:29 ` Joachim Eastwood
2016-08-20 21:29 ` Joachim Eastwood
[not found] ` <CAGhQ9VyWs=sYg7PVrt5r-fM-2t--qAnHyvNXAZXwjkYn5P196g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-21 12:00 ` Martin Blumenstingl
2016-08-21 12:00 ` Martin Blumenstingl
2016-08-21 12:00 ` Martin Blumenstingl
[not found] ` <20160820093538.9707-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-20 9:35 ` [PATCH v2 4/4] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-20 9:35 ` Martin Blumenstingl
2016-08-28 16:16 ` [PATCH v3 0/5] meson: Meson8b and " Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` [PATCH v3 2/5] clk: gxbb: expose MPLL2 clock for use by DT Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
[not found] ` <20160828161637.9941-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-28 16:16 ` [PATCH v3 1/5] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` [PATCH v3 3/5] stmmac: introduce get_stmmac_bsp_priv() helper Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` [PATCH v3 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-30 19:19 ` Stephen Boyd
2016-08-30 19:19 ` Stephen Boyd
2016-08-30 19:19 ` Stephen Boyd
[not found] ` <20160830191906.GD12510-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-04 18:20 ` Martin Blumenstingl
2016-09-04 18:20 ` Martin Blumenstingl
2016-09-04 18:20 ` Martin Blumenstingl
[not found] ` <CAFBinCCVUhUVyceGc2capcCPOK8MTsn+RcC9gnrtMVvZUENXtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-05 9:27 ` Arnd Bergmann
2016-09-05 9:27 ` Arnd Bergmann
2016-09-05 9:27 ` Arnd Bergmann
2016-08-28 16:16 ` [PATCH v3 5/5] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-28 16:16 ` Martin Blumenstingl
2016-08-29 3:40 ` [PATCH v3 0/5] meson: Meson8b and " David Miller
2016-08-29 3:40 ` David Miller
2016-08-29 3:40 ` David Miller
2016-08-30 18:49 ` Martin Blumenstingl
2016-08-30 18:49 ` Martin Blumenstingl
2016-08-30 18:49 ` Martin Blumenstingl
[not found] ` <CAFBinCCmg-+8mjd0Xc5c7bEWL9_S_4kizs_UMiiW9ATBH_G8iw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-31 4:57 ` David Miller
2016-08-31 4:57 ` David Miller
2016-08-31 4:57 ` David Miller
2016-09-02 4:23 ` Kevin Hilman
2016-09-02 4:23 ` Kevin Hilman
2016-09-02 4:23 ` Kevin Hilman
2016-09-02 5:37 ` David Miller
2016-09-02 5:37 ` David Miller
2016-09-02 5:37 ` David Miller
2016-09-02 8:50 ` Arnd Bergmann
2016-09-02 8:50 ` Arnd Bergmann
2016-09-02 8:50 ` Arnd Bergmann
2016-09-04 18:23 ` [PATCH v4 " Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` [PATCH v4 1/5] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` [PATCH v4 2/5] clk: gxbb: expose MPLL2 clock for use by DT Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` [PATCH v4 3/5] stmmac: introduce get_stmmac_bsp_priv() helper Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
[not found] ` <20160904182320.671-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-04 18:23 ` [PATCH v4 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
[not found] ` <20160904182320.671-5-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-05 1:37 ` kbuild test robot
2016-09-05 1:37 ` kbuild test robot
2016-09-05 1:37 ` kbuild test robot
2016-09-05 1:37 ` kbuild test robot
2016-09-05 10:53 ` Arnd Bergmann
2016-09-05 10:53 ` Arnd Bergmann
2016-09-05 10:53 ` Arnd Bergmann
2016-09-05 19:07 ` Martin Blumenstingl
2016-09-05 19:07 ` Martin Blumenstingl
2016-09-05 19:07 ` Martin Blumenstingl
2016-09-06 9:37 ` Arnd Bergmann [this message]
2016-09-06 9:37 ` Arnd Bergmann
2016-09-06 9:37 ` Arnd Bergmann
2016-09-05 1:43 ` kbuild test robot
2016-09-05 1:43 ` kbuild test robot
2016-09-05 1:43 ` kbuild test robot
2016-09-05 1:43 ` kbuild test robot
2016-09-06 21:38 ` [PATCH v5 0/6] meson: Meson8b and GXBB DWMAC glue driver Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` [PATCH v5 1/6] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
[not found] ` <20160906213848.17785-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-09-06 21:38 ` [PATCH v5 2/6] clk: gxbb: expose MPLL2 clock for use by DT Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-07 21:27 ` Stephen Boyd
2016-09-07 21:27 ` Stephen Boyd
2016-09-07 21:27 ` Stephen Boyd
2016-09-06 21:38 ` [PATCH v5 3/6] stmmac: introduce get_stmmac_bsp_priv() helper Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` [PATCH v5 4/6] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` [PATCH v5 5/6] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` [PATCH v5 6/6] net: stmmac: update the module description of the dwmac-meson driver Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-06 21:38 ` Martin Blumenstingl
2016-09-04 18:23 ` [PATCH v4 5/5] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
2016-09-04 18:23 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16206001.1636ZmhtjK@wuerfel \
--to=arnd@arndb.de \
--cc=alexandre.torgue@st.com \
--cc=carlo@caione.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=manabian@gmail.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.