From: Rob Herring <robh@kernel.org>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: linux-fpga@vger.kernel.org, wendy.liang@xilinx.com,
lakshmi.sai.krishna.potthuri@xilinx.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
iwamatsu@nigauri.org, chinnikishore369@gmail.com, arnd@arndb.de,
amit.sunil.dhamne@xilinx.com, ravi.patel@xilinx.com,
zou_wei@huawei.com, robh+dt@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rajan.vaja@xilinx.com, git@xilinx.com, mdf@kernel.org,
trix@redhat.com, tejas.patel@xilinx.com, michal.simek@xilinx.com
Subject: Re: [PATCH v5 3/4] dt-bindings: firmware: Add bindings for xilinx firmware
Date: Wed, 12 May 2021 13:35:16 -0500 [thread overview]
Message-ID: <1620844516.515515.204085.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210512125042.30973-4-nava.manne@xilinx.com>
On Wed, 12 May 2021 18:20:41 +0530, Nava kishore Manne wrote:
> Add documentation to describe Xilinx firmware driver bindings.
> Firmware driver provides an interface to firmware APIs.
> Interface APIs can be used by any driver to communicate
> to Platform Management Unit.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> ---
> Changes for v4:
> -Added new yaml file for xilinx firmware
> as suggested by Rob.
> Changes for v5:
> -Fixed some minor issues and updated the fpga node name to versal_fpga.
>
> .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/gpio/rockchip,rk3328-grf-gpio.yaml'
xargs: dt-doc-validate: exited with status 255; aborting
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/xlnx,versal-clk.example.dt.yaml: zynqmp-firmware: 'clock-controller' does not match any of the regexes: 'pinctrl-[0-9]+', 'versal_fpga'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.example.dt.yaml: zynqmp-firmware: 'zynqmp-aes' does not match any of the regexes: 'pinctrl-[0-9]+', 'versal_fpga'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
See https://patchwork.ozlabs.org/patch/1477568
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: linux-fpga@vger.kernel.org, wendy.liang@xilinx.com,
lakshmi.sai.krishna.potthuri@xilinx.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
iwamatsu@nigauri.org, chinnikishore369@gmail.com, arnd@arndb.de,
amit.sunil.dhamne@xilinx.com, ravi.patel@xilinx.com,
zou_wei@huawei.com, robh+dt@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rajan.vaja@xilinx.com, git@xilinx.com, mdf@kernel.org,
trix@redhat.com, tejas.patel@xilinx.com, michal.simek@xilinx.com
Subject: Re: [PATCH v5 3/4] dt-bindings: firmware: Add bindings for xilinx firmware
Date: Wed, 12 May 2021 13:35:16 -0500 [thread overview]
Message-ID: <1620844516.515515.204085.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210512125042.30973-4-nava.manne@xilinx.com>
On Wed, 12 May 2021 18:20:41 +0530, Nava kishore Manne wrote:
> Add documentation to describe Xilinx firmware driver bindings.
> Firmware driver provides an interface to firmware APIs.
> Interface APIs can be used by any driver to communicate
> to Platform Management Unit.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> ---
> Changes for v4:
> -Added new yaml file for xilinx firmware
> as suggested by Rob.
> Changes for v5:
> -Fixed some minor issues and updated the fpga node name to versal_fpga.
>
> .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/gpio/rockchip,rk3328-grf-gpio.yaml'
xargs: dt-doc-validate: exited with status 255; aborting
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/xlnx,versal-clk.example.dt.yaml: zynqmp-firmware: 'clock-controller' does not match any of the regexes: 'pinctrl-[0-9]+', 'versal_fpga'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.example.dt.yaml: zynqmp-firmware: 'zynqmp-aes' does not match any of the regexes: 'pinctrl-[0-9]+', 'versal_fpga'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
See https://patchwork.ozlabs.org/patch/1477568
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-12 20:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 12:50 [PATCH v5 0/4]Add Bitstream configuration support for Versal Nava kishore Manne
2021-05-12 12:50 ` Nava kishore Manne
2021-05-12 12:50 ` [PATCH v5 1/4] drivers: firmware: Add PDI load API support Nava kishore Manne
2021-05-12 12:50 ` Nava kishore Manne
2021-05-12 12:50 ` [PATCH v5 2/4] dt-bindings: fpga: Add binding doc for versal fpga manager Nava kishore Manne
2021-05-12 12:50 ` Nava kishore Manne
2021-05-12 12:50 ` [PATCH v5 3/4] dt-bindings: firmware: Add bindings for xilinx firmware Nava kishore Manne
2021-05-12 12:50 ` Nava kishore Manne
2021-05-12 18:35 ` Rob Herring [this message]
2021-05-12 18:35 ` Rob Herring
2021-05-12 12:50 ` [PATCH v5 4/4] fpga: versal-fpga: Add versal fpga manager driver Nava kishore Manne
2021-05-12 12:50 ` Nava kishore Manne
2021-05-12 15:10 ` [PATCH v5 0/4]Add Bitstream configuration support for Versal Moritz Fischer
2021-05-12 15:10 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620844516.515515.204085.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=amit.sunil.dhamne@xilinx.com \
--cc=arnd@arndb.de \
--cc=chinnikishore369@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=iwamatsu@nigauri.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=ravi.patel@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=tejas.patel@xilinx.com \
--cc=trix@redhat.com \
--cc=wendy.liang@xilinx.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.