From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
daniele.ceraolospurio@intel.com, john.c.harrison@intel.com
Subject: Re: [PATCH] drm/i915/guc: Fix recursive lock in GuC submission
Date: Tue, 26 Oct 2021 12:15:54 +0300 [thread overview]
Message-ID: <163523975442.6968.9660235537397634312@jlahtine-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <20211025171321.GA9338@jons-linux-dev-box>
Quoting Matthew Brost (2021-10-25 20:13:22)
> On Mon, Oct 25, 2021 at 03:23:00PM +0300, Joonas Lahtinen wrote:
> > Quoting Thomas Hellström (2021-10-21 08:39:48)
> > > On Wed, 2021-10-20 at 12:21 -0700, Matthew Brost wrote:
> >
> > <SNIP>
> >
> > > > Fixes: 1a52faed31311 ("drm/i915/guc: Take engine PM when a context is
> > > > pinned with GuC submission")
> > > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > > Cc: stable@vger.kernel.org
> >
> > This Cc: stable annotation is unnecessary.
> >
> > Please always use "dim fixes 1a52faed31311" for helping to decide which
> > Cc's are needed. In this case stable is not needed. If it was, there
> > would be an indication of kernel version. In this case this is fine to
> > be picked up by in drm-intel-next-fixes PR.
> >
> > Let's pay attention to the right Fixes: annotation while submitting and
> > reviewing patches.
> >
>
> Will do. Working on getting push rights. Is there any documentation with
> all the rules when pushing as it seems like there are a lot of rules.
Yes, we have the documentation here:
https://drm.pages.freedesktop.org/maintainer-tools/committer-guidelines.html
And more specifically this topic:
https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-intel.html#labeling-fixes-before-pushing
I could even recommend to at least do a cursory read through the wider
documentation about how the different trees interact:
https://drm.pages.freedesktop.org/maintainer-tools/index.html
Makes it easier to understand how the tags are used.
Regards, Joonas
>
> Matt
>
> > Regards, Joonas
WARNING: multiple messages have this Message-ID (diff)
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
daniele.ceraolospurio@intel.com, john.c.harrison@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix recursive lock in GuC submission
Date: Tue, 26 Oct 2021 12:15:54 +0300 [thread overview]
Message-ID: <163523975442.6968.9660235537397634312@jlahtine-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <20211025171321.GA9338@jons-linux-dev-box>
Quoting Matthew Brost (2021-10-25 20:13:22)
> On Mon, Oct 25, 2021 at 03:23:00PM +0300, Joonas Lahtinen wrote:
> > Quoting Thomas Hellström (2021-10-21 08:39:48)
> > > On Wed, 2021-10-20 at 12:21 -0700, Matthew Brost wrote:
> >
> > <SNIP>
> >
> > > > Fixes: 1a52faed31311 ("drm/i915/guc: Take engine PM when a context is
> > > > pinned with GuC submission")
> > > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > > Cc: stable@vger.kernel.org
> >
> > This Cc: stable annotation is unnecessary.
> >
> > Please always use "dim fixes 1a52faed31311" for helping to decide which
> > Cc's are needed. In this case stable is not needed. If it was, there
> > would be an indication of kernel version. In this case this is fine to
> > be picked up by in drm-intel-next-fixes PR.
> >
> > Let's pay attention to the right Fixes: annotation while submitting and
> > reviewing patches.
> >
>
> Will do. Working on getting push rights. Is there any documentation with
> all the rules when pushing as it seems like there are a lot of rules.
Yes, we have the documentation here:
https://drm.pages.freedesktop.org/maintainer-tools/committer-guidelines.html
And more specifically this topic:
https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-intel.html#labeling-fixes-before-pushing
I could even recommend to at least do a cursory read through the wider
documentation about how the different trees interact:
https://drm.pages.freedesktop.org/maintainer-tools/index.html
Makes it easier to understand how the tags are used.
Regards, Joonas
>
> Matt
>
> > Regards, Joonas
next prev parent reply other threads:[~2021-10-26 9:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 19:21 [PATCH] drm/i915/guc: Fix recursive lock in GuC submission Matthew Brost
2021-10-20 19:21 ` [Intel-gfx] " Matthew Brost
2021-10-20 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix recursive lock in GuC submission (rev2) Patchwork
2021-10-20 23:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-21 5:39 ` [PATCH] drm/i915/guc: Fix recursive lock in GuC submission Thomas Hellström
2021-10-21 5:39 ` [Intel-gfx] " Thomas Hellström
2021-10-25 12:23 ` Joonas Lahtinen
2021-10-25 12:23 ` [Intel-gfx] " Joonas Lahtinen
2021-10-25 17:13 ` Matthew Brost
2021-10-25 17:13 ` [Intel-gfx] " Matthew Brost
2021-10-26 9:15 ` Joonas Lahtinen [this message]
2021-10-26 9:15 ` Joonas Lahtinen
-- strict thread matches above, loose matches on Subject: below --
2021-10-20 19:07 Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163523975442.6968.9660235537397634312@jlahtine-mobl.ger.corp.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=matthew.brost@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.