From: Alan Maguire <alan.maguire@oracle.com> To: ardb@kernel.org, catalin.marinas@arm.com, will@kernel.org, daniel@iogearbox.net, ast@kernel.org Cc: zlim.lnx@gmail.com, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, samitolvanen@google.com, joey.gouly@arm.com, maz@kernel.org, daizhiyuan@phytium.com.cn, jthierry@redhat.com, tiantao6@hisilicon.com, pcc@google.com, akpm@linux-foundation.org, rppt@kernel.org, Jisheng.Zhang@synaptics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com> Subject: [PATCH v2 bpf-next 0/2] arm64/bpf: remove 128MB limit for BPF JIT programs Date: Fri, 5 Nov 2021 16:50:44 +0000 [thread overview] Message-ID: <1636131046-5982-1-git-send-email-alan.maguire@oracle.com> (raw) There is a 128MB limit on BPF JIT program allocations; this is to ensure BPF programs are in branching range of each other. Patch 1 in this series removes this restriction. To verify exception handling still works, a test case to validate exception handling in BPF programs is added in patch 2. There was previous discussion around this topic [1], in particular would be good to get feedback from Daniel if this approach makes sense. [1] https://lore.kernel.org/all/20181121131733.14910-1-ard.biesheuvel@linaro.org/ Changes since v1: - respin picked up changes in arm64 exception handling changes which removed need for special BPF exception handling in patch 1 - made selftest use task creation/task_struct field instead to minimize BPF selftests parallel runs, moved from CHECK()s to ASSERT_*()s (Andrii, patch 2) Alan Maguire (1): selftests/bpf: add exception handling selftests for tp_bpf program Russell King (1): arm64/bpf: remove 128MB limit for BPF JIT programs arch/arm64/include/asm/extable.h | 9 ----- arch/arm64/include/asm/memory.h | 5 +-- arch/arm64/kernel/traps.c | 2 +- arch/arm64/mm/ptdump.c | 2 - arch/arm64/net/bpf_jit_comp.c | 7 +--- tools/testing/selftests/bpf/prog_tests/exhandler.c | 43 ++++++++++++++++++++++ tools/testing/selftests/bpf/progs/exhandler_kern.c | 43 ++++++++++++++++++++++ 7 files changed, 90 insertions(+), 21 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/exhandler.c create mode 100644 tools/testing/selftests/bpf/progs/exhandler_kern.c -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Alan Maguire <alan.maguire@oracle.com> To: ardb@kernel.org, catalin.marinas@arm.com, will@kernel.org, daniel@iogearbox.net, ast@kernel.org Cc: zlim.lnx@gmail.com, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, samitolvanen@google.com, joey.gouly@arm.com, maz@kernel.org, daizhiyuan@phytium.com.cn, jthierry@redhat.com, tiantao6@hisilicon.com, pcc@google.com, akpm@linux-foundation.org, rppt@kernel.org, Jisheng.Zhang@synaptics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com> Subject: [PATCH v2 bpf-next 0/2] arm64/bpf: remove 128MB limit for BPF JIT programs Date: Fri, 5 Nov 2021 16:50:44 +0000 [thread overview] Message-ID: <1636131046-5982-1-git-send-email-alan.maguire@oracle.com> (raw) There is a 128MB limit on BPF JIT program allocations; this is to ensure BPF programs are in branching range of each other. Patch 1 in this series removes this restriction. To verify exception handling still works, a test case to validate exception handling in BPF programs is added in patch 2. There was previous discussion around this topic [1], in particular would be good to get feedback from Daniel if this approach makes sense. [1] https://lore.kernel.org/all/20181121131733.14910-1-ard.biesheuvel@linaro.org/ Changes since v1: - respin picked up changes in arm64 exception handling changes which removed need for special BPF exception handling in patch 1 - made selftest use task creation/task_struct field instead to minimize BPF selftests parallel runs, moved from CHECK()s to ASSERT_*()s (Andrii, patch 2) Alan Maguire (1): selftests/bpf: add exception handling selftests for tp_bpf program Russell King (1): arm64/bpf: remove 128MB limit for BPF JIT programs arch/arm64/include/asm/extable.h | 9 ----- arch/arm64/include/asm/memory.h | 5 +-- arch/arm64/kernel/traps.c | 2 +- arch/arm64/mm/ptdump.c | 2 - arch/arm64/net/bpf_jit_comp.c | 7 +--- tools/testing/selftests/bpf/prog_tests/exhandler.c | 43 ++++++++++++++++++++++ tools/testing/selftests/bpf/progs/exhandler_kern.c | 43 ++++++++++++++++++++++ 7 files changed, 90 insertions(+), 21 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/exhandler.c create mode 100644 tools/testing/selftests/bpf/progs/exhandler_kern.c -- 1.8.3.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-11-05 16:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-05 16:50 Alan Maguire [this message] 2021-11-05 16:50 ` [PATCH v2 bpf-next 0/2] arm64/bpf: remove 128MB limit for BPF JIT programs Alan Maguire 2021-11-05 16:50 ` [PATCH v2 bpf-next 1/2] " Alan Maguire 2021-11-05 16:50 ` Alan Maguire 2021-11-05 16:50 ` [PATCH v2 bpf-next 2/2] selftests/bpf: add exception handling selftests for tp_bpf program Alan Maguire 2021-11-05 16:50 ` Alan Maguire 2021-11-05 18:54 ` Andrii Nakryiko 2021-11-05 18:54 ` Andrii Nakryiko 2021-11-08 21:30 ` [PATCH v2 bpf-next 0/2] arm64/bpf: remove 128MB limit for BPF JIT programs patchwork-bot+netdevbpf 2021-11-08 21:30 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1636131046-5982-1-git-send-email-alan.maguire@oracle.com \ --to=alan.maguire@oracle.com \ --cc=Jisheng.Zhang@synaptics.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@gmail.com \ --cc=andrii@kernel.org \ --cc=ardb@kernel.org \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=catalin.marinas@arm.com \ --cc=daizhiyuan@phytium.com.cn \ --cc=daniel@iogearbox.net \ --cc=joey.gouly@arm.com \ --cc=john.fastabend@gmail.com \ --cc=jthierry@redhat.com \ --cc=kafai@fb.com \ --cc=kpsingh@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pcc@google.com \ --cc=rppt@kernel.org \ --cc=samitolvanen@google.com \ --cc=songliubraving@fb.com \ --cc=tiantao6@hisilicon.com \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ --cc=yhs@fb.com \ --cc=zlim.lnx@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.