All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Sriram R <quic_srirrama@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH] ath11k: Avoid NULL ptr access during mgmt tx cleanup
Date: Mon, 29 Nov 2021 15:46:47 +0000 (UTC)	[thread overview]
Message-ID: <163820080368.7221.13211393859054966547.kvalo@codeaurora.org> (raw)
In-Reply-To: <1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com>

Sriram R <quic_srirrama@quicinc.com> wrote:

> Currently 'ar' reference is not added in skb_cb during
> WMI mgmt tx. Though this is generally not used during tx completion
> callbacks, on interface removal the remaining idr cleanup callback
> uses the ar ptr from skb_cb from mgmt txmgmt_idr. Hence
> fill them during tx call for proper usage.
> 
> Also free the skb which is missing currently in these
> callbacks.
> 
> Crash_info:
> 
> [19282.489476] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> [19282.489515] pgd = 91eb8000
> [19282.496702] [00000000] *pgd=00000000
> [19282.502524] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> [19282.783728] PC is at ath11k_mac_vif_txmgmt_idr_remove+0x28/0xd8 [ath11k]
> [19282.789170] LR is at idr_for_each+0xa0/0xc8
> 
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-00729-QCAHKSWPL_SILICONZ-3 v2
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

a93789ae541c ath11k: Avoid NULL ptr access during mgmt tx cleanup

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Sriram R <quic_srirrama@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH] ath11k: Avoid NULL ptr access during mgmt tx cleanup
Date: Mon, 29 Nov 2021 15:46:47 +0000 (UTC)	[thread overview]
Message-ID: <163820080368.7221.13211393859054966547.kvalo@codeaurora.org> (raw)
In-Reply-To: <1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com>

Sriram R <quic_srirrama@quicinc.com> wrote:

> Currently 'ar' reference is not added in skb_cb during
> WMI mgmt tx. Though this is generally not used during tx completion
> callbacks, on interface removal the remaining idr cleanup callback
> uses the ar ptr from skb_cb from mgmt txmgmt_idr. Hence
> fill them during tx call for proper usage.
> 
> Also free the skb which is missing currently in these
> callbacks.
> 
> Crash_info:
> 
> [19282.489476] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> [19282.489515] pgd = 91eb8000
> [19282.496702] [00000000] *pgd=00000000
> [19282.502524] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> [19282.783728] PC is at ath11k_mac_vif_txmgmt_idr_remove+0x28/0xd8 [ath11k]
> [19282.789170] LR is at idr_for_each+0xa0/0xc8
> 
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-00729-QCAHKSWPL_SILICONZ-3 v2
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

a93789ae541c ath11k: Avoid NULL ptr access during mgmt tx cleanup

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


  reply	other threads:[~2021-11-29 15:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  9:30 [PATCH] ath11k: Avoid NULL ptr access during mgmt tx cleanup Sriram R
2021-11-25  9:30 ` Sriram R
2021-11-29 15:46 ` Kalle Valo [this message]
2021-11-29 15:46   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163820080368.7221.13211393859054966547.kvalo@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_srirrama@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.