All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: yf.wang@mediatek.com
Cc: catalin.marinas@arm.com, kernel-team@android.com,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Guangming.Cao@mediatek.com,
	linux-mediatek@lists.infradead.org,
	iommu@lists.linux-foundation.org, wsd_upstream@mediatek.com,
	Libo.Kang@mediatek.com, linux-kernel@vger.kernel.org,
	robin.murphy@arm.com, matthias.bgg@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
Date: Tue, 14 Dec 2021 15:18:17 +0000	[thread overview]
Message-ID: <163949313634.2865984.16870619152235318237.b4-ty@kernel.org> (raw)
In-Reply-To: <20211207113315.29109-1-yf.wang@mediatek.com>

On Tue, 7 Dec 2021 19:33:15 +0800, yf.wang@mediatek.com wrote:
> From: Yunfei Wang <yf.wang@mediatek.com>
> 
> In __arm_v7s_alloc_table function:
> iommu call kmem_cache_alloc to allocate page table, this function
> allocate memory may fail, when kmem_cache_alloc fails to allocate
> table, call virt_to_phys will be abnomal and return unexpected phys
> and goto out_free, then call kmem_cache_free to release table will
> trigger KE, __get_free_pages and free_pages have similar problem,
> so add error handle for page table allocation failure.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
      https://git.kernel.org/will/c/a556cfe4cabc

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: yf.wang@mediatek.com
Cc: Guangming.Cao@mediatek.com, Will Deacon <will@kernel.org>,
	catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
	wsd_upstream@mediatek.com, iommu@lists.linux-foundation.org,
	linux-mediatek@lists.infradead.org, Libo.Kang@mediatek.com,
	matthias.bgg@gmail.com, stable@vger.kernel.org,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
	robin.murphy@arm.com
Subject: Re: [PATCH v3] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
Date: Tue, 14 Dec 2021 15:18:17 +0000	[thread overview]
Message-ID: <163949313634.2865984.16870619152235318237.b4-ty@kernel.org> (raw)
In-Reply-To: <20211207113315.29109-1-yf.wang@mediatek.com>

On Tue, 7 Dec 2021 19:33:15 +0800, yf.wang@mediatek.com wrote:
> From: Yunfei Wang <yf.wang@mediatek.com>
> 
> In __arm_v7s_alloc_table function:
> iommu call kmem_cache_alloc to allocate page table, this function
> allocate memory may fail, when kmem_cache_alloc fails to allocate
> table, call virt_to_phys will be abnomal and return unexpected phys
> and goto out_free, then call kmem_cache_free to release table will
> trigger KE, __get_free_pages and free_pages have similar problem,
> so add error handle for page table allocation failure.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
      https://git.kernel.org/will/c/a556cfe4cabc

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: yf.wang@mediatek.com
Cc: catalin.marinas@arm.com, kernel-team@android.com,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Guangming.Cao@mediatek.com,
	linux-mediatek@lists.infradead.org,
	iommu@lists.linux-foundation.org, wsd_upstream@mediatek.com,
	Libo.Kang@mediatek.com, linux-kernel@vger.kernel.org,
	robin.murphy@arm.com, matthias.bgg@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
Date: Tue, 14 Dec 2021 15:18:17 +0000	[thread overview]
Message-ID: <163949313634.2865984.16870619152235318237.b4-ty@kernel.org> (raw)
In-Reply-To: <20211207113315.29109-1-yf.wang@mediatek.com>

On Tue, 7 Dec 2021 19:33:15 +0800, yf.wang@mediatek.com wrote:
> From: Yunfei Wang <yf.wang@mediatek.com>
> 
> In __arm_v7s_alloc_table function:
> iommu call kmem_cache_alloc to allocate page table, this function
> allocate memory may fail, when kmem_cache_alloc fails to allocate
> table, call virt_to_phys will be abnomal and return unexpected phys
> and goto out_free, then call kmem_cache_free to release table will
> trigger KE, __get_free_pages and free_pages have similar problem,
> so add error handle for page table allocation failure.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
      https://git.kernel.org/will/c/a556cfe4cabc

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: yf.wang@mediatek.com
Cc: catalin.marinas@arm.com, kernel-team@android.com,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Guangming.Cao@mediatek.com,
	linux-mediatek@lists.infradead.org,
	iommu@lists.linux-foundation.org, wsd_upstream@mediatek.com,
	Libo.Kang@mediatek.com, linux-kernel@vger.kernel.org,
	robin.murphy@arm.com, matthias.bgg@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
Date: Tue, 14 Dec 2021 15:18:17 +0000	[thread overview]
Message-ID: <163949313634.2865984.16870619152235318237.b4-ty@kernel.org> (raw)
In-Reply-To: <20211207113315.29109-1-yf.wang@mediatek.com>

On Tue, 7 Dec 2021 19:33:15 +0800, yf.wang@mediatek.com wrote:
> From: Yunfei Wang <yf.wang@mediatek.com>
> 
> In __arm_v7s_alloc_table function:
> iommu call kmem_cache_alloc to allocate page table, this function
> allocate memory may fail, when kmem_cache_alloc fails to allocate
> table, call virt_to_phys will be abnomal and return unexpected phys
> and goto out_free, then call kmem_cache_free to release table will
> trigger KE, __get_free_pages and free_pages have similar problem,
> so add error handle for page table allocation failure.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure
      https://git.kernel.org/will/c/a556cfe4cabc

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-14 15:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07  2:47 [PATCH] iommu/io-pgtable-arm-v7s: Add error handle for page table allocation failure yf.wang
2021-12-07  2:47 ` yf.wang
2021-12-07  9:48 ` Will Deacon
2021-12-07  9:48   ` Will Deacon
2021-12-07  9:48   ` Will Deacon
2021-12-07  9:48   ` Will Deacon
2021-12-07 11:33   ` [PATCH v3] " yf.wang
2021-12-07 11:33     ` yf.wang
2021-12-07 11:42     ` Robin Murphy
2021-12-07 11:42       ` Robin Murphy
2021-12-07 11:42       ` Robin Murphy
2021-12-07 11:42       ` Robin Murphy
2021-12-14 15:18     ` Will Deacon [this message]
2021-12-14 15:18       ` Will Deacon
2021-12-14 15:18       ` Will Deacon
2021-12-14 15:18       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163949313634.2865984.16870619152235318237.b4-ty@kernel.org \
    --to=will@kernel.org \
    --cc=Guangming.Cao@mediatek.com \
    --cc=Libo.Kang@mediatek.com \
    --cc=catalin.marinas@arm.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=wsd_upstream@mediatek.com \
    --cc=yf.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.