From: Mark Brown <broonie@kernel.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: cezary.rojewski@intel.com, tiwai@suse.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org,
perex@perex.cz, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org
Subject: Re: [PATCH v3] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio
Date: Tue, 25 Jan 2022 10:20:38 +0000 [thread overview]
Message-ID: <164310603890.74844.13333058824598578375.b4-ty@kernel.org> (raw)
In-Reply-To: <20220121171031.2826198-1-jiasheng@iscas.ac.cn>
On Sat, 22 Jan 2022 01:10:31 +0800, Jiasheng Jiang wrote:
> Since the potential failure of the devm_regmap_init_mmio(), it will
> return error pointer and be assigned to the regmap.
> Then the error pointer will be dereferenced.
> For example rx->regmap will be used in rx_macro_mclk_enable().
> Therefore, it should be better to check it.
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio
commit: aa505ecccf2ae7546e0e262d574e18a9241f3005
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: cezary.rojewski@intel.com, bgoswami@codeaurora.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org
Subject: Re: [PATCH v3] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio
Date: Tue, 25 Jan 2022 10:20:38 +0000 [thread overview]
Message-ID: <164310603890.74844.13333058824598578375.b4-ty@kernel.org> (raw)
In-Reply-To: <20220121171031.2826198-1-jiasheng@iscas.ac.cn>
On Sat, 22 Jan 2022 01:10:31 +0800, Jiasheng Jiang wrote:
> Since the potential failure of the devm_regmap_init_mmio(), it will
> return error pointer and be assigned to the regmap.
> Then the error pointer will be dereferenced.
> For example rx->regmap will be used in rx_macro_mclk_enable().
> Therefore, it should be better to check it.
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio
commit: aa505ecccf2ae7546e0e262d574e18a9241f3005
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2022-01-25 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 17:10 [PATCH v3] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio Jiasheng Jiang
2022-01-21 17:10 ` Jiasheng Jiang
2022-01-25 10:20 ` Mark Brown [this message]
2022-01-25 10:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164310603890.74844.13333058824598578375.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=cezary.rojewski@intel.com \
--cc=jiasheng@iscas.ac.cn \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.