From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, hch@lst.de
Subject: Re: [dm-devel] [PATCH v4 0/3] block/dm: fix bio-based DM IO accounting
Date: Fri, 28 Jan 2022 10:19:10 -0700 [thread overview]
Message-ID: <164339035062.308241.9563111056017072139.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220128155841.39644-1-snitzer@redhat.com>
On Fri, 28 Jan 2022 10:58:38 -0500, Mike Snitzer wrote:
> [this v4 is final iteration, should be "ready"...]
>
> Hi Jens,
>
> Just over 3 years ago, with commit a1e1cb72d9649 ("dm: fix redundant
> IO accounting for bios that need splitting") I focused too narrowly on
> fixing the reported potential for redundant accounting for IO totals.
> Which, at least mentally for me, papered over how inaccurate all other
> bio-based DM's IO accounting is for bios that get split.
>
> [...]
Applied, thanks!
[1/3] block: add bio_start_io_acct_time() to control start_time
commit: 5a6cd1d29f2104bd0306a0f839c8b328395b784f
[2/3] dm: revert partial fix for redundant bio-based IO accounting
commit: b6e31a39c63e0214937c8c586faa10122913e935
[3/3] dm: properly fix redundant bio-based IO accounting
commit: 3c4ae3478082388ae9680a932d6bfd54c10fca0d
Best regards,
--
Jens Axboe
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, hch@lst.de
Subject: Re: [PATCH v4 0/3] block/dm: fix bio-based DM IO accounting
Date: Fri, 28 Jan 2022 10:19:10 -0700 [thread overview]
Message-ID: <164339035062.308241.9563111056017072139.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220128155841.39644-1-snitzer@redhat.com>
On Fri, 28 Jan 2022 10:58:38 -0500, Mike Snitzer wrote:
> [this v4 is final iteration, should be "ready"...]
>
> Hi Jens,
>
> Just over 3 years ago, with commit a1e1cb72d9649 ("dm: fix redundant
> IO accounting for bios that need splitting") I focused too narrowly on
> fixing the reported potential for redundant accounting for IO totals.
> Which, at least mentally for me, papered over how inaccurate all other
> bio-based DM's IO accounting is for bios that get split.
>
> [...]
Applied, thanks!
[1/3] block: add bio_start_io_acct_time() to control start_time
commit: 5a6cd1d29f2104bd0306a0f839c8b328395b784f
[2/3] dm: revert partial fix for redundant bio-based IO accounting
commit: b6e31a39c63e0214937c8c586faa10122913e935
[3/3] dm: properly fix redundant bio-based IO accounting
commit: 3c4ae3478082388ae9680a932d6bfd54c10fca0d
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2022-01-28 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 15:58 [PATCH v4 0/3] block/dm: fix bio-based DM IO accounting Mike Snitzer
2022-01-28 15:58 ` [dm-devel] " Mike Snitzer
2022-01-28 15:58 ` [dm-devel] [PATCH v4 1/3] block: add bio_start_io_acct_time() to control start_time Mike Snitzer
2022-01-28 15:58 ` Mike Snitzer
2022-01-28 15:58 ` [PATCH v4 2/3] dm: revert partial fix for redundant bio-based IO accounting Mike Snitzer
2022-01-28 15:58 ` [dm-devel] " Mike Snitzer
2022-01-28 15:58 ` [dm-devel] [PATCH v4 3/3] dm: properly fix " Mike Snitzer
2022-01-28 15:58 ` Mike Snitzer
2022-01-28 17:19 ` Jens Axboe [this message]
2022-01-28 17:19 ` [PATCH v4 0/3] block/dm: fix bio-based DM " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164339035062.308241.9563111056017072139.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.