From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Jakob Koschel <jakobkoschel@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH] powerpc/sysdev: fix incorrect use to determine if list is empty
Date: Tue, 08 Mar 2022 23:07:44 +1100 [thread overview]
Message-ID: <164674126479.3322453.5888213344645127953.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20220228142434.576226-1-jakobkoschel@gmail.com>
On Mon, 28 Feb 2022 15:24:33 +0100, Jakob Koschel wrote:
> 'gtm' will *always* be set by list_for_each_entry().
> It is incorrect to assume that the iterator value will be NULL if the
> list is empty.
>
> Instead of checking the pointer it should be checked if
> the list is empty.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/sysdev: fix incorrect use to determine if list is empty
https://git.kernel.org/powerpc/c/fa1321b11bd01752f5be2415e74a0e1a7c378262
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Jakob Koschel <jakobkoschel@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH] powerpc/sysdev: fix incorrect use to determine if list is empty
Date: Tue, 08 Mar 2022 23:07:44 +1100 [thread overview]
Message-ID: <164674126479.3322453.5888213344645127953.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20220228142434.576226-1-jakobkoschel@gmail.com>
On Mon, 28 Feb 2022 15:24:33 +0100, Jakob Koschel wrote:
> 'gtm' will *always* be set by list_for_each_entry().
> It is incorrect to assume that the iterator value will be NULL if the
> list is empty.
>
> Instead of checking the pointer it should be checked if
> the list is empty.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/sysdev: fix incorrect use to determine if list is empty
https://git.kernel.org/powerpc/c/fa1321b11bd01752f5be2415e74a0e1a7c378262
cheers
next prev parent reply other threads:[~2022-03-08 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:24 [PATCH] powerpc/sysdev: fix incorrect use to determine if list is empty Jakob Koschel
2022-02-28 14:24 ` Jakob Koschel
2022-03-08 12:07 ` Michael Ellerman [this message]
2022-03-08 12:07 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164674126479.3322453.5888213344645127953.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=jakobkoschel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.