Re: [PATCH v2] ath9k: fix QCA9561 PA bias level

From: Kalle Valo <kvalo@kernel.org>
To: "Thibaut VARÈNE" <hacks+kernel@slashdirt.org>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	linux-wireless@vger.kernel.org, "Felix Fietkau" <nbd@nbd.name>,
	"Petr Štetiar" <ynezz@true.cz>,
	"Clemens Hopfer" <openwrt@wireloss.net>,
	"Thibaut VARÈNE" <hacks+kernel@slashdirt.org>
Subject: Re: [PATCH v2] ath9k: fix QCA9561 PA bias level
Date: Sat, 23 Apr 2022 09:32:47 +0000 (UTC)	[thread overview]
Message-ID: <165070636562.13738.512642859585994950.kvalo@kernel.org> (raw)
In-Reply-To: <20220417145145.1847-1-hacks+kernel@slashdirt.org>

Thibaut VARÈNE <hacks+kernel@slashdirt.org> wrote:

> This patch fixes an invalid TX PA DC bias level on QCA9561, which
> results in a very low output power and very low throughput as devices
> are further away from the AP (compared to other 2.4GHz APs).
> 
> This patch was suggested by Felix Fietkau, who noted[1]:
> "The value written to that register is wrong, because while the mask
> definition AR_CH0_TOP2_XPABIASLVL uses a different value for 9561, the
> shift definition AR_CH0_TOP2_XPABIASLVL_S is hardcoded to 12, which is
> wrong for 9561."
> 
> In real life testing, without this patch the 2.4GHz throughput on
> Yuncore XD3200 is around 10Mbps sitting next to the AP, and closer to
> practical maximum with the patch applied.
> 
> [1] https://lore.kernel.org/all/91c58969-c60e-2f41-00ac-737786d435ae@nbd.name
> 
> Signed-off-by: Thibaut VARÈNE <hacks+kernel@slashdirt.org>
> Acked-by: Felix Fietkau <nbd@nbd.name>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

e999a5da28a0 ath9k: fix QCA9561 PA bias level

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220417145145.1847-1-hacks+kernel@slashdirt.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches