From: Rob Herring <robh@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: robh+dt@kernel.org, andreas@kemnade.info,
dmitry.torokhov@gmail.com, rydberg@bitmath.org,
s.hauer@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
alistair23@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v8 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller
Date: Tue, 02 Aug 2022 08:01:41 -0600 [thread overview]
Message-ID: <1659448901.672444.8419.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220802125827.34509-3-alistair@alistair23.me>
On Tue, 02 Aug 2022 22:58:25 +1000, Alistair Francis wrote:
> Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings
> documentation. It can use I2C or SPI bus.
> This touchscreen can handle some defined zone that are designed and
> sent as button. To be able to customize the keycode sent, the
> "linux,code" property in a "button" sub-node can be used.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../input/touchscreen/cypress,tt21000.yaml | 101 ++++++++++++++++++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dtb: touchscreen@24: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: robh+dt@kernel.org, andreas@kemnade.info,
dmitry.torokhov@gmail.com, rydberg@bitmath.org,
s.hauer@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
alistair23@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v8 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller
Date: Tue, 02 Aug 2022 08:01:41 -0600 [thread overview]
Message-ID: <1659448901.672444.8419.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220802125827.34509-3-alistair@alistair23.me>
On Tue, 02 Aug 2022 22:58:25 +1000, Alistair Francis wrote:
> Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings
> documentation. It can use I2C or SPI bus.
> This touchscreen can handle some defined zone that are designed and
> sent as button. To be able to customize the keycode sent, the
> "linux,code" property in a "button" sub-node can be used.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../input/touchscreen/cypress,tt21000.yaml | 101 ++++++++++++++++++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dtb: touchscreen@24: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-02 14:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 12:58 [PATCH v8 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2022-08-02 12:58 ` Alistair Francis
2022-08-02 12:58 ` [PATCH v8 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2022-08-02 12:58 ` Alistair Francis
2022-08-03 7:36 ` kernel test robot
2022-08-03 7:36 ` kernel test robot
2022-08-06 3:53 ` kernel test robot
2022-08-06 3:53 ` kernel test robot
2022-08-02 12:58 ` [PATCH v8 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller Alistair Francis
2022-08-02 12:58 ` Alistair Francis
2022-08-02 14:01 ` Rob Herring [this message]
2022-08-02 14:01 ` Rob Herring
2022-08-02 15:10 ` Rob Herring
2022-08-02 15:10 ` Rob Herring
2022-08-02 12:58 ` [PATCH v8 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2022-08-02 12:58 ` Alistair Francis
2022-08-02 12:58 ` [PATCH v8 4/4] ARM: dts: imx7d-remarkable2: Enable the cyttsp5 Alistair Francis
2022-08-02 12:58 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1659448901.672444.8419.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.