From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Mark Brown <broonie@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Andy Gross <agross@kernel.org>,
alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 09/12] dt-bindings: soc: qcom: apr: correct service children
Date: Tue, 06 Sep 2022 12:46:42 -0500 [thread overview]
Message-ID: <1662486402.667876.780014.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220906121655.303693-10-krzysztof.kozlowski@linaro.org>
On Tue, 06 Sep 2022 14:16:52 +0200, Krzysztof Kozlowski wrote:
> The APR bindings were not describing properly children nodes for DAIs.
> None of the DTSes use unit addresses for the children, so correct the
> nodes and reference their schema: clock-controller, dais and routing.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/soc/qcom/qcom,apr.yaml | 38 +++++++++++++------
> .../sound/qcom,q6dsp-lpass-clocks.yaml | 16 ++------
> .../sound/qcom,q6dsp-lpass-ports.yaml | 16 ++------
> 3 files changed, 35 insertions(+), 35 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dtb: gpr: service@1: '#address-cells', '#size-cells', 'apm-dai@1' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 09/12] dt-bindings: soc: qcom: apr: correct service children
Date: Tue, 06 Sep 2022 12:46:42 -0500 [thread overview]
Message-ID: <1662486402.667876.780014.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220906121655.303693-10-krzysztof.kozlowski@linaro.org>
On Tue, 06 Sep 2022 14:16:52 +0200, Krzysztof Kozlowski wrote:
> The APR bindings were not describing properly children nodes for DAIs.
> None of the DTSes use unit addresses for the children, so correct the
> nodes and reference their schema: clock-controller, dais and routing.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/soc/qcom/qcom,apr.yaml | 38 +++++++++++++------
> .../sound/qcom,q6dsp-lpass-clocks.yaml | 16 ++------
> .../sound/qcom,q6dsp-lpass-ports.yaml | 16 ++------
> 3 files changed, 35 insertions(+), 35 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dtb: gpr: service@1: '#address-cells', '#size-cells', 'apm-dai@1' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-09-06 17:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:16 [PATCH 00/12] ASoC/qcom/remoteproc/arm64: Qualcomm ADSP DTS and binding fixes Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 01/12] arm64: dts: qcom: sdm630: align APR services node names with dtschema Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 02/12] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-07 3:26 ` Steev Klimaszewski
2022-09-06 12:16 ` [PATCH 03/12] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 04/12] arm64: dts: qcom: msm8996: fix APR services nodes Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 05/12] arm64: dts: qcom: sdm845: align dai node names with dtschema Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 06/12] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 07/12] arm64: dts: qcom: qrb5165-rb5: " Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 08/12] arm64: dts: qcom: sm8250: use generic name for LPASS clock controller Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 09/12] dt-bindings: soc: qcom: apr: correct service children Krzysztof Kozlowski
2022-09-06 17:46 ` Rob Herring [this message]
2022-09-06 17:46 ` Rob Herring
2022-09-07 8:30 ` Krzysztof Kozlowski
2022-09-07 8:30 ` Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 10/12] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 10/12] ASoC: dt-bindings: qcom, q6dsp-lpass-ports: " Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 11/12] ASoC: dt-bindings: qcom, q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 11/12] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-06 12:16 ` [PATCH 12/12] dt-bindings: soc: qcom: apr: add missing properties Krzysztof Kozlowski
2022-09-06 17:04 ` [PATCH 00/12] ASoC/qcom/remoteproc/arm64: Qualcomm ADSP DTS and binding fixes Srinivas Kandagatla
2022-10-18 3:05 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662486402.667876.780014.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.