From: Palmer Dabbelt <palmer@rivosinc.com>
To: linux-riscv@lists.infradead.org, Ben Dooks <ben-linux@fluff.org>
Cc: aou@eecs.berkeley.edu, Paul Walmsley <paul.walmsley@sifive.com>,
linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] riscv: uaccess: fix type of 0 variable on error in get_user()
Date: Thu, 05 Jan 2023 14:52:25 -0800 [thread overview]
Message-ID: <167295914585.11542.3959390296046499334.b4-ty@rivosinc.com> (raw)
In-Reply-To: <20221229170545.718264-1-ben-linux@fluff.org>
On Thu, 29 Dec 2022 17:05:45 +0000, Ben Dooks wrote:
> If the get_user(x, ptr) has x as a pointer, then the setting
> of (x) = 0 is going to produce the following sparse warning,
> so fix this by forcing the type of 'x' when access_ok() fails.
>
> fs/aio.c:2073:21: warning: Using plain integer as NULL pointer
>
>
> [...]
Applied, thanks!
[1/1] riscv: uaccess: fix type of 0 variable on error in get_user()
https://git.kernel.org/palmer/c/b9b916aee671
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@rivosinc.com>
To: linux-riscv@lists.infradead.org, Ben Dooks <ben-linux@fluff.org>
Cc: aou@eecs.berkeley.edu, Paul Walmsley <paul.walmsley@sifive.com>,
linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] riscv: uaccess: fix type of 0 variable on error in get_user()
Date: Thu, 05 Jan 2023 14:52:25 -0800 [thread overview]
Message-ID: <167295914585.11542.3959390296046499334.b4-ty@rivosinc.com> (raw)
In-Reply-To: <20221229170545.718264-1-ben-linux@fluff.org>
On Thu, 29 Dec 2022 17:05:45 +0000, Ben Dooks wrote:
> If the get_user(x, ptr) has x as a pointer, then the setting
> of (x) = 0 is going to produce the following sparse warning,
> so fix this by forcing the type of 'x' when access_ok() fails.
>
> fs/aio.c:2073:21: warning: Using plain integer as NULL pointer
>
>
> [...]
Applied, thanks!
[1/1] riscv: uaccess: fix type of 0 variable on error in get_user()
https://git.kernel.org/palmer/c/b9b916aee671
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-05 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 17:05 [PATCH] riscv: uaccess: fix type of 0 variable on error in get_user() Ben Dooks
2022-12-29 17:05 ` Ben Dooks
2022-12-29 17:31 ` Palmer Dabbelt
2022-12-29 17:31 ` Palmer Dabbelt
2022-12-29 17:34 ` Ben Dooks
2022-12-29 17:34 ` Ben Dooks
2023-01-05 22:52 ` Palmer Dabbelt [this message]
2023-01-05 22:52 ` Palmer Dabbelt
2023-01-05 23:00 ` patchwork-bot+linux-riscv
2023-01-05 23:00 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167295914585.11542.3959390296046499334.b4-ty@rivosinc.com \
--to=palmer@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.