Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc

From: Rob Herring <robh@kernel.org>
To: Yann Sionneau <ysionneau@kalray.eu>
Cc: "Albert Ou" <aou@eecs.berkeley.edu>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Louis Morhet" <lmorhet@kalray.eu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Julien Villette" <jvillette@kalray.eu>,
	"Mark Brown" <broonie@kernel.org>,
	linux-doc@vger.kernel.org, "Bibo Mao" <maobibo@loongson.cn>,
	linux-kernel@vger.kernel.org,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Guillaume Missonnier" <gmissonnier@kalray.eu>,
	"Nick Piggin" <npiggin@gmail.com>, ",
	Bharat Bhushan" <bbhushan2@marvell.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"Marc Poulhiès" <dkm@kataplop.net>,
	bpf@vger.kernel.org, "Eric Paris" <eparis@redhat.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Jonathan Borne" <jborne@kalray.eu>,
	"Alex Michon" <amichon@kalray.eu>,
	"John Garry" <john.garry@huawei.com>,
	linux-audit@redhat.com, linux-riscv@lists.infradead.org,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Eric Biederman" <ebiederm@xmission.com>,
	"Waiman Long" <longman@redhat.com>,
	"Vincent Chardon" <vincent.chardon@elsys-design.com>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Guangbin Huang" <huangguangbin2@huawei.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Julien Hascoet" <jhascoet@kalray.eu>,
	"Clement Leger" <clement@clement-leger.fr>, ",
	Thomas Gleixner" <tglx@linutronix.de>,
	"Ashley Lesdalons" <alesdalons@kalray.eu>,
	"Luc Michel" <lmichel@kalray.eu>,
	"Jean-Christophe Pince" <jcpince@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	linux-arch@vger.kernel.org,
	"Guillaume Thouvenin" <gthouvenin@kalray.eu>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Will Deacon" <will@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Thomas Costis" <tcostis@kalray.eu>,
	"Qi Liu" <liuqi115@huawei.com>,
	"Benjamin Mugnier" <mugnier.benjamin@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>,
	"Julian Vetter" <jvetter@kalray.eu>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Marius Gligor" <mgligor@kalray.eu>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Jules Maselbas" <jmaselbas@kalray.eu>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Alexey Dobriyan" <adobriyan@gmail.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	"Shaokun Zhang" <zhangshaokun@hisilicon.com>,
	devicetree@vger.kernel.org, linux-mm@kvack.org,
	"Samuel Jones" <sjones@kalray.eu>, "WANG Xuerui" <git@xen0n.name>
Subject: Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc
Date: Fri, 20 Jan 2023 11:28:32 -0600	[thread overview]
Message-ID: <167423561426.1325837.1311424254927277836.robh@kernel.org> (raw)
In-Reply-To: <20230120141002.2442-3-ysionneau@kalray.eu>

On Fri, 20 Jan 2023 15:09:33 +0100, Yann Sionneau wrote:
> From: Jules Maselbas <jmaselbas@kalray.eu>
> 
> Add documentation for `kalray,kv3-1-core-intc` binding.
> 
> Co-developed-by: Jules Maselbas <jmaselbas@kalray.eu>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
> ---
> 
> Notes:
>     V1 -> V2: new patch
> 
>  .../kalray,kv3-1-core-intc.yaml               | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: properties:reg:maxItems: 0 is less than the minimum of 1
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: $id: 'http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-core-intc#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: 'maintainers' is a required property
	hint: Metaschema for devicetree binding documentation
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: 'oneOf' conditional failed, one must be fixed:
	'unevaluatedProperties' is a required property
	'additionalProperties' is a required property
	hint: Either unevaluatedProperties or additionalProperties must be present
	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: properties:reg: 'anyOf' conditional failed, one must be fixed:
	'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
	1 was expected
		hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values.
	0 is less than the minimum of 2
		hint: Arrays must be described with a combination of minItems/maxItems/items
	hint: cell array properties must define how many entries and what the entries are when there is more than one entry.
	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: properties: 'anyOf' conditional failed, one must be fixed:
	'interrupt-controller' is a required property
	'interrupt-map' is a required property
	from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: properties:kalray,intc-nr-irqs: 'oneOf' conditional failed, one must be fixed:
	'type' is a required property
		hint: A vendor boolean property can use "type: boolean"
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: properties:kalray,intc-nr-irqs: 'oneOf' conditional failed, one must be fixed:
		'enum' is a required property
		'const' is a required property
		hint: A vendor string property with exact values has an implicit type
		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: properties:kalray,intc-nr-irqs: 'oneOf' conditional failed, one must be fixed:
		'$ref' is a required property
		'allOf' is a required property
		hint: A vendor property needs a $ref to types.yaml
		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
./Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml: $id: relative path/filename doesn't match actual path or filename
	expected: http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-core-intc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230120141002.2442-3-ysionneau@kalray.eu

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.