From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, Guangwu Zhang <guazhang@redhat.com>,
Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH 1/3] blk-mq: don't queue plugged passthrough requests into scheduler
Date: Thu, 18 May 2023 19:41:38 -0600 [thread overview]
Message-ID: <168446049859.141878.12246667725693827889.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230518053101.760632-2-hch@lst.de>
On Thu, 18 May 2023 07:30:59 +0200, Christoph Hellwig wrote:
> Passthrough) request should never be queued to the I/O scheduler,
> as scheduling these opaque requests doens't make sense, and I/O
> schedulers might required req->bio to be always valid.
>
> We never let passthrough request cross scheduler before commit
> 1c2d2fff6dc0 ("block: wire-up support for passthrough plugging"),
> restored this behavior even for passthrough requests issued under
> a plug.
>
> [...]
Applied, thanks!
[1/3] blk-mq: don't queue plugged passthrough requests into scheduler
commit: d97217e7f024bbe9aa62aea070771234c2879358
[2/3] blk-mq: remove RQF_ELVPRIV
commit: fdcab6cddef24a26b86d798814b3c25057e53c21
[3/3] blk-mq: make sure elevator callbacks aren't called for passthrough request
commit: 59f86a9c69ad379650839b41bb01be213bfac9e3
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2023-05-19 1:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 5:30 keep passthrough request out of the I/O schedulers Christoph Hellwig
2023-05-18 5:30 ` [PATCH 1/3] blk-mq: don't queue plugged passthrough requests into scheduler Christoph Hellwig
2023-05-18 17:50 ` Bart Van Assche
2023-05-19 1:41 ` Jens Axboe [this message]
2023-05-18 5:31 ` [PATCH 2/3] blk-mq: remove RQF_ELVPRIV Christoph Hellwig
2023-05-18 7:05 ` Ming Lei
2023-05-18 7:11 ` Ming Lei
2023-05-18 13:06 ` Christoph Hellwig
2023-05-18 13:20 ` Ming Lei
2023-05-19 1:39 ` Jens Axboe
2023-05-18 17:52 ` Bart Van Assche
2023-05-18 5:31 ` [PATCH 3/3] blk-mq: make sure elevator callbacks aren't called for passthrough request Christoph Hellwig
2023-05-18 13:23 ` Ming Lei
2023-05-18 17:58 ` Bart Van Assche
2023-05-19 1:39 ` keep passthrough request out of the I/O schedulers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168446049859.141878.12246667725693827889.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=guazhang@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.