From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 3/3] blk-mq: make sure elevator callbacks aren't called for passthrough request
Date: Thu, 18 May 2023 10:58:10 -0700 [thread overview]
Message-ID: <e2f62a6b-dc8e-cdf7-8405-e3af1f51ae77@acm.org> (raw)
In-Reply-To: <20230518053101.760632-4-hch@lst.de>
On 5/17/23 22:31, Christoph Hellwig wrote:
> In case of q->elevator, passthrought request can still be marked as
passthrought -> passthrough
> +/* use hctx->sched_tags */
> +#define RQF_SCHED_TAGS ((__force req_flags_t)(1 << 8))
> +/* use and I/O scheduler for this request */
> +#define RQF_USE_SCHED ((__force req_flags_t)(1 << 9))
and -> an
Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2023-05-18 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 5:30 keep passthrough request out of the I/O schedulers Christoph Hellwig
2023-05-18 5:30 ` [PATCH 1/3] blk-mq: don't queue plugged passthrough requests into scheduler Christoph Hellwig
2023-05-18 17:50 ` Bart Van Assche
2023-05-19 1:41 ` Jens Axboe
2023-05-18 5:31 ` [PATCH 2/3] blk-mq: remove RQF_ELVPRIV Christoph Hellwig
2023-05-18 7:05 ` Ming Lei
2023-05-18 7:11 ` Ming Lei
2023-05-18 13:06 ` Christoph Hellwig
2023-05-18 13:20 ` Ming Lei
2023-05-19 1:39 ` Jens Axboe
2023-05-18 17:52 ` Bart Van Assche
2023-05-18 5:31 ` [PATCH 3/3] blk-mq: make sure elevator callbacks aren't called for passthrough request Christoph Hellwig
2023-05-18 13:23 ` Ming Lei
2023-05-18 17:58 ` Bart Van Assche [this message]
2023-05-19 1:39 ` keep passthrough request out of the I/O schedulers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f62a6b-dc8e-cdf7-8405-e3af1f51ae77@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.