From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, julien.grall@arm.com,
Stefano Stabellini <stefanos@xilinx.com>,
andrew.cooper3@citrix.com
Subject: Re: [Xen-devel] [PATCH v4 2/6] xen: add a p2mt parameter to map_mmio_regions
Date: Fri, 9 Aug 2019 13:10:30 +0200 [thread overview]
Message-ID: <16851887-a6e5-ac4f-32f5-52f46a1b160f@suse.com> (raw)
In-Reply-To: <20190807002311.9906-2-sstabellini@kernel.org>
On 07.08.2019 02:23, Stefano Stabellini wrote:
> Add a p2mt parameter to map_mmio_regions, pass p2m_mmio_direct_dev on
> ARM and p2m_mmio_direct on x86 -- no changes in behavior.
>
> On x86, introduce a macro to strip away the last parameter and rename
> the existing implementation of map_mmio_regions to map_mmio_region.
> Use map_mmio_region in vpci as it is x86-only today.
>
> On ARM, given the similarity between map_mmio_regions after the change
> and map_regions_p2mt, remove un/map_regions_p2mt. Also add an ASSERT to
> check that only p2m_mmio_* types are passed to it.
>
> Also fix the style of the comment on top of map_mmio_regions since we
> are at it.
>
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
I guess apart from the naming question (see other sub-thread) I'm
fine with this. However, ...
> ---
> xen/arch/arm/acpi/domain_build.c | 4 ++--
> xen/arch/arm/domain_build.c | 2 +-
> xen/arch/arm/gic-v2.c | 3 ++-
> xen/arch/arm/p2m.c | 19 ++-----------------
> xen/arch/arm/platforms/exynos5.c | 6 ++++--
> xen/arch/arm/platforms/omap5.c | 12 ++++++++----
> xen/arch/arm/traps.c | 2 +-
> xen/arch/arm/vgic-v2.c | 2 +-
> xen/arch/arm/vgic/vgic-v2.c | 2 +-
> xen/arch/x86/hvm/dom0_build.c | 2 +-
> xen/arch/x86/mm/p2m.c | 8 ++++----
> xen/common/domctl.c | 7 ++++++-
> xen/drivers/vpci/header.c | 2 +-
... these two and ...
> xen/include/asm-arm/p2m.h | 15 ---------------
> xen/include/asm-x86/p2m.h | 8 ++++++++
> xen/include/xen/p2m-common.h | 11 +++++++----
... this one require you to widen the Cc list. This would the also
allow George to become more aware of the asm-x86/p2m.h change,
which strictly by ./MAINTAINERS he may not need to ack, but which
is part of "X86 MEMORY MANAGEMENT" really.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-09 11:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:23 [Xen-devel] [PATCH v4 0/6] iomem memory policy Stefano Stabellini
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 1/6] xen/arm: introduce p2m_is_mmio Stefano Stabellini
2019-08-09 10:05 ` Julien Grall
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 2/6] xen: add a p2mt parameter to map_mmio_regions Stefano Stabellini
2019-08-09 10:23 ` Julien Grall
2019-08-09 10:37 ` Jan Beulich
2019-08-09 10:51 ` Julien Grall
2019-08-09 11:07 ` Jan Beulich
2019-08-09 11:10 ` Jan Beulich [this message]
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 3/6] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy Stefano Stabellini
2019-08-09 11:25 ` Jan Beulich
2019-08-09 17:25 ` Julien Grall
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 4/6] libxc: introduce xc_domain_mem_map_policy Stefano Stabellini
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 5/6] libxl/xl: add memory policy option to iomem Stefano Stabellini
2019-08-09 17:23 ` Julien Grall
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 6/6] xen/arm: clarify the support status of iomem configurations Stefano Stabellini
2019-08-07 9:08 ` Julien Grall
2019-08-07 9:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16851887-a6e5-ac4f-32f5-52f46a1b160f@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.