From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: andrew.cooper3@citrix.com,
Stefano Stabellini <stefanos@xilinx.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v4 2/6] xen: add a p2mt parameter to map_mmio_regions
Date: Fri, 9 Aug 2019 13:07:22 +0200 [thread overview]
Message-ID: <336ef109-68e5-9cec-2537-2b5e362d5874@suse.com> (raw)
In-Reply-To: <dcad508a-f50e-5fdc-7664-4e7fcc20022a@arm.com>
On 09.08.2019 12:51, Julien Grall wrote:
> Hi,
>
> On 09/08/2019 11:37, Jan Beulich wrote:
>> On 09.08.2019 12:23, Julien Grall wrote:
>>> On 07/08/2019 01:23, Stefano Stabellini wrote:
>>>> Add a p2mt parameter to map_mmio_regions, pass p2m_mmio_direct_dev on
>>>> ARM and p2m_mmio_direct on x86 -- no changes in behavior.
>>>>
>>>> On x86, introduce a macro to strip away the last parameter and rename
>>>> the existing implementation of map_mmio_regions to map_mmio_region.
>>>> Use map_mmio_region in vpci as it is x86-only today.
>>>
>>> This feels quite wrong. You have a "plural" function calling a "singular" function. This is usually the other way around. This is also quite difficult for a user to understand why the 's' is been dropped/added (depending how you view it) because in both case you only deal with a single region.
>>
>> "Happy" is the wrong term. I'd welcome any better suggestion. I
>> simply couldn't think of a sensible alternative, but I do want
>> to see the leading underscores gone that were there originally.
>
> We are already modifying all the callers in this series, so doing the renaming should not make the diff worst.
>
> A few of suggestion:
> 1) map_mmio_region() calling map_mmio_regions()
> 2) arch_map_mmio_region() calling map_mmio_region()
> 3) map_mmio_region() calling arch_map_mmio_region()
Ideally the top level functions (i.e. also the unmap one) would lose
their plurals. Seeing that both require a per-arch implementation, I
guess the best choice from the above would be 2 (with the unmap one
following suit).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-09 11:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:23 [Xen-devel] [PATCH v4 0/6] iomem memory policy Stefano Stabellini
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 1/6] xen/arm: introduce p2m_is_mmio Stefano Stabellini
2019-08-09 10:05 ` Julien Grall
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 2/6] xen: add a p2mt parameter to map_mmio_regions Stefano Stabellini
2019-08-09 10:23 ` Julien Grall
2019-08-09 10:37 ` Jan Beulich
2019-08-09 10:51 ` Julien Grall
2019-08-09 11:07 ` Jan Beulich [this message]
2019-08-09 11:10 ` Jan Beulich
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 3/6] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy Stefano Stabellini
2019-08-09 11:25 ` Jan Beulich
2019-08-09 17:25 ` Julien Grall
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 4/6] libxc: introduce xc_domain_mem_map_policy Stefano Stabellini
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 5/6] libxl/xl: add memory policy option to iomem Stefano Stabellini
2019-08-09 17:23 ` Julien Grall
2019-08-07 0:23 ` [Xen-devel] [PATCH v4 6/6] xen/arm: clarify the support status of iomem configurations Stefano Stabellini
2019-08-07 9:08 ` Julien Grall
2019-08-07 9:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336ef109-68e5-9cec-2537-2b5e362d5874@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.