All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+linux-riscv@kernel.org
To: John Hubbard <jhubbard@nvidia.com>
Cc: linux-riscv@lists.infradead.org, akpm@linux-foundation.org,
	aou@eecs.berkeley.edu, alexghiti@rivosinc.com,
	ajones@ventanamicro.com, hughd@google.com, palmer@dabbelt.com,
	paul.walmsley@sifive.com, panqinglin2020@iscas.ac.cn,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	jthoughton@google.com, ryan.roberts@arm.com
Subject: Re: [PATCH] mm: riscv: fix an unsafe pte read in huge_pte_alloc()
Date: Wed, 05 Jul 2023 23:50:22 +0000	[thread overview]
Message-ID: <168860102266.23922.10126828574164842204.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230703190044.311730-1-jhubbard@nvidia.com>

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Mon, 3 Jul 2023 12:00:44 -0700 you wrote:
> The WARN_ON_ONCE() statement in riscv's huge_pte_alloc() is susceptible
> to false positives, because the pte is read twice at the C language
> level, locklessly, within the same conditional statement. Depending on
> compiler behavior, this can lead to generated machine code that actually
> reads the pte just once, or twice. Reading twice will expose the code to
> changing pte values and cause incorrect behavior.
> 
> [...]

Here is the summary with links:
  - mm: riscv: fix an unsafe pte read in huge_pte_alloc()
    https://git.kernel.org/riscv/c/62ba41d27612

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+linux-riscv@kernel.org
To: John Hubbard <jhubbard@nvidia.com>
Cc: linux-riscv@lists.infradead.org, akpm@linux-foundation.org,
	aou@eecs.berkeley.edu, alexghiti@rivosinc.com,
	ajones@ventanamicro.com, hughd@google.com, palmer@dabbelt.com,
	paul.walmsley@sifive.com, panqinglin2020@iscas.ac.cn,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	jthoughton@google.com, ryan.roberts@arm.com
Subject: Re: [PATCH] mm: riscv: fix an unsafe pte read in huge_pte_alloc()
Date: Wed, 05 Jul 2023 23:50:22 +0000	[thread overview]
Message-ID: <168860102266.23922.10126828574164842204.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230703190044.311730-1-jhubbard@nvidia.com>

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Mon, 3 Jul 2023 12:00:44 -0700 you wrote:
> The WARN_ON_ONCE() statement in riscv's huge_pte_alloc() is susceptible
> to false positives, because the pte is read twice at the C language
> level, locklessly, within the same conditional statement. Depending on
> compiler behavior, this can lead to generated machine code that actually
> reads the pte just once, or twice. Reading twice will expose the code to
> changing pte values and cause incorrect behavior.
> 
> [...]

Here is the summary with links:
  - mm: riscv: fix an unsafe pte read in huge_pte_alloc()
    https://git.kernel.org/riscv/c/62ba41d27612

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-07-05 23:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 19:00 [PATCH] mm: riscv: fix an unsafe pte read in huge_pte_alloc() John Hubbard
2023-07-03 19:00 ` John Hubbard
2023-07-04  6:01 ` Andrew Jones
2023-07-04  6:01   ` Andrew Jones
2023-07-04  7:06 ` Ryan Roberts
2023-07-04  7:06   ` Ryan Roberts
2023-07-05 23:38 ` Palmer Dabbelt
2023-07-05 23:38   ` Palmer Dabbelt
2023-07-05 23:50 ` patchwork-bot+linux-riscv [this message]
2023-07-05 23:50   ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168860102266.23922.10126828574164842204.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+linux-riscv@kernel.org \
    --cc=ajones@ventanamicro.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexghiti@rivosinc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=hughd@google.com \
    --cc=jhubbard@nvidia.com \
    --cc=jthoughton@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=panqinglin2020@iscas.ac.cn \
    --cc=paul.walmsley@sifive.com \
    --cc=ryan.roberts@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.