All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: conor.dooley@microchip.com, daire.mcnamara@microchip.com,
	linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org,
	Chen Jiahao <chenjiahao16@huawei.com>
Subject: Re: [PATCH -next v2] spi: microchip-core: Clean up redundant dev_err_probe()
Date: Fri, 28 Jul 2023 21:05:54 +0100	[thread overview]
Message-ID: <169057475433.253217.4192656130835572334.b4-ty@kernel.org> (raw)
In-Reply-To: <20230728075729.3451867-1-chenjiahao16@huawei.com>

On Fri, 28 Jul 2023 15:57:29 +0800, Chen Jiahao wrote:
> Refering to platform_get_irq()'s definition, the return value has
> already been checked if ret < 0, and printed via dev_err_probe().
> Calling dev_err_probe() one more time outside platform_get_irq()
> is obviously redundant.
> 
> Furthermore, platform_get_irq() will never return irq equals 0,
> removing spi->irq == 0 checking to clean it up.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: microchip-core: Clean up redundant dev_err_probe()
      commit: 71ee2a4f95e205bd33e79c7bd4bece3885e0e366

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: conor.dooley@microchip.com, daire.mcnamara@microchip.com,
	 linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org,
	 Chen Jiahao <chenjiahao16@huawei.com>
Subject: Re: [PATCH -next v2] spi: microchip-core: Clean up redundant dev_err_probe()
Date: Fri, 28 Jul 2023 21:05:54 +0100	[thread overview]
Message-ID: <169057475433.253217.4192656130835572334.b4-ty@kernel.org> (raw)
In-Reply-To: <20230728075729.3451867-1-chenjiahao16@huawei.com>

On Fri, 28 Jul 2023 15:57:29 +0800, Chen Jiahao wrote:
> Refering to platform_get_irq()'s definition, the return value has
> already been checked if ret < 0, and printed via dev_err_probe().
> Calling dev_err_probe() one more time outside platform_get_irq()
> is obviously redundant.
> 
> Furthermore, platform_get_irq() will never return irq equals 0,
> removing spi->irq == 0 checking to clean it up.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: microchip-core: Clean up redundant dev_err_probe()
      commit: 71ee2a4f95e205bd33e79c7bd4bece3885e0e366

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-07-28 20:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28  7:57 [PATCH -next v2] spi: microchip-core: Clean up redundant dev_err_probe() Chen Jiahao
2023-07-28  7:57 ` Chen Jiahao
2023-07-28  8:05 ` Conor Dooley
2023-07-28  8:05   ` Conor Dooley
2023-07-28 20:05 ` Mark Brown [this message]
2023-07-28 20:05   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169057475433.253217.4192656130835572334.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=chenjiahao16@huawei.com \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.