Re: [PATCH v2] spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative

From: Mark Brown <broonie@kernel.org>
To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	coolrrsh@gmail.com
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
Date: Mon, 07 Aug 2023 22:57:32 +0100	[thread overview]
Message-ID: <169144545291.329334.7193582247834857976.b4-ty@kernel.org> (raw)
In-Reply-To: <20230807144942.30317-2-coolrrsh@gmail.com>

On Mon, 07 Aug 2023 20:19:42 +0530, coolrrsh@gmail.com wrote:
> In struct mpc52xx_psc_spi, the variable 'irq' is declared as an unsigned int.
> The comparison of variable 'irq'  with signed int operand is incorrect. Also,
> the return value from the call to platform_get_irq(pdev,0) is int and it is
> assigned to an unsigned int variable 'irq', thus redeclaring the type of
> variable 'irq' to signed int.
> 
> This fixes warning such as:
> drivers/spi/spi-mpc52xx-psc.c:332:5-13:
> WARNING: Unsigned expression compared with zero: mps -> irq < 0
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
      commit: 4f5177458ba97734149897c5d4d44f85b8fe0348

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark