All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Vlastimil Babka <vbabka@suse.cz>
Cc: ackerleytng@google.com, akpm@linux-foundation.org,
	anup@brainfault.org, aou@eecs.berkeley.edu,
	chao.p.peng@linux.intel.com, chenhuacai@kernel.org,
	david@redhat.com, isaku.yamahata@gmail.com, jarkko@kernel.org,
	jmorris@namei.org, kirill.shutemov@linux.intel.com,
	kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	kvmarm@lists.linux.dev, liam.merwick@oracle.com,
	linux-arm-kernel@lists.infradead.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-mm@kvack.org,
	linux-riscv@lists.infradead.org,
	linux-security-module@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, mail@maciej.szmigiero.name,
	maz@kernel.org, michael.roth@amd.com, mpe@ellerman.id.au,
	oliver.upton@linux.dev, palmer@dabbelt.com,
	paul.walmsley@sifive.com, paul@paul-moore.com,
	pbonzini@redhat.com, qperret@google.com, serge@hallyn.com,
	tabba@google.com, vannapurve@google.com, wei.w.wang@intel.com,
	willy@infradead.org, yu.c.zhang@linux.intel.com
Subject: Re: [PATCH gmem FIXUP v2] mm, compaction: make testing mapping_unmovable() safe
Date: Fri,  8 Sep 2023 17:15:33 -0700	[thread overview]
Message-ID: <169421599820.98577.9267896589643015779.b4-ty@google.com> (raw)
In-Reply-To: <20230908074222.28723-2-vbabka@suse.cz>

On Fri, 08 Sep 2023 09:42:23 +0200, Vlastimil Babka wrote:
> As Kirill pointed out, mapping can be removed under us due to
> truncation. Test it under folio lock as already done for the async
> compaction / dirty folio case. To prevent locking every folio with
> mapping to do the test, do it only for unevictable folios, as we can
> expect the unmovable mapping folios are also unevictable. To enforce
> that expecation, make mapping_set_unmovable() also set AS_UNEVICTABLE.
> 
> [...]

Applied to kvm-x86 guest_memfd, thanks!

[1/1] mm, compaction: make testing mapping_unmovable() safe
      https://github.com/kvm-x86/linux/commit/4876a35647b9

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Vlastimil Babka <vbabka@suse.cz>
Cc: ackerleytng@google.com, akpm@linux-foundation.org,
	anup@brainfault.org,  aou@eecs.berkeley.edu,
	chao.p.peng@linux.intel.com, chenhuacai@kernel.org,
	 david@redhat.com, isaku.yamahata@gmail.com, jarkko@kernel.org,
	 jmorris@namei.org, kirill.shutemov@linux.intel.com,
	 kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	kvmarm@lists.linux.dev,  liam.merwick@oracle.com,
	linux-arm-kernel@lists.infradead.org,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mips@vger.kernel.org, linux-mm@kvack.org,
	 linux-riscv@lists.infradead.org,
	linux-security-module@vger.kernel.org,
	 linuxppc-dev@lists.ozlabs.org, mail@maciej.szmigiero.name,
	maz@kernel.org,  michael.roth@amd.com, mpe@ellerman.id.au,
	oliver.upton@linux.dev,  palmer@dabbelt.com,
	paul.walmsley@sifive.com, paul@paul-moore.com,
	 pbonzini@redhat.com, qperret@google.com, serge@hallyn.com,
	tabba@google.com,  vannapurve@google.com, wei.w.wang@intel.com,
	willy@infradead.org,  yu.c.zhang@linux.intel.com
Subject: Re: [PATCH gmem FIXUP v2] mm, compaction: make testing mapping_unmovable() safe
Date: Fri,  8 Sep 2023 17:15:33 -0700	[thread overview]
Message-ID: <169421599820.98577.9267896589643015779.b4-ty@google.com> (raw)
In-Reply-To: <20230908074222.28723-2-vbabka@suse.cz>

On Fri, 08 Sep 2023 09:42:23 +0200, Vlastimil Babka wrote:
> As Kirill pointed out, mapping can be removed under us due to
> truncation. Test it under folio lock as already done for the async
> compaction / dirty folio case. To prevent locking every folio with
> mapping to do the test, do it only for unevictable folios, as we can
> expect the unmovable mapping folios are also unevictable. To enforce
> that expecation, make mapping_set_unmovable() also set AS_UNEVICTABLE.
> 
> [...]

Applied to kvm-x86 guest_memfd, thanks!

[1/1] mm, compaction: make testing mapping_unmovable() safe
      https://github.com/kvm-x86/linux/commit/4876a35647b9

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Vlastimil Babka <vbabka@suse.cz>
Cc: ackerleytng@google.com, akpm@linux-foundation.org,
	anup@brainfault.org,  aou@eecs.berkeley.edu,
	chao.p.peng@linux.intel.com, chenhuacai@kernel.org,
	 david@redhat.com, isaku.yamahata@gmail.com, jarkko@kernel.org,
	 jmorris@namei.org, kirill.shutemov@linux.intel.com,
	 kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	kvmarm@lists.linux.dev,  liam.merwick@oracle.com,
	linux-arm-kernel@lists.infradead.org,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mips@vger.kernel.org, linux-mm@kvack.org,
	 linux-riscv@lists.infradead.org,
	linux-security-module@vger.kernel.org,
	 linuxppc-dev@lists.ozlabs.org, mail@maciej.szmigiero.name,
	maz@kernel.org,  michael.roth@amd.com, mpe@ellerman.id.au,
	oliver.upton@linux.dev,  palmer@dabbelt.com,
	paul.walmsley@sifive.com, paul@paul-moore.com,
	 pbonzini@redhat.com, qperret@google.com, serge@hallyn.com,
	tabba@google.com,  vannapurve@google.com, wei.w.wang@intel.com,
	willy@infradead.org,  yu.c.zhang@linux.intel.com
Subject: Re: [PATCH gmem FIXUP v2] mm, compaction: make testing mapping_unmovable() safe
Date: Fri,  8 Sep 2023 17:15:33 -0700	[thread overview]
Message-ID: <169421599820.98577.9267896589643015779.b4-ty@google.com> (raw)
In-Reply-To: <20230908074222.28723-2-vbabka@suse.cz>

On Fri, 08 Sep 2023 09:42:23 +0200, Vlastimil Babka wrote:
> As Kirill pointed out, mapping can be removed under us due to
> truncation. Test it under folio lock as already done for the async
> compaction / dirty folio case. To prevent locking every folio with
> mapping to do the test, do it only for unevictable folios, as we can
> expect the unmovable mapping folios are also unevictable. To enforce
> that expecation, make mapping_set_unmovable() also set AS_UNEVICTABLE.
> 
> [...]

Applied to kvm-x86 guest_memfd, thanks!

[1/1] mm, compaction: make testing mapping_unmovable() safe
      https://github.com/kvm-x86/linux/commit/4876a35647b9

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Vlastimil Babka <vbabka@suse.cz>
Cc: kvm@vger.kernel.org, david@redhat.com,
	yu.c.zhang@linux.intel.com, linux-mips@vger.kernel.org,
	linux-mm@kvack.org, pbonzini@redhat.com,
	chao.p.peng@linux.intel.com, linux-riscv@lists.infradead.org,
	isaku.yamahata@gmail.com, paul@paul-moore.com,
	anup@brainfault.org, chenhuacai@kernel.org, jmorris@namei.org,
	willy@infradead.org, wei.w.wang@intel.com, tabba@google.com,
	jarkko@kernel.org, serge@hallyn.com, mail@maciej.szmigiero.name,
	aou@eecs.berkeley.edu, michael.roth@amd.com,
	ackerleytng@google.com, paul.walmsley@sifive.com,
	kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	qperret@google.com, linux-kernel@vger.kernel.org,
	oliver.upton@linux.dev, linux-security-module@vger.kernel.org,
	palmer@dabbelt.com, kvm-riscv@lists.infradead.org,
	maz@kernel.org, linux-fsdevel@vger.kernel.org,
	liam.merwick@oracle.com, akpm@linux-foundation.org,
	vannapurve@google.com, linuxppc-dev@lists.ozlabs.org,
	kirill.shutemov@linux.intel.com
Subject: Re: [PATCH gmem FIXUP v2] mm, compaction: make testing mapping_unmovable() safe
Date: Fri,  8 Sep 2023 17:15:33 -0700	[thread overview]
Message-ID: <169421599820.98577.9267896589643015779.b4-ty@google.com> (raw)
In-Reply-To: <20230908074222.28723-2-vbabka@suse.cz>

On Fri, 08 Sep 2023 09:42:23 +0200, Vlastimil Babka wrote:
> As Kirill pointed out, mapping can be removed under us due to
> truncation. Test it under folio lock as already done for the async
> compaction / dirty folio case. To prevent locking every folio with
> mapping to do the test, do it only for unevictable folios, as we can
> expect the unmovable mapping folios are also unevictable. To enforce
> that expecation, make mapping_set_unmovable() also set AS_UNEVICTABLE.
> 
> [...]

Applied to kvm-x86 guest_memfd, thanks!

[1/1] mm, compaction: make testing mapping_unmovable() safe
      https://github.com/kvm-x86/linux/commit/4876a35647b9

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes

  reply	other threads:[~2023-09-09  0:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08  7:42 [PATCH gmem FIXUP v2] mm, compaction: make testing mapping_unmovable() safe Vlastimil Babka
2023-09-08  7:42 ` Vlastimil Babka
2023-09-08  7:42 ` Vlastimil Babka
2023-09-08  7:42 ` Vlastimil Babka
2023-09-09  0:15 ` Sean Christopherson [this message]
2023-09-09  0:15   ` Sean Christopherson
2023-09-09  0:15   ` Sean Christopherson
2023-09-09  0:15   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169421599820.98577.9267896589643015779.b4-ty@google.com \
    --to=seanjc@google.com \
    --cc=ackerleytng@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=chao.p.peng@linux.intel.com \
    --cc=chenhuacai@kernel.org \
    --cc=david@redhat.com \
    --cc=isaku.yamahata@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jmorris@namei.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=liam.merwick@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=maz@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mpe@ellerman.id.au \
    --cc=oliver.upton@linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paul@paul-moore.com \
    --cc=pbonzini@redhat.com \
    --cc=qperret@google.com \
    --cc=serge@hallyn.com \
    --cc=tabba@google.com \
    --cc=vannapurve@google.com \
    --cc=vbabka@suse.cz \
    --cc=wei.w.wang@intel.com \
    --cc=willy@infradead.org \
    --cc=yu.c.zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.