All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: arnd@arndb.de, dri-devel@lists.freedesktop.org,
	u.kleine-koenig@pengutronix.de,
	linux-rockchip@lists.infradead.org, daniel@ffwll.ch,
	linux-arm-kernel@lists.infradead.org, airlied@gmail.com,
	hjc@rock-chips.com, Zhu Wang <wangzhu9@huawei.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH -next] drm/rockchip: remove redundant of_match_ptr
Date: Mon,  9 Oct 2023 22:37:12 +0200	[thread overview]
Message-ID: <169688381987.192795.13711895828418269641.b4-ty@sntech.de> (raw)
In-Reply-To: <20230731125304.87059-1-wangzhu9@huawei.com>

On Mon, 31 Jul 2023 20:53:04 +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr here.
> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: remove redundant of_match_ptr
      commit: 63a06c9fe30bf84d1ab6f07d0e408bd1d4ccaf85

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: arnd@arndb.de, dri-devel@lists.freedesktop.org,
	u.kleine-koenig@pengutronix.de,
	linux-rockchip@lists.infradead.org, daniel@ffwll.ch,
	linux-arm-kernel@lists.infradead.org, airlied@gmail.com,
	hjc@rock-chips.com, Zhu Wang <wangzhu9@huawei.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH -next] drm/rockchip: remove redundant of_match_ptr
Date: Mon,  9 Oct 2023 22:37:12 +0200	[thread overview]
Message-ID: <169688381987.192795.13711895828418269641.b4-ty@sntech.de> (raw)
In-Reply-To: <20230731125304.87059-1-wangzhu9@huawei.com>

On Mon, 31 Jul 2023 20:53:04 +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr here.
> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: remove redundant of_match_ptr
      commit: 63a06c9fe30bf84d1ab6f07d0e408bd1d4ccaf85

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: arnd@arndb.de, dri-devel@lists.freedesktop.org,
	u.kleine-koenig@pengutronix.de,
	linux-rockchip@lists.infradead.org, daniel@ffwll.ch,
	linux-arm-kernel@lists.infradead.org, airlied@gmail.com,
	hjc@rock-chips.com, Zhu Wang <wangzhu9@huawei.com>
Subject: Re: [PATCH -next] drm/rockchip: remove redundant of_match_ptr
Date: Mon,  9 Oct 2023 22:37:12 +0200	[thread overview]
Message-ID: <169688381987.192795.13711895828418269641.b4-ty@sntech.de> (raw)
In-Reply-To: <20230731125304.87059-1-wangzhu9@huawei.com>

On Mon, 31 Jul 2023 20:53:04 +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr here.
> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: remove redundant of_match_ptr
      commit: 63a06c9fe30bf84d1ab6f07d0e408bd1d4ccaf85

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

  reply	other threads:[~2023-10-09 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 12:53 [PATCH -next] drm/rockchip: remove redundant of_match_ptr Zhu Wang
2023-07-31 12:53 ` Zhu Wang
2023-07-31 12:53 ` Zhu Wang
2023-10-09 20:37 ` Heiko Stuebner [this message]
2023-10-09 20:37   ` Heiko Stuebner
2023-10-09 20:37   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169688381987.192795.13711895828418269641.b4-ty@sntech.de \
    --to=heiko@sntech.de \
    --cc=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wangzhu9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.