Re: [PATCH v6] dt-bindings: gpio: aspeed,ast2400-gpio: Convert to DT schema

From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	 linus.walleij@linaro.org, brgl@bgdev.pl,
	krzysztof.kozlowski+dt@linaro.org
Cc: robh+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
	 linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] dt-bindings: gpio: aspeed,ast2400-gpio: Convert to DT schema
Date: Thu, 29 Feb 2024 13:51:45 +1030	[thread overview]
Message-ID: <16ddd99007176da3f84462de217cb76c8fa4e1bd.camel@codeconstruct.com.au> (raw)
In-Reply-To: <c2060450-4b76-4740-afe4-d14717245f01@linaro.org>

On Wed, 2024-02-28 at 08:47 +0100, Krzysztof Kozlowski wrote:
> On 28/02/2024 01:30, Andrew Jeffery wrote:
> > Squash warnings such as:
> > 
> > ```
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dtb: /ahb/apb@1e600000/gpio@1e780000: failed to match any schema with compatible: ['aspeed,ast2400-gpio']
> > ```
> > 
> > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> > ---
> > v6: Address more constraint feedback from Krzysztof:
> >     https://lore.kernel.org/all/f69ef2ad-8ace-40c8-b923-4dde20eda2ec@linaro.org/
> 
> You still have way too many examples. One is enough, two is still okay.
> We really do not want more of examples with minor differences.

Noted, I'll keep them to a minimum in the future.

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for the feedback.

Andrew