Re: [PATCH v3 2/8] dt-bindings: i3c: svc: add proptery mode

From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: conor.culhane@silvaco.com, linux-serial@vger.kernel.org,
	 zbigniew.lukwinski@linux.intel.com, joe@perches.com,
	imx@lists.linux.dev,  linux-kernel@vger.kernel.org,
	linux-i3c@lists.infradead.org,  frank.li@nxp.com,
	devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
	 alexandre.belloni@bootlin.com, gregkh@linuxfoundation.org,
	 jirislaby@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	 krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v3 2/8] dt-bindings: i3c: svc: add proptery mode
Date: Tue, 23 Jan 2024 16:38:20 -0600	[thread overview]
Message-ID: <170604949961.2185792.3557017002643301182.robh@kernel.org> (raw)
In-Reply-To: <20240123212549.3858137-3-Frank.Li@nxp.com>

On Tue, 23 Jan 2024 16:25:43 -0500, Frank Li wrote:
> Add proptery 'mode' to distinguish work at 'controller' or 'target' mode.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v2 to v3
>         - using 'mode' distringuish master and target mode
> 
>  .../devicetree/bindings/i3c/silvaco,i3c-master.yaml   | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:26:4: [warning] wrong indentation: expected 4 but found 3 (indentation)
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:30:9: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/i3c/silvaco,i3c-master.example.dts'
Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:30:9: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/i3c/silvaco,i3c-master.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:30:9: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240123212549.3858137-3-Frank.Li@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.