Re: [PATCH 0/4] Add support for Theobroma-Systems Tiger SoM

From: Rob Herring <robh@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: conor+dt@kernel.org, linux-rockchip@lists.infradead.org,
	 robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	 krzysztof.kozlowski+dt@linaro.org,
	quentin.schulz@theobroma-systems.com,
	 linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] Add support for Theobroma-Systems Tiger SoM
Date: Wed, 28 Feb 2024 07:46:16 -0600	[thread overview]
Message-ID: <170912782011.3288301.9840425544379703699.robh@kernel.org> (raw)
In-Reply-To: <20240227164659.705271-1-heiko@sntech.de>

On Tue, 27 Feb 2024 17:46:55 +0100, Heiko Stuebner wrote:
> This adds support for the rk3588-based Tiger system-on-module from
> Theobroma Systems and includes support for the combination with
> the Haikou-baseboard.
> 
> Included is also a fix for the rk3588's i2s nodes to remove a
> yet-unsupported devicetree property that slipped in.
> 
> 
> Heiko Stuebner (4):
>   arm64: dts: rockchip: drop rockchip,trcm-sync-tx-only from rk3588 i2s
>   dt-bindings: arm: rockchip: Add Theobroma-Systems RK3588 Q7 with
>     baseboard
>   arm64: dts: rockchip: add RK3588-Q7 (Tiger) SoM
>   arm64: dts: rockchip: add Haikou baseboard with RK3588-Q7 SoM
> 
>  .../devicetree/bindings/arm/rockchip.yaml     |   6 +
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 266 +++++++
>  .../arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 691 ++++++++++++++++++
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     |   2 -
>  5 files changed, 964 insertions(+), 2 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
> 
> --
> 2.39.2
> 
> 
> 

My bot found new DT warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3588-tiger-haikou.dtb' for 20240227164659.705271-1-heiko@sntech.de:

arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: syscon@fd5a8000: 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#