Re: [PATCH v2 20/22] ASoC: dt-bindings: mt8186: Document audio-routing and dai-link subnode

From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: matthias.bgg@gmail.com, eugen.hristev@collabora.com,
	 devicetree@vger.kernel.org, nfraprado@collabora.com,
	 claudiu.beznea@tuxon.dev,
	zhourui@huaqin.corp-partner.google.com,  broonie@kernel.org,
	wenst@chromium.org, dianders@chromium.org,
	 shane.chien@mediatek.com, linux-kernel@vger.kernel.org,
	lgirdwood@gmail.com,  allen-kh.cheng@mediatek.com,
	shraash@google.com, frank.li@vivo.com,  maso.huang@mediatek.com,
	perex@perex.cz, jiaxin.yu@mediatek.com,
	 linux-mediatek@lists.infradead.org,
	u.kleine-koenig@pengutronix.de,  alsa-devel@alsa-project.org,
	trevor.wu@mediatek.com,  nicolas.ferre@microchip.com,
	linux-sound@vger.kernel.org,  amergnat@baylibre.com,
	kernel@collabora.com, tiwai@suse.com,  jarkko.nikula@bitmer.com,
	linux-arm-kernel@lists.infradead.org,
	 kuninori.morimoto.gx@renesas.com,
	 xiazhengqiao@huaqin.corp-partner.google.com,
	ckeepax@opensource.cirrus.com,  alpernebiyasak@gmail.com,
	arnd@arndb.de, krzysztof.kozlowski+dt@linaro.org,
	 conor+dt@kernel.org
Subject: Re: [PATCH v2 20/22] ASoC: dt-bindings: mt8186: Document audio-routing and dai-link subnode
Date: Thu, 07 Mar 2024 07:38:54 -0600	[thread overview]
Message-ID: <170981873072.2495513.10220063572625307394.robh@kernel.org> (raw)
In-Reply-To: <20240307114445.196981-21-angelogioacchino.delregno@collabora.com>

On Thu, 07 Mar 2024 12:44:43 +0100, AngeloGioacchino Del Regno wrote:
> Document the dai-link subnodes and the audio-routing property, allowing
> to describe machine specific audio hardware and links in device tree.
> 
> While at it, also deprecate the old properties which were previously
> used with the driver's partially hardcoded configuration.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../sound/mt8186-mt6366-da7219-max98357.yaml  | 112 ++++++++++++++++--
>  .../sound/mt8186-mt6366-rt1019-rt5682s.yaml   | 102 ++++++++++++++--
>  2 files changed, 199 insertions(+), 15 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.example.dtb: mt8186-sound: 'model' does not match any of the regexes: '.*-dai-link$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240307114445.196981-21-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.