All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused
Date: Sun, 15 Nov 2020 15:12:01 -0800	[thread overview]
Message-ID: <176ba5be7e1a4cd5aa36c5e891a55728075135d0.camel@perches.com> (raw)
In-Reply-To: <20201113134938.4004947-2-lee.jones@linaro.org>

On Fri, 2020-11-13 at 13:48 +0000, Lee Jones wrote:
> This patch fixes nearly 400 warnings!
> 
> These structures are too widely used in too many varying
> configurations to be split-up into different headers or moved into
> source files.
> 
> Instead, we'll mark them as __maybe_unused which tells the compiler
> that we're aware they're being included into source files which do not
> make use of them - but we've looked into it, and it's okay.

https://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Type-Attributes.html#Type-Attributes

Wouldn't it be simpler to mark the struct definitions as maybe_unused
instead of the declarations?

And perhaps remove all the unnecessary zeroed declarations?

Something like this example?
---
 drivers/gpu/drm/amd/include/arct_ip_offset.h | 353 +++++++++++----------------
 1 file changed, 145 insertions(+), 208 deletions(-)

diff --git a/drivers/gpu/drm/amd/include/arct_ip_offset.h b/drivers/gpu/drm/amd/include/arct_ip_offset.h
index a7791a9e1f90..9f2d6b832dd9 100644
--- a/drivers/gpu/drm/amd/include/arct_ip_offset.h
+++ b/drivers/gpu/drm/amd/include/arct_ip_offset.h
@@ -33,215 +33,152 @@ struct IP_BASE_INSTANCE
 struct IP_BASE
 {
     struct IP_BASE_INSTANCE instance[MAX_INSTANCE];
-};
-
-
-static const struct IP_BASE ATHUB_BASE            ={ { { { 0x00000C20, 0x00012460, 0x00408C00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE CLK_BASE            ={ { { { 0x000120C0, 0x00016C00, 0x00401800, 0, 0, 0 } },
-                                        { { 0x000120E0, 0x00016E00, 0x00401C00, 0, 0, 0 } },
-                                        { { 0x00012100, 0x00017000, 0x00402000, 0, 0, 0 } },
-                                        { { 0x00012120, 0x00017200, 0x00402400, 0, 0, 0 } },
-                                        { { 0x000136C0, 0x0001B000, 0x0042D800, 0, 0, 0 } },
-                                        { { 0x00013720, 0x0001B200, 0x0042E400, 0, 0, 0 } },
-                                        { { 0x000125E0, 0x00017E00, 0x0040BC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE DF_BASE            ={ { { { 0x00007000, 0x000125C0, 0x0040B800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE FUSE_BASE            ={ { { { 0x000120A0, 0x00017400, 0x00401400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE GC_BASE            ={ { { { 0x00002000, 0x0000A000, 0x00012160, 0x00402C00, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE HDP_BASE            ={ { { { 0x00000F20, 0x00012520, 0x0040A400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MMHUB_BASE            ={ { { { 0x00012440, 0x0001A000, 0x00408800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP0_BASE            ={ { { { 0x00016000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP1_BASE            ={ { { { 0x00016000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE NBIF0_BASE            ={ { { { 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0x00012D80, 0x0041B000 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE OSSSYS_BASE            ={ { { { 0x000010A0, 0x00012500, 0x0040A000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE PCIE0_BASE            ={ { { { 0x000128C0, 0x00411800, 0x04440000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA0_BASE            ={ { { { 0x00001260, 0x00012540, 0x0040A800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA1_BASE            ={ { { { 0x00001860, 0x00012560, 0x0040AC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA2_BASE            ={ { { { 0x00013760, 0x0001E000, 0x0042EC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA3_BASE            ={ { { { 0x00013780, 0x0001E400, 0x0042F000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA4_BASE            ={ { { { 0x000137A0, 0x0001E800, 0x0042F400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA5_BASE            ={ { { { 0x000137C0, 0x0001EC00, 0x0042F800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA6_BASE            ={ { { { 0x000137E0, 0x0001F000, 0x0042FC00, 0, 0, 0 } },
-                                       { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA7_BASE            ={ { { { 0x00013800, 0x0001F400, 0x00430000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SMUIO_BASE            ={ { { { 0x00016800, 0x00016A00, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE THM_BASE            ={ { { { 0x00016600, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE UMC_BASE            ={ { { { 0x000132C0, 0x00014000, 0x00425800, 0, 0, 0 } },
-                                        { { 0x000132E0, 0x00054000, 0x00425C00, 0, 0, 0 } },
-                                        { { 0x00013300, 0x00094000, 0x00426000, 0, 0, 0 } },
-                                        { { 0x00013320, 0x000D4000, 0x00426400, 0, 0, 0 } },
-                                        { { 0x00013340, 0x00114000, 0x00426800, 0, 0, 0 } },
-                                        { { 0x00013360, 0x00154000, 0x00426C00, 0, 0, 0 } },
-                                        { { 0x00013380, 0x00194000, 0x00427000, 0, 0, 0 } },
-                                        { { 0x000133A0, 0x001D4000, 0x00427400, 0, 0, 0 } } } };
-static const struct IP_BASE UVD_BASE            ={ { { { 0x00007800, 0x00007E00, 0x00012180, 0x00403000, 0, 0 } },
-                                        { { 0x00007A00, 0x00009000, 0x000136E0, 0x0042DC00, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE DBGU_IO_BASE            ={ { { { 0x000001E0, 0x000125A0, 0x0040B400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE RSMU_BASE            ={ { { { 0x00012000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-
+} __maybe_unused;
 
+static const struct IP_BASE ATHUB_BASE = {
+	{
+		{{ 0x00000C20, 0x00012460, 0x00408C00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE CLK_BASE = {
+	{
+		{{ 0x000120C0, 0x00016C00, 0x00401800, 0, 0, 0 }},
+		{{ 0x000120E0, 0x00016E00, 0x00401C00, 0, 0, 0 }},
+		{{ 0x00012100, 0x00017000, 0x00402000, 0, 0, 0 }},
+		{{ 0x00012120, 0x00017200, 0x00402400, 0, 0, 0 }},
+		{{ 0x000136C0, 0x0001B000, 0x0042D800, 0, 0, 0 }},
+		{{ 0x00013720, 0x0001B200, 0x0042E400, 0, 0, 0 }},
+		{{ 0x000125E0, 0x00017E00, 0x0040BC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE DF_BASE = {
+	{
+		{{ 0x00007000, 0x000125C0, 0x0040B800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE FUSE_BASE = {
+	{
+		{{ 0x000120A0, 0x00017400, 0x00401400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE GC_BASE = {
+	{
+		{{ 0x00002000, 0x0000A000, 0x00012160, 0x00402C00, 0, 0 }},
+	}
+};
+static const struct IP_BASE HDP_BASE = {
+	{
+		{{ 0x00000F20, 0x00012520, 0x0040A400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MMHUB_BASE = {
+	{
+		{{ 0x00012440, 0x0001A000, 0x00408800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MP0_BASE = {
+	{
+		{{ 0x00016000, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MP1_BASE = {
+	{
+		{{ 0x00016000, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE NBIF0_BASE = {
+	{
+		{{ 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0x00012D80, 0x0041B000 }},
+	}
+};
+static const struct IP_BASE OSSSYS_BASE = {
+	{
+		{{ 0x000010A0, 0x00012500, 0x0040A000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE PCIE0_BASE = {
+	{
+		{{ 0x000128C0, 0x00411800, 0x04440000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA0_BASE = {
+	{
+		{{ 0x00001260, 0x00012540, 0x0040A800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA1_BASE = {
+	{
+		{{ 0x00001860, 0x00012560, 0x0040AC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA2_BASE = {
+	{
+		{{ 0x00013760, 0x0001E000, 0x0042EC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA3_BASE = {
+	{
+		{{ 0x00013780, 0x0001E400, 0x0042F000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA4_BASE = {
+	{
+		{{ 0x000137A0, 0x0001E800, 0x0042F400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA5_BASE = {
+	{
+		{{ 0x000137C0, 0x0001EC00, 0x0042F800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA6_BASE = {
+	{
+		{{ 0x000137E0, 0x0001F000, 0x0042FC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA7_BASE = {
+	{
+		{{ 0x00013800, 0x0001F400, 0x00430000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SMUIO_BASE = {
+	{
+		{{ 0x00016800, 0x00016A00, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE THM_BASE = {
+	{
+		{{ 0x00016600, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE UMC_BASE = {
+	{
+		{{ 0x000132C0, 0x00014000, 0x00425800, 0, 0, 0 }},
+		{{ 0x000132E0, 0x00054000, 0x00425C00, 0, 0, 0 }},
+		{{ 0x00013300, 0x00094000, 0x00426000, 0, 0, 0 }},
+		{{ 0x00013320, 0x000D4000, 0x00426400, 0, 0, 0 }},
+		{{ 0x00013340, 0x00114000, 0x00426800, 0, 0, 0 }},
+		{{ 0x00013360, 0x00154000, 0x00426C00, 0, 0, 0 }},
+		{{ 0x00013380, 0x00194000, 0x00427000, 0, 0, 0 }},
+		{{ 0x000133A0, 0x001D4000, 0x00427400, 0, 0, 0 }}
+	}
+};
+static const struct IP_BASE UVD_BASE = {
+	{
+		{{ 0x00007800, 0x00007E00, 0x00012180, 0x00403000, 0, 0 }},
+		{{ 0x00007A00, 0x00009000, 0x000136E0, 0x0042DC00, 0, 0 }},
+	}
+};
+static const struct IP_BASE DBGU_IO_BASE = {
+	{
+		{{ 0x000001E0, 0x000125A0, 0x0040B400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE RSMU_BASE = {
+	{
+		{{ 0x00012000, 0, 0, 0, 0, 0 }},
+	}
+};
 
 #define ATHUB_BASE__INST0_SEG0                     0x00000C20
 #define ATHUB_BASE__INST0_SEG1                     0x00012460


WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused
Date: Sun, 15 Nov 2020 15:12:01 -0800	[thread overview]
Message-ID: <176ba5be7e1a4cd5aa36c5e891a55728075135d0.camel@perches.com> (raw)
In-Reply-To: <20201113134938.4004947-2-lee.jones@linaro.org>

On Fri, 2020-11-13 at 13:48 +0000, Lee Jones wrote:
> This patch fixes nearly 400 warnings!
> 
> These structures are too widely used in too many varying
> configurations to be split-up into different headers or moved into
> source files.
> 
> Instead, we'll mark them as __maybe_unused which tells the compiler
> that we're aware they're being included into source files which do not
> make use of them - but we've looked into it, and it's okay.

https://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Type-Attributes.html#Type-Attributes

Wouldn't it be simpler to mark the struct definitions as maybe_unused
instead of the declarations?

And perhaps remove all the unnecessary zeroed declarations?

Something like this example?
---
 drivers/gpu/drm/amd/include/arct_ip_offset.h | 353 +++++++++++----------------
 1 file changed, 145 insertions(+), 208 deletions(-)

diff --git a/drivers/gpu/drm/amd/include/arct_ip_offset.h b/drivers/gpu/drm/amd/include/arct_ip_offset.h
index a7791a9e1f90..9f2d6b832dd9 100644
--- a/drivers/gpu/drm/amd/include/arct_ip_offset.h
+++ b/drivers/gpu/drm/amd/include/arct_ip_offset.h
@@ -33,215 +33,152 @@ struct IP_BASE_INSTANCE
 struct IP_BASE
 {
     struct IP_BASE_INSTANCE instance[MAX_INSTANCE];
-};
-
-
-static const struct IP_BASE ATHUB_BASE            ={ { { { 0x00000C20, 0x00012460, 0x00408C00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE CLK_BASE            ={ { { { 0x000120C0, 0x00016C00, 0x00401800, 0, 0, 0 } },
-                                        { { 0x000120E0, 0x00016E00, 0x00401C00, 0, 0, 0 } },
-                                        { { 0x00012100, 0x00017000, 0x00402000, 0, 0, 0 } },
-                                        { { 0x00012120, 0x00017200, 0x00402400, 0, 0, 0 } },
-                                        { { 0x000136C0, 0x0001B000, 0x0042D800, 0, 0, 0 } },
-                                        { { 0x00013720, 0x0001B200, 0x0042E400, 0, 0, 0 } },
-                                        { { 0x000125E0, 0x00017E00, 0x0040BC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE DF_BASE            ={ { { { 0x00007000, 0x000125C0, 0x0040B800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE FUSE_BASE            ={ { { { 0x000120A0, 0x00017400, 0x00401400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE GC_BASE            ={ { { { 0x00002000, 0x0000A000, 0x00012160, 0x00402C00, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE HDP_BASE            ={ { { { 0x00000F20, 0x00012520, 0x0040A400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MMHUB_BASE            ={ { { { 0x00012440, 0x0001A000, 0x00408800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP0_BASE            ={ { { { 0x00016000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP1_BASE            ={ { { { 0x00016000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE NBIF0_BASE            ={ { { { 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0x00012D80, 0x0041B000 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE OSSSYS_BASE            ={ { { { 0x000010A0, 0x00012500, 0x0040A000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE PCIE0_BASE            ={ { { { 0x000128C0, 0x00411800, 0x04440000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA0_BASE            ={ { { { 0x00001260, 0x00012540, 0x0040A800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA1_BASE            ={ { { { 0x00001860, 0x00012560, 0x0040AC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA2_BASE            ={ { { { 0x00013760, 0x0001E000, 0x0042EC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA3_BASE            ={ { { { 0x00013780, 0x0001E400, 0x0042F000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA4_BASE            ={ { { { 0x000137A0, 0x0001E800, 0x0042F400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA5_BASE            ={ { { { 0x000137C0, 0x0001EC00, 0x0042F800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA6_BASE            ={ { { { 0x000137E0, 0x0001F000, 0x0042FC00, 0, 0, 0 } },
-                                       { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA7_BASE            ={ { { { 0x00013800, 0x0001F400, 0x00430000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SMUIO_BASE            ={ { { { 0x00016800, 0x00016A00, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE THM_BASE            ={ { { { 0x00016600, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE UMC_BASE            ={ { { { 0x000132C0, 0x00014000, 0x00425800, 0, 0, 0 } },
-                                        { { 0x000132E0, 0x00054000, 0x00425C00, 0, 0, 0 } },
-                                        { { 0x00013300, 0x00094000, 0x00426000, 0, 0, 0 } },
-                                        { { 0x00013320, 0x000D4000, 0x00426400, 0, 0, 0 } },
-                                        { { 0x00013340, 0x00114000, 0x00426800, 0, 0, 0 } },
-                                        { { 0x00013360, 0x00154000, 0x00426C00, 0, 0, 0 } },
-                                        { { 0x00013380, 0x00194000, 0x00427000, 0, 0, 0 } },
-                                        { { 0x000133A0, 0x001D4000, 0x00427400, 0, 0, 0 } } } };
-static const struct IP_BASE UVD_BASE            ={ { { { 0x00007800, 0x00007E00, 0x00012180, 0x00403000, 0, 0 } },
-                                        { { 0x00007A00, 0x00009000, 0x000136E0, 0x0042DC00, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE DBGU_IO_BASE            ={ { { { 0x000001E0, 0x000125A0, 0x0040B400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE RSMU_BASE            ={ { { { 0x00012000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-
+} __maybe_unused;
 
+static const struct IP_BASE ATHUB_BASE = {
+	{
+		{{ 0x00000C20, 0x00012460, 0x00408C00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE CLK_BASE = {
+	{
+		{{ 0x000120C0, 0x00016C00, 0x00401800, 0, 0, 0 }},
+		{{ 0x000120E0, 0x00016E00, 0x00401C00, 0, 0, 0 }},
+		{{ 0x00012100, 0x00017000, 0x00402000, 0, 0, 0 }},
+		{{ 0x00012120, 0x00017200, 0x00402400, 0, 0, 0 }},
+		{{ 0x000136C0, 0x0001B000, 0x0042D800, 0, 0, 0 }},
+		{{ 0x00013720, 0x0001B200, 0x0042E400, 0, 0, 0 }},
+		{{ 0x000125E0, 0x00017E00, 0x0040BC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE DF_BASE = {
+	{
+		{{ 0x00007000, 0x000125C0, 0x0040B800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE FUSE_BASE = {
+	{
+		{{ 0x000120A0, 0x00017400, 0x00401400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE GC_BASE = {
+	{
+		{{ 0x00002000, 0x0000A000, 0x00012160, 0x00402C00, 0, 0 }},
+	}
+};
+static const struct IP_BASE HDP_BASE = {
+	{
+		{{ 0x00000F20, 0x00012520, 0x0040A400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MMHUB_BASE = {
+	{
+		{{ 0x00012440, 0x0001A000, 0x00408800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MP0_BASE = {
+	{
+		{{ 0x00016000, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MP1_BASE = {
+	{
+		{{ 0x00016000, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE NBIF0_BASE = {
+	{
+		{{ 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0x00012D80, 0x0041B000 }},
+	}
+};
+static const struct IP_BASE OSSSYS_BASE = {
+	{
+		{{ 0x000010A0, 0x00012500, 0x0040A000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE PCIE0_BASE = {
+	{
+		{{ 0x000128C0, 0x00411800, 0x04440000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA0_BASE = {
+	{
+		{{ 0x00001260, 0x00012540, 0x0040A800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA1_BASE = {
+	{
+		{{ 0x00001860, 0x00012560, 0x0040AC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA2_BASE = {
+	{
+		{{ 0x00013760, 0x0001E000, 0x0042EC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA3_BASE = {
+	{
+		{{ 0x00013780, 0x0001E400, 0x0042F000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA4_BASE = {
+	{
+		{{ 0x000137A0, 0x0001E800, 0x0042F400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA5_BASE = {
+	{
+		{{ 0x000137C0, 0x0001EC00, 0x0042F800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA6_BASE = {
+	{
+		{{ 0x000137E0, 0x0001F000, 0x0042FC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA7_BASE = {
+	{
+		{{ 0x00013800, 0x0001F400, 0x00430000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SMUIO_BASE = {
+	{
+		{{ 0x00016800, 0x00016A00, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE THM_BASE = {
+	{
+		{{ 0x00016600, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE UMC_BASE = {
+	{
+		{{ 0x000132C0, 0x00014000, 0x00425800, 0, 0, 0 }},
+		{{ 0x000132E0, 0x00054000, 0x00425C00, 0, 0, 0 }},
+		{{ 0x00013300, 0x00094000, 0x00426000, 0, 0, 0 }},
+		{{ 0x00013320, 0x000D4000, 0x00426400, 0, 0, 0 }},
+		{{ 0x00013340, 0x00114000, 0x00426800, 0, 0, 0 }},
+		{{ 0x00013360, 0x00154000, 0x00426C00, 0, 0, 0 }},
+		{{ 0x00013380, 0x00194000, 0x00427000, 0, 0, 0 }},
+		{{ 0x000133A0, 0x001D4000, 0x00427400, 0, 0, 0 }}
+	}
+};
+static const struct IP_BASE UVD_BASE = {
+	{
+		{{ 0x00007800, 0x00007E00, 0x00012180, 0x00403000, 0, 0 }},
+		{{ 0x00007A00, 0x00009000, 0x000136E0, 0x0042DC00, 0, 0 }},
+	}
+};
+static const struct IP_BASE DBGU_IO_BASE = {
+	{
+		{{ 0x000001E0, 0x000125A0, 0x0040B400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE RSMU_BASE = {
+	{
+		{{ 0x00012000, 0, 0, 0, 0, 0 }},
+	}
+};
 
 #define ATHUB_BASE__INST0_SEG0                     0x00000C20
 #define ATHUB_BASE__INST0_SEG1                     0x00012460

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused
Date: Sun, 15 Nov 2020 15:12:01 -0800	[thread overview]
Message-ID: <176ba5be7e1a4cd5aa36c5e891a55728075135d0.camel@perches.com> (raw)
In-Reply-To: <20201113134938.4004947-2-lee.jones@linaro.org>

On Fri, 2020-11-13 at 13:48 +0000, Lee Jones wrote:
> This patch fixes nearly 400 warnings!
> 
> These structures are too widely used in too many varying
> configurations to be split-up into different headers or moved into
> source files.
> 
> Instead, we'll mark them as __maybe_unused which tells the compiler
> that we're aware they're being included into source files which do not
> make use of them - but we've looked into it, and it's okay.

https://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Type-Attributes.html#Type-Attributes

Wouldn't it be simpler to mark the struct definitions as maybe_unused
instead of the declarations?

And perhaps remove all the unnecessary zeroed declarations?

Something like this example?
---
 drivers/gpu/drm/amd/include/arct_ip_offset.h | 353 +++++++++++----------------
 1 file changed, 145 insertions(+), 208 deletions(-)

diff --git a/drivers/gpu/drm/amd/include/arct_ip_offset.h b/drivers/gpu/drm/amd/include/arct_ip_offset.h
index a7791a9e1f90..9f2d6b832dd9 100644
--- a/drivers/gpu/drm/amd/include/arct_ip_offset.h
+++ b/drivers/gpu/drm/amd/include/arct_ip_offset.h
@@ -33,215 +33,152 @@ struct IP_BASE_INSTANCE
 struct IP_BASE
 {
     struct IP_BASE_INSTANCE instance[MAX_INSTANCE];
-};
-
-
-static const struct IP_BASE ATHUB_BASE            ={ { { { 0x00000C20, 0x00012460, 0x00408C00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE CLK_BASE            ={ { { { 0x000120C0, 0x00016C00, 0x00401800, 0, 0, 0 } },
-                                        { { 0x000120E0, 0x00016E00, 0x00401C00, 0, 0, 0 } },
-                                        { { 0x00012100, 0x00017000, 0x00402000, 0, 0, 0 } },
-                                        { { 0x00012120, 0x00017200, 0x00402400, 0, 0, 0 } },
-                                        { { 0x000136C0, 0x0001B000, 0x0042D800, 0, 0, 0 } },
-                                        { { 0x00013720, 0x0001B200, 0x0042E400, 0, 0, 0 } },
-                                        { { 0x000125E0, 0x00017E00, 0x0040BC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE DF_BASE            ={ { { { 0x00007000, 0x000125C0, 0x0040B800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE FUSE_BASE            ={ { { { 0x000120A0, 0x00017400, 0x00401400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE GC_BASE            ={ { { { 0x00002000, 0x0000A000, 0x00012160, 0x00402C00, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE HDP_BASE            ={ { { { 0x00000F20, 0x00012520, 0x0040A400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MMHUB_BASE            ={ { { { 0x00012440, 0x0001A000, 0x00408800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP0_BASE            ={ { { { 0x00016000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP1_BASE            ={ { { { 0x00016000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE NBIF0_BASE            ={ { { { 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0x00012D80, 0x0041B000 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE OSSSYS_BASE            ={ { { { 0x000010A0, 0x00012500, 0x0040A000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE PCIE0_BASE            ={ { { { 0x000128C0, 0x00411800, 0x04440000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA0_BASE            ={ { { { 0x00001260, 0x00012540, 0x0040A800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA1_BASE            ={ { { { 0x00001860, 0x00012560, 0x0040AC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA2_BASE            ={ { { { 0x00013760, 0x0001E000, 0x0042EC00, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA3_BASE            ={ { { { 0x00013780, 0x0001E400, 0x0042F000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA4_BASE            ={ { { { 0x000137A0, 0x0001E800, 0x0042F400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA5_BASE            ={ { { { 0x000137C0, 0x0001EC00, 0x0042F800, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA6_BASE            ={ { { { 0x000137E0, 0x0001F000, 0x0042FC00, 0, 0, 0 } },
-                                       { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SDMA7_BASE            ={ { { { 0x00013800, 0x0001F400, 0x00430000, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE SMUIO_BASE            ={ { { { 0x00016800, 0x00016A00, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE THM_BASE            ={ { { { 0x00016600, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE UMC_BASE            ={ { { { 0x000132C0, 0x00014000, 0x00425800, 0, 0, 0 } },
-                                        { { 0x000132E0, 0x00054000, 0x00425C00, 0, 0, 0 } },
-                                        { { 0x00013300, 0x00094000, 0x00426000, 0, 0, 0 } },
-                                        { { 0x00013320, 0x000D4000, 0x00426400, 0, 0, 0 } },
-                                        { { 0x00013340, 0x00114000, 0x00426800, 0, 0, 0 } },
-                                        { { 0x00013360, 0x00154000, 0x00426C00, 0, 0, 0 } },
-                                        { { 0x00013380, 0x00194000, 0x00427000, 0, 0, 0 } },
-                                        { { 0x000133A0, 0x001D4000, 0x00427400, 0, 0, 0 } } } };
-static const struct IP_BASE UVD_BASE            ={ { { { 0x00007800, 0x00007E00, 0x00012180, 0x00403000, 0, 0 } },
-                                        { { 0x00007A00, 0x00009000, 0x000136E0, 0x0042DC00, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE DBGU_IO_BASE            ={ { { { 0x000001E0, 0x000125A0, 0x0040B400, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE RSMU_BASE            ={ { { { 0x00012000, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } },
-                                        { { 0, 0, 0, 0, 0, 0 } } } };
-
+} __maybe_unused;
 
+static const struct IP_BASE ATHUB_BASE = {
+	{
+		{{ 0x00000C20, 0x00012460, 0x00408C00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE CLK_BASE = {
+	{
+		{{ 0x000120C0, 0x00016C00, 0x00401800, 0, 0, 0 }},
+		{{ 0x000120E0, 0x00016E00, 0x00401C00, 0, 0, 0 }},
+		{{ 0x00012100, 0x00017000, 0x00402000, 0, 0, 0 }},
+		{{ 0x00012120, 0x00017200, 0x00402400, 0, 0, 0 }},
+		{{ 0x000136C0, 0x0001B000, 0x0042D800, 0, 0, 0 }},
+		{{ 0x00013720, 0x0001B200, 0x0042E400, 0, 0, 0 }},
+		{{ 0x000125E0, 0x00017E00, 0x0040BC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE DF_BASE = {
+	{
+		{{ 0x00007000, 0x000125C0, 0x0040B800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE FUSE_BASE = {
+	{
+		{{ 0x000120A0, 0x00017400, 0x00401400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE GC_BASE = {
+	{
+		{{ 0x00002000, 0x0000A000, 0x00012160, 0x00402C00, 0, 0 }},
+	}
+};
+static const struct IP_BASE HDP_BASE = {
+	{
+		{{ 0x00000F20, 0x00012520, 0x0040A400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MMHUB_BASE = {
+	{
+		{{ 0x00012440, 0x0001A000, 0x00408800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MP0_BASE = {
+	{
+		{{ 0x00016000, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE MP1_BASE = {
+	{
+		{{ 0x00016000, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE NBIF0_BASE = {
+	{
+		{{ 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0x00012D80, 0x0041B000 }},
+	}
+};
+static const struct IP_BASE OSSSYS_BASE = {
+	{
+		{{ 0x000010A0, 0x00012500, 0x0040A000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE PCIE0_BASE = {
+	{
+		{{ 0x000128C0, 0x00411800, 0x04440000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA0_BASE = {
+	{
+		{{ 0x00001260, 0x00012540, 0x0040A800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA1_BASE = {
+	{
+		{{ 0x00001860, 0x00012560, 0x0040AC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA2_BASE = {
+	{
+		{{ 0x00013760, 0x0001E000, 0x0042EC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA3_BASE = {
+	{
+		{{ 0x00013780, 0x0001E400, 0x0042F000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA4_BASE = {
+	{
+		{{ 0x000137A0, 0x0001E800, 0x0042F400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA5_BASE = {
+	{
+		{{ 0x000137C0, 0x0001EC00, 0x0042F800, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA6_BASE = {
+	{
+		{{ 0x000137E0, 0x0001F000, 0x0042FC00, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SDMA7_BASE = {
+	{
+		{{ 0x00013800, 0x0001F400, 0x00430000, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE SMUIO_BASE = {
+	{
+		{{ 0x00016800, 0x00016A00, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE THM_BASE = {
+	{
+		{{ 0x00016600, 0, 0, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE UMC_BASE = {
+	{
+		{{ 0x000132C0, 0x00014000, 0x00425800, 0, 0, 0 }},
+		{{ 0x000132E0, 0x00054000, 0x00425C00, 0, 0, 0 }},
+		{{ 0x00013300, 0x00094000, 0x00426000, 0, 0, 0 }},
+		{{ 0x00013320, 0x000D4000, 0x00426400, 0, 0, 0 }},
+		{{ 0x00013340, 0x00114000, 0x00426800, 0, 0, 0 }},
+		{{ 0x00013360, 0x00154000, 0x00426C00, 0, 0, 0 }},
+		{{ 0x00013380, 0x00194000, 0x00427000, 0, 0, 0 }},
+		{{ 0x000133A0, 0x001D4000, 0x00427400, 0, 0, 0 }}
+	}
+};
+static const struct IP_BASE UVD_BASE = {
+	{
+		{{ 0x00007800, 0x00007E00, 0x00012180, 0x00403000, 0, 0 }},
+		{{ 0x00007A00, 0x00009000, 0x000136E0, 0x0042DC00, 0, 0 }},
+	}
+};
+static const struct IP_BASE DBGU_IO_BASE = {
+	{
+		{{ 0x000001E0, 0x000125A0, 0x0040B400, 0, 0, 0 }},
+	}
+};
+static const struct IP_BASE RSMU_BASE = {
+	{
+		{{ 0x00012000, 0, 0, 0, 0, 0 }},
+	}
+};
 
 #define ATHUB_BASE__INST0_SEG0                     0x00000C20
 #define ATHUB_BASE__INST0_SEG1                     0x00012460

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2020-11-15 23:12 UTC|newest]

Thread overview: 246+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 13:48 [PATCH 00/40] [Set 7] Rid W=1 warnings from GPU Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused Lee Jones
2020-11-13 13:48   ` Lee Jones
2020-11-13 13:48   ` Lee Jones
2020-11-13 15:16   ` Alex Deucher
2020-11-13 15:16     ` Alex Deucher
2020-11-13 15:16     ` Alex Deucher
2020-11-15 23:12   ` Joe Perches [this message]
2020-11-15 23:12     ` Joe Perches
2020-11-15 23:12     ` Joe Perches
2020-11-13 13:49 ` [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2,3} to where they're used Lee Jones
2020-11-13 13:49   ` [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2, 3} " Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:23   ` Alex Deucher
2020-11-13 15:23     ` Alex Deucher
2020-11-13 15:23     ` Alex Deucher
2020-11-13 15:26     ` Alex Deucher
2020-11-13 15:26       ` Alex Deucher
2020-11-13 15:26       ` Alex Deucher
2020-11-13 15:45     ` Lee Jones
2020-11-13 15:45       ` Lee Jones
2020-11-13 15:45       ` Lee Jones
2020-11-13 15:27   ` Alex Deucher
2020-11-13 15:27     ` Alex Deucher
2020-11-13 15:27     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 03/40] drm/amd/display/dc/core/dc_link_ddc: Move DP_DVI_CONVERTER_ID_{4,5} " Lee Jones
2020-11-13 13:49   ` [PATCH 03/40] drm/amd/display/dc/core/dc_link_ddc: Move DP_DVI_CONVERTER_ID_{4, 5} " Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:28   ` Alex Deucher
2020-11-13 15:28     ` Alex Deucher
2020-11-13 15:28     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 04/40] drm/amd/amdgpu/amdgpu_drv: Move 'amdgpu_info_ioctl()'s prototype to shared header Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:44   ` Alex Deucher
2020-11-13 15:44     ` Alex Deucher
2020-11-13 15:44     ` Alex Deucher
2020-11-18 10:24     ` Lee Jones
2020-11-18 10:24       ` Lee Jones
2020-11-18 10:24       ` Lee Jones
2020-11-13 13:49 ` [PATCH 05/40] drm/amd/amdgpu/amdgpu_ring: Fix misnaming of param 'max_dw' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:12   ` Alex Deucher
2020-11-13 17:12     ` Alex Deucher
2020-11-13 17:12     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 06/40] drm/msm/adreno/a6xx_gpu: Staticise local function 'a6xx_idle' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:30   ` [Freedreno] " Jordan Crouse
2020-11-13 15:30     ` Jordan Crouse
2020-11-13 13:49 ` [PATCH 07/40] drm/mediatek/mtk_disp_rdma: Fix formatting and supply missing struct member description Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-23 14:30   ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-13 13:49 ` [PATCH 08/40] drm/amd/amdgpu/amdgpu_ib: Fix some incorrect/incomplete function documentation Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:16   ` Alex Deucher
2020-11-13 17:16     ` Alex Deucher
2020-11-13 17:16     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 09/40] drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 10/40] drm/mediatek/mtk_drm_drv: Staticise local function invoked by reference Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-23 14:30   ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-13 13:49 ` [PATCH 11/40] drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and extra params Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:17   ` Alex Deucher
2020-11-13 17:17     ` Alex Deucher
2020-11-13 17:17     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 12/40] drm/pl111/pl111_display: Make local function static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-14 19:11   ` Sam Ravnborg
2020-11-14 19:11     ` Sam Ravnborg
2020-11-16  8:40     ` Lee Jones
2020-11-16  8:40       ` Lee Jones
2020-11-16 10:17       ` Sam Ravnborg
2020-11-16 10:17         ` Sam Ravnborg
2020-11-16 10:25         ` Lee Jones
2020-11-16 10:25           ` Lee Jones
2020-11-16 11:18           ` Sam Ravnborg
2020-11-16 11:18             ` Sam Ravnborg
2020-11-13 13:49 ` [PATCH 13/40] drm/panel/panel-tpo-tpg110: Correct misnaming and supply missing param description Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-14 19:27   ` Sam Ravnborg
2020-11-14 19:27     ` Sam Ravnborg
2020-11-13 13:49 ` [PATCH 14/40] drm/meson/meson_venc: Make local function 'meson_venc_hdmi_get_dmt_vmode' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  8:48   ` Neil Armstrong
2020-11-16  8:48     ` Neil Armstrong
2020-11-16  8:48     ` Neil Armstrong
2020-11-16  8:48     ` Neil Armstrong
2020-11-13 13:49 ` [PATCH 15/40] drm/lima/lima_drv: Demote kernel-doc formatting abuse Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  0:24   ` Qiang Yu
2020-11-16  0:24     ` Qiang Yu
2020-11-13 13:49 ` [PATCH 16/40] drm/amd/amdgpu/amdgpu_sync: Fix misnamed, missing and extra param descriptions Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:18   ` Alex Deucher
2020-11-13 17:18     ` Alex Deucher
2020-11-13 17:18     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 17/40] drm/meson/meson_vclk: Make two local functions static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  8:49   ` Neil Armstrong
2020-11-16  8:49     ` Neil Armstrong
2020-11-16  8:49     ` Neil Armstrong
2020-11-16  8:49     ` Neil Armstrong
2020-11-13 13:49 ` [PATCH 18/40] drm/mediatek/mtk_dpi: Remove unused struct definition 'mtk_dpi_encoder_funcs' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-23 14:36   ` Chun-Kuang Hu
2020-11-23 14:36     ` Chun-Kuang Hu
2020-11-23 14:36     ` Chun-Kuang Hu
2020-11-23 14:36     ` Chun-Kuang Hu
2020-11-13 13:49 ` [PATCH 19/40] drm/amd/amdgpu/amdgpu_vram_mgr: Add missing descriptions for 'dev' and 'dir' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:20   ` Alex Deucher
2020-11-13 17:20     ` Alex Deucher
2020-11-13 17:20     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 20/40] drm/pl111/pl111_debugfs: Make local function 'pl111_debugfs_regs()' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 21/40] drm/amd/amdgpu/amdgpu_virt: Make local function 'amdgpu_virt_update_vf2pf_work_item()' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:21   ` Alex Deucher
2020-11-13 17:21     ` Alex Deucher
2020-11-13 17:21     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 22/40] drm/amd/amdgpu/amdgpu_sched: Consume our own header containing prototypes Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:24   ` Alex Deucher
2020-11-13 17:24     ` Alex Deucher
2020-11-13 17:24     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 23/40] drm/lima/lima_sched: Remove unused and unnecessary variable 'ret' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  0:24   ` Qiang Yu
2020-11-16  0:24     ` Qiang Yu
2020-11-13 13:49 ` [PATCH 24/40] drm/amd/amdgpu/amdgpu_ids: Supply missing docs for 'id' and 'vmhub' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:26   ` Alex Deucher
2020-11-13 17:26     ` Alex Deucher
2020-11-13 17:26     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 25/40] drm/amd/amdgpu/amdgpu_debugfs: Demote obvious abuse of kernel-doc formatting Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:27   ` Alex Deucher
2020-11-13 17:27     ` Alex Deucher
2020-11-13 17:27     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:28   ` Alex Deucher
2020-11-13 17:28     ` Alex Deucher
2020-11-13 17:28     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 27/40] drm/amd/amdgpu/amdgpu_ras: Remove unused function 'amdgpu_ras_error_cure' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:29   ` Alex Deucher
2020-11-13 17:29     ` Alex Deucher
2020-11-13 17:29     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 28/40] drm/amd/amdgpu/amdgpu_ras: Make local function 'amdgpu_ras_error_status_query' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 29/40] drm/amd/amdgpu/amdgpu_csa: Remove set but unused variable 'r' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:23   ` Alex Deucher
2020-11-13 17:23     ` Alex Deucher
2020-11-13 17:23     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 30/40] drm/amd/amdgpu/amdgpu_vm_cpu: Fix 'amdgpu_vm_cpu_prepare()'s doc-rot Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:31   ` Alex Deucher
2020-11-13 17:31     ` Alex Deucher
2020-11-13 17:31     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 31/40] drm/amd/amdgpu/amdgpu_vm_sdma: Fix 'amdgpu_vm_sdma_prepare()'s doc-rot Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:32   ` Alex Deucher
2020-11-13 17:32     ` Alex Deucher
2020-11-13 17:32     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 32/40] drm/msm/disp/mdp5/mdp5_crtc: Make local function 'mdp5_crtc_setup_pipeline()' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:43   ` abhinavk
2020-11-13 19:43     ` abhinavk
2020-11-13 13:49 ` [PATCH 33/40] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 34/40] drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:45   ` [Freedreno] " abhinavk
2020-11-13 19:45     ` abhinavk
2020-11-13 13:49 ` [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en,dis}able()' static Lee Jones
2020-11-13 13:49   ` [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en, dis}able()' static Lee Jones
2020-11-13 19:46   ` abhinavk
2020-11-13 19:46     ` abhinavk
2020-11-13 13:49 ` [PATCH 36/40] drm/amd/amdgpu/amdgpu_fw_attestation: Consume our own header containing prototypes Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:33   ` Alex Deucher
2020-11-13 17:33     ` Alex Deucher
2020-11-13 17:33     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 37/40] drm/amd/amdgpu/smu_v11_0_i2c: Provide descriptions for 'control' and 'data' params Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:34   ` Alex Deucher
2020-11-13 17:34     ` Alex Deucher
2020-11-13 17:34     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 38/40] drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable 'dpu_cstate' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:42   ` [Freedreno] " abhinavk
2020-11-13 19:42     ` abhinavk
2020-11-13 13:49 ` [PATCH 39/40] drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:42   ` [Freedreno] " abhinavk
2020-11-13 19:42     ` abhinavk
2020-11-13 13:49 ` [PATCH 40/40] drm/amd/amdgpu/gfx_v7_0: Remove unused struct definition Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:35   ` Alex Deucher
2020-11-13 17:35     ` Alex Deucher
2020-11-13 17:35     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176ba5be7e1a4cd5aa36c5e891a55728075135d0.camel@perches.com \
    --to=joe@perches.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.