From: "Heiko Stübner" <heiko@sntech.de>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-rockchip@lists.infradead.org, zhengxing@rock-chips.com,
mturquette@baylibre.com, sboyd@codeaurora.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: rockchip: mark aclk_emmc_noc as a critical clock on rk3399
Date: Thu, 25 Aug 2016 00:25:03 +0200 [thread overview]
Message-ID: <1770264.XeNEc6mIDD@diego> (raw)
In-Reply-To: <1472063379-717-1-git-send-email-dianders@chromium.org>
Am Mittwoch, 24. August 2016, 11:29:39 schrieb Douglas Anderson:
> From: Xing Zheng <zhengxing@rock-chips.com>
>
> We don't have code to handle any of the noc clocks in rk3399 and they're
> all just listed as critical clocks. Let's do the same for
> aclk_emmc_noc.
>
> Without this clock being marked as critical we have problems around
> suspend/resume after commit 20c389e656a8 ("clk: rockchip: fix incorrect
> aclk_emmc source gate bits on rk3399"). Before that change we were
> presumably not actually gating any of these clocks because we were
> setting the wrong gate.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
applied to my clk-fixes branch
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: mark aclk_emmc_noc as a critical clock on rk3399
Date: Thu, 25 Aug 2016 00:25:03 +0200 [thread overview]
Message-ID: <1770264.XeNEc6mIDD@diego> (raw)
In-Reply-To: <1472063379-717-1-git-send-email-dianders@chromium.org>
Am Mittwoch, 24. August 2016, 11:29:39 schrieb Douglas Anderson:
> From: Xing Zheng <zhengxing@rock-chips.com>
>
> We don't have code to handle any of the noc clocks in rk3399 and they're
> all just listed as critical clocks. Let's do the same for
> aclk_emmc_noc.
>
> Without this clock being marked as critical we have problems around
> suspend/resume after commit 20c389e656a8 ("clk: rockchip: fix incorrect
> aclk_emmc source gate bits on rk3399"). Before that change we were
> presumably not actually gating any of these clocks because we were
> setting the wrong gate.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
applied to my clk-fixes branch
Thanks
Heiko
next prev parent reply other threads:[~2016-08-24 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 18:29 [PATCH] clk: rockchip: mark aclk_emmc_noc as a critical clock on rk3399 Douglas Anderson
2016-08-24 18:29 ` Douglas Anderson
2016-08-24 22:25 ` Heiko Stübner [this message]
2016-08-24 22:25 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1770264.XeNEc6mIDD@diego \
--to=heiko@sntech.de \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.