From: "Heiko Stübner" <heiko@sntech.de>
To: linus.walleij@linaro.org, robh+dt@kernel.org,
Jianqun Xu <jay.xu@rock-chips.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com>
Subject: Re: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
Date: Thu, 20 May 2021 01:26:42 +0200 [thread overview]
Message-ID: <1817539.g5d078U9FE@diego> (raw)
In-Reply-To: <20210510063734.506063-1-jay.xu@rock-chips.com>
Am Montag, 10. Mai 2021, 08:37:34 CEST schrieb Jianqun Xu:
> There has spin lock for irq set type already, so drop irq_gc_lock and
> irq_gc_unlock.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
I've looked that up, and yes the irq_gc_lock stuff really seems to be
redundant when there is already another spinlock in place, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linus.walleij@linaro.org, robh+dt@kernel.org,
Jianqun Xu <jay.xu@rock-chips.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com>
Subject: Re: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
Date: Thu, 20 May 2021 01:26:42 +0200 [thread overview]
Message-ID: <1817539.g5d078U9FE@diego> (raw)
In-Reply-To: <20210510063734.506063-1-jay.xu@rock-chips.com>
Am Montag, 10. Mai 2021, 08:37:34 CEST schrieb Jianqun Xu:
> There has spin lock for irq set type already, so drop irq_gc_lock and
> irq_gc_unlock.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
I've looked that up, and yes the irq_gc_lock stuff really seems to be
redundant when there is already another spinlock in place, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-05-19 23:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 6:35 [PATCH v4 0/7] gpio-rockchip driver Jianqun Xu
2021-05-10 6:35 ` Jianqun Xu
2021-05-10 6:35 ` [PATCH 1/7] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file Jianqun Xu
2021-05-10 6:35 ` Jianqun Xu
2021-05-24 23:55 ` Linus Walleij
2021-05-24 23:55 ` Linus Walleij
2021-05-10 6:35 ` [PATCH 2/7] pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct Jianqun Xu
2021-05-10 6:35 ` Jianqun Xu
2021-05-10 6:35 ` [PATCH 3/7] gpio: separate gpio driver from pinctrl-rockchip driver Jianqun Xu
2021-05-10 6:35 ` Jianqun Xu
2021-05-25 0:06 ` Linus Walleij
2021-05-25 0:06 ` Linus Walleij
2021-05-10 6:35 ` [PATCH 4/7] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller Jianqun Xu
2021-05-10 6:35 ` Jianqun Xu
2021-05-19 23:23 ` Heiko Stübner
2021-05-19 23:23 ` Heiko Stübner
2021-05-10 6:37 ` [PATCH 5/7] gpio/rockchip: support next version " Jianqun Xu
2021-05-10 6:37 ` Jianqun Xu
2021-05-10 6:37 ` [PATCH 6/7] gpio/rockchip: always enable clock for " Jianqun Xu
2021-05-10 6:37 ` Jianqun Xu
2021-05-13 20:48 ` Heiko Stuebner
2021-05-13 20:48 ` Heiko Stuebner
2021-05-19 23:18 ` Linus Walleij
2021-05-19 23:18 ` Linus Walleij
2021-05-19 23:27 ` Heiko Stübner
2021-05-19 23:27 ` Heiko Stübner
2021-05-10 6:37 ` [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Jianqun Xu
2021-05-10 6:37 ` Jianqun Xu
2021-05-19 23:26 ` Heiko Stübner [this message]
2021-05-19 23:26 ` Heiko Stübner
2021-05-10 22:16 ` [PATCH v4 0/7] gpio-rockchip driver Ezequiel Garcia
2021-05-10 22:16 ` Ezequiel Garcia
2021-05-12 13:29 ` Bartosz Golaszewski
2021-05-12 13:29 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2021-03-24 6:45 [PATCH RESEND " Jianqun Xu
2021-03-24 6:47 ` [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Jianqun Xu
2021-03-24 6:47 ` Jianqun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1817539.g5d078U9FE@diego \
--to=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.